diff mbox series

[v4l-utils] lircd2toml: warn when scancode has duplicate definitions

Message ID 20191231183540.GB10946@gofer.mess.org (mailing list archive)
State New, archived
Headers show
Series [v4l-utils] lircd2toml: warn when scancode has duplicate definitions | expand

Commit Message

Sean Young Dec. 31, 2019, 6:35 p.m. UTC
In lircd.conf files, it is possible that the same scancode has multiple
key definitions. In our rc keymap toml format, one scancode can only
have one key definition.

Possibly we should allow alternate names for scancode for transmitting;
however, as a first step, we should warn if there are multiple
definitions for the same scancode.

Signed-off-by: Sean Young <sean@mess.org>
---
 contrib/lircd2toml.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/contrib/lircd2toml.py b/contrib/lircd2toml.py
index 54ea12fc..ba4b14ec 100755
--- a/contrib/lircd2toml.py
+++ b/contrib/lircd2toml.py
@@ -131,7 +131,11 @@  class LircdParser:
             for s in a:
                 if s[0] == '#':
                     break
-                codes[int(s, 0)] = k
+                scancode = int(s, 0)
+                if scancode in codes:
+                    self.warning("scancode 0x{:x} has duplicate definition {} and {}".format(scancode, codes[scancode], k))
+
+                codes[scancode] = k
 
     def read_raw_codes(self):
         raw_codes = []