From patchwork Thu Apr 16 14:31:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Young X-Patchwork-Id: 11493057 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7CDCA913 for ; Thu, 16 Apr 2020 14:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E41921D7E for ; Thu, 16 Apr 2020 14:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2409637AbgDPObx (ORCPT ); Thu, 16 Apr 2020 10:31:53 -0400 Received: from gofer.mess.org ([88.97.38.141]:40137 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410181AbgDPObp (ORCPT ); Thu, 16 Apr 2020 10:31:45 -0400 Received: by gofer.mess.org (Postfix, from userid 1000) id 19611C634C; Thu, 16 Apr 2020 15:31:44 +0100 (BST) From: Sean Young To: linux-media@vger.kernel.org Cc: Antti Palosaari , Brad Love , coverity-bot Subject: [PATCH] media: m88ds3103: error in set_frontend is swallowed and not reported Date: Thu, 16 Apr 2020 15:31:43 +0100 Message-Id: <20200416143144.19823-1-sean@mess.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Bail out if registers can not be updated. Reported-by: coverity-bot Addresses-Coverity-ID: 1461655 ("Code maintainability issues") Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Signed-off-by: Sean Young --- drivers/media/dvb-frontends/m88ds3103.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c index d2c28dcf6b42..abddab02db9e 100644 --- a/drivers/media/dvb-frontends/m88ds3103.c +++ b/drivers/media/dvb-frontends/m88ds3103.c @@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe) goto err; ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08); + if (ret) + goto err; } dev_dbg(&client->dev, "carrier offset=%d\n",