| Message ID | 20200529200031.4117841-3-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/9] staging: media: atomisp: fix incorrect NULL pointer check | expand |
On Fri, May 29, 2020 at 10:00:25PM +0200, Arnd Bergmann wrote: > atomisp_mrfld_power() has no more callers and produces > a warning: > > drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused function 'atomisp_mrfld_power' [-Werror,-Wunused-function] > > Mark the function as unused while the PM code is being > debugged, expecting that it will be used again in the > future and should not just be removed. > > Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Mauro fixed this in his experimental branch: https://git.linuxtv.org/mchehab/experimental.git/commit/?id=dbcee8118fc9283401df9dbe8ba03ab9d17433ff > --- > drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > index 694268d133c0..10abb35ba0e0 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c > @@ -761,7 +761,8 @@ static void punit_ddr_dvfs_enable(bool enable) > pr_info("DDR DVFS, door bell is not cleared within 3ms\n"); > } > > -static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > +static __attribute__((unused)) int > +atomisp_mrfld_power(struct atomisp_device *isp, bool enable) > { > unsigned long timeout; > u32 val = enable ? MRFLD_ISPSSPM0_IUNIT_POWER_ON : > -- > 2.26.2 >
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 694268d133c0..10abb35ba0e0 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -761,7 +761,8 @@ static void punit_ddr_dvfs_enable(bool enable) pr_info("DDR DVFS, door bell is not cleared within 3ms\n"); } -static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) +static __attribute__((unused)) int +atomisp_mrfld_power(struct atomisp_device *isp, bool enable) { unsigned long timeout; u32 val = enable ? MRFLD_ISPSSPM0_IUNIT_POWER_ON :
atomisp_mrfld_power() has no more callers and produces a warning: drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: error: unused function 'atomisp_mrfld_power' [-Werror,-Wunused-function] Mark the function as unused while the PM code is being debugged, expecting that it will be used again in the future and should not just be removed. Fixes: 95d1f398c4dc ("media: atomisp: keep the ISP powered on when setting it") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)