| Message ID | 20200902224813.14283-3-tfiga@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Galaxycore GC5035 sensor driver | expand |
Self-review, On Thu, Sep 3, 2020 at 12:48 AM Tomasz Figa <tfiga@chromium.org> wrote: > > Add YAML device tree bindings for Galaxycore Inc. GC5035 imaging sensor. > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > --- > .../devicetree/bindings/media/i2c/gc5035.yaml | 142 ++++++++++++++++++ > 1 file changed, 142 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/gc5035.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/gc5035.yaml b/Documentation/devicetree/bindings/media/i2c/gc5035.yaml > new file mode 100644 > index 000000000000..cf8cc3b581cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/gc5035.yaml > @@ -0,0 +1,142 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2019 MediaTek Inc. Copyright 2020 Google LLC. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/gc5035.yaml > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Galaxycore Inc. GC5035 CMOS Sensor Device Tree Bindings > + > +maintainers: > + - Tomasz Figa <tfiga@chromium.org> > + > +description: |- > + The Galaxycore Inc. GC5035 is a 5 megapixel, 1/5 inch CMOS 10-bit Bayer image > + sensor that delivers 2592x1944 at 30fps. This chip is programmable through > + an I2C interface. The image output is available via a MIPI CSI-2 interface. > + > +properties: > + compatible: > + const: galaxycore,gc5035 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Input clock for the sensor. > + items: > + - const: inclk Typo: mclk. > + > + clock-frequency: > + description: > + Frequency of the inclk clock in Hz. mclk > + > + iovdd-supply: > + description: > + Regulator driving the I/O power rail. > + > + avdd28-supply: > + description: > + Regulator driving the analog power rail. > + > + dvdd12-supply: > + description: > + Regulator driving the digital power rail. > + > + resetb-gpios: > + description: > + The GPIO pin that drives the RESETB signal, controlling sensor reset. > + The RESETB signal must be driven low to activate the reset, so the > + GPIO_ACTIVE_LOW flag should be given by default. > + > + pwdn-gpios: > + description: > + The GPIO pin that drives the PWDN signal, controlling sensor power-down > + mode. The PWDN signal must be driven low to activate the power-down > + mode, so the GPIO_ACTIVE_LOW flag should be given by default. > + > + port: > + type: object > + additionalProperties: false > + description: > + A node containing an output port node with an endpoint definition > + as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + > + properties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + data-lanes: > + items: > + - const: 1 > + - const: 2 > + > + link-frequencies: true > + remote-endpoint: true > + > + required: > + - data-lanes > + - link-frequencies > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - clock-frequency > + - iovdd-supply > + - avdd28-supply > + - dvdd12-supply > + - resetb-gpios > + - pwdn-gpios > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + gc5035: camera@10 { > + compatible = "galaxycore,gc5035"; > + reg = <0x10>; > + > + reset-gpios = <&pio 111 GPIO_ACTIVE_LOW>; > + pwdn-gpios = <&pio 112 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&clk_24m_cam>; > + > + clocks = <&cam_osc>; > + clock-names = "inclk"; mclk Best regards, Tomasz
On Wed, 02 Sep 2020 22:48:11 +0000, Tomasz Figa wrote: > Add YAML device tree bindings for Galaxycore Inc. GC5035 imaging sensor. > > Signed-off-by: Tomasz Figa <tfiga@chromium.org> > --- > .../devicetree/bindings/media/i2c/gc5035.yaml | 142 ++++++++++++++++++ > 1 file changed, 142 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/gc5035.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/gc5035.yaml: $id: 'http://devicetree.org/schemas/media/i2c/gc5035.yaml' does not match 'http://devicetree.org/schemas/.*\\.yaml#' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/gc5035.yaml: ignoring, error in schema: $id warning: no schema found in file: ./Documentation/devicetree/bindings/media/i2c/gc5035.yaml See https://patchwork.ozlabs.org/patch/1356170 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/media/i2c/gc5035.yaml b/Documentation/devicetree/bindings/media/i2c/gc5035.yaml new file mode 100644 index 000000000000..cf8cc3b581cf --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/gc5035.yaml @@ -0,0 +1,142 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (c) 2019 MediaTek Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/gc5035.yaml +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Galaxycore Inc. GC5035 CMOS Sensor Device Tree Bindings + +maintainers: + - Tomasz Figa <tfiga@chromium.org> + +description: |- + The Galaxycore Inc. GC5035 is a 5 megapixel, 1/5 inch CMOS 10-bit Bayer image + sensor that delivers 2592x1944 at 30fps. This chip is programmable through + an I2C interface. The image output is available via a MIPI CSI-2 interface. + +properties: + compatible: + const: galaxycore,gc5035 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: + Input clock for the sensor. + items: + - const: inclk + + clock-frequency: + description: + Frequency of the inclk clock in Hz. + + iovdd-supply: + description: + Regulator driving the I/O power rail. + + avdd28-supply: + description: + Regulator driving the analog power rail. + + dvdd12-supply: + description: + Regulator driving the digital power rail. + + resetb-gpios: + description: + The GPIO pin that drives the RESETB signal, controlling sensor reset. + The RESETB signal must be driven low to activate the reset, so the + GPIO_ACTIVE_LOW flag should be given by default. + + pwdn-gpios: + description: + The GPIO pin that drives the PWDN signal, controlling sensor power-down + mode. The PWDN signal must be driven low to activate the power-down + mode, so the GPIO_ACTIVE_LOW flag should be given by default. + + port: + type: object + additionalProperties: false + description: + A node containing an output port node with an endpoint definition + as documented in + Documentation/devicetree/bindings/media/video-interfaces.txt + + properties: + endpoint: + type: object + additionalProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + + link-frequencies: true + remote-endpoint: true + + required: + - data-lanes + - link-frequencies + - remote-endpoint + + required: + - endpoint + +required: + - compatible + - reg + - clocks + - clock-names + - clock-frequency + - iovdd-supply + - avdd28-supply + - dvdd12-supply + - resetb-gpios + - pwdn-gpios + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + gc5035: camera@10 { + compatible = "galaxycore,gc5035"; + reg = <0x10>; + + reset-gpios = <&pio 111 GPIO_ACTIVE_LOW>; + pwdn-gpios = <&pio 112 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&clk_24m_cam>; + + clocks = <&cam_osc>; + clock-names = "inclk"; + clock-frequency = <24000000>; + + avdd28-supply = <&mt6358_vcama2_reg>; + dvdd12-supply = <&mt6358_vcamd_reg>; + iovdd-supply = <&mt6358_vcamio_reg>; + + port { + wcam_out: endpoint { + remote-endpoint = <&mipi_in_wcam>; + data-lanes = <1 2>; + link-frequencies = /bits/ 64 <438000000>; + }; + }; + }; + }; +... +
Add YAML device tree bindings for Galaxycore Inc. GC5035 imaging sensor. Signed-off-by: Tomasz Figa <tfiga@chromium.org> --- .../devicetree/bindings/media/i2c/gc5035.yaml | 142 ++++++++++++++++++ 1 file changed, 142 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/gc5035.yaml