From patchwork Mon Sep 21 16:23:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11790465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E7B29618 for ; Mon, 21 Sep 2020 16:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEC67238D6 for ; Mon, 21 Sep 2020 16:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705589; bh=X5eNs69e9uib1Di8fxv3sS/mwXj3ozPMvlaEhvigxSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2Mek3DVtAvFBhtfG6lY+V/rS+k49hD5u5O5QWISt0Q6d50sulV+xoY1T6pPmAnRPn kZ/L/axg75nbWgAvygqhAiEJ7dU/v7I4DhG3D8p+ylrH7HHwnb84RBkOSvo4I4uuwx qUBlFlHKZtJqT9/Vve6bU/Ew9wPHC1B3ss1o/Wuc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727964AbgIUQ00 (ORCPT ); Mon, 21 Sep 2020 12:26:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:53002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbgIUQ0Z (ORCPT ); Mon, 21 Sep 2020 12:26:25 -0400 Received: from localhost.localdomain (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D80CD238A1; Mon, 21 Sep 2020 16:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705585; bh=X5eNs69e9uib1Di8fxv3sS/mwXj3ozPMvlaEhvigxSw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wi3l/ZU613pyi4CXKhb8H2RP5E/C5KrgVMrqsBS+nCJS1bWaIdwPdguf9OQhDAhH2 t04dZhFrRIZ5crhZA979FVlFrSHa22PlG1CC0OgQXNqcSSgCkbDguUrf6you9v/kzP GGxvZ+ecpxTxrmwL/PJ14RAohLx7Q5nIR/upj2a0= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , Marco Felsch , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 18/25] media: i2c: ov2740: simplify getting state container Date: Mon, 21 Sep 2020 18:23:35 +0200 Message-Id: <20200921162342.7348-18-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200921162342.7348-1-krzk@kernel.org> References: <20200921162342.7348-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov2740.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index bd0d45b0d43f..0d32b0c0ca11 100644 --- a/drivers/media/i2c/ov2740.c +++ b/drivers/media/i2c/ov2740.c @@ -674,8 +674,7 @@ static int ov2740_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused ov2740_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); mutex_lock(&ov2740->mutex); @@ -689,8 +688,7 @@ static int __maybe_unused ov2740_suspend(struct device *dev) static int __maybe_unused ov2740_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); int ret = 0;