From patchwork Thu Oct 29 16:42:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11866855 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 56F131130 for ; Thu, 29 Oct 2020 16:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 340FC20825 for ; Thu, 29 Oct 2020 16:44:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989846; bh=SuIt2NTYlEXZUbdtnMvc08ktKW1WSPW8+MTUSEIg4Hk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LzYV22dw7k+mN4KGDCuOX2R8FnN9mAm7mP+GEeaUOpZGS/akGyXZDmWxXQ6lWEPut aCtjmEQcEJSJ34PAG+2a0w9Obh87lAtFl7fepvirnUVAWRTkWHyqBFtnRi27FZgHcb lVcKMBs1mw3DRvY+yU46+l1WW38BGQMxFaH4JusY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727533AbgJ2QoE (ORCPT ); Thu, 29 Oct 2020 12:44:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:52776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727000AbgJ2QoD (ORCPT ); Thu, 29 Oct 2020 12:44:03 -0400 Received: from localhost.localdomain (adsl-84-226-167-205.adslplus.ch [84.226.167.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04F8F21534; Thu, 29 Oct 2020 16:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603989842; bh=SuIt2NTYlEXZUbdtnMvc08ktKW1WSPW8+MTUSEIg4Hk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YhxTLC2h2Yv/HkDlinA1h5mUb4sopYz3JH0d82pcvu1yyQmVjGG/wL8Qh4LniHtNF bPg0KI95kyqsI1IYDKCpfY+rnzha06gujpUtmgWAjJ0o2Z1yV/qCj9y4QDnrmukb3U xKIEa1ovfk0O3tU39aGbHPElRu9p3yR2H90p9npk= From: Krzysztof Kozlowski To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , Lars-Peter Clausen , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Ricardo Ribalda , Dave Stevenson , Manivannan Sadhasivam , Bingbu Cao , Rui Miguel Silva , Shunqian Zheng , Chiranjeevi Rapolu , Hyungwoo Yang , Wenyou Yang , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RESEND PATCH 18/25] media: i2c: ov2740: simplify getting state container Date: Thu, 29 Oct 2020 17:42:32 +0100 Message-Id: <20201029164239.84240-18-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201029164239.84240-1-krzk@kernel.org> References: <20201029164239.84240-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The pointer to 'struct v4l2_subdev' is stored in drvdata via v4l2_i2c_subdev_init() so there is no point of a dance like: struct i2c_client *client = to_i2c_client(struct device *dev) struct v4l2_subdev *sd = i2c_get_clientdata(client); This allows to remove local variable 'client' and few pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- drivers/media/i2c/ov2740.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index bd0d45b0d43f..0d32b0c0ca11 100644 --- a/drivers/media/i2c/ov2740.c +++ b/drivers/media/i2c/ov2740.c @@ -674,8 +674,7 @@ static int ov2740_set_stream(struct v4l2_subdev *sd, int enable) static int __maybe_unused ov2740_suspend(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); mutex_lock(&ov2740->mutex); @@ -689,8 +688,7 @@ static int __maybe_unused ov2740_suspend(struct device *dev) static int __maybe_unused ov2740_resume(struct device *dev) { - struct i2c_client *client = to_i2c_client(dev); - struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov2740 *ov2740 = to_ov2740(sd); int ret = 0;