[REPOST] media: omap3isp: Remove misleading comment

Commit Message

Sebastian Sewior Nov. 13, 2020, 2:28 p.m. UTC

From: Thomas Gleixner <[e-mail]>

in_interrupt() covers hard and soft interrupt servicing and bottom half
disabled contexts, which is semantically undefined and useless.

The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
therefore as useful as "Context: unknown'. Remove it.

Signed-off-by: Thomas Gleixner <[e-mail]>
Signed-off-by: Sebastian Andrzej Siewior <[e-mail]>
Reviewed-by: Laurent Pinchart <[e-mail]>
Cc: Mauro Carvalho Chehab <[e-mail]>
Cc: Laurent Pinchart <[e-mail]>
Cc: [e-mail]
---
Repost of https://lore.kernel.org/linux-media/[e-mail]/
The other patches in this thread were applied.

 drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Laurent Pinchart Nov. 16, 2020, 9:23 a.m. UTC | #1

Hi Sebastian,

Thank you for the patch.

CC'ing Sakari.

Sakari, could you please pick this one up ?

On Fri, Nov 13, 2020 at 03:28:31PM +0100, Sebastian Andrzej Siewior wrote:
> From: Thomas Gleixner <[e-mail]>
> 
> in_interrupt() covers hard and soft interrupt servicing and bottom half
> disabled contexts, which is semantically undefined and useless.
> 
> The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
> therefore as useful as "Context: unknown'. Remove it.
> 
> Signed-off-by: Thomas Gleixner <[e-mail]>
> Signed-off-by: Sebastian Andrzej Siewior <[e-mail]>
> Reviewed-by: Laurent Pinchart <[e-mail]>
> Cc: Mauro Carvalho Chehab <[e-mail]>
> Cc: Laurent Pinchart <[e-mail]>
> Cc: [e-mail]
> ---
> Repost of https://lore.kernel.org/linux-media/[e-mail]/
> The other patches in this thread were applied.
> 
>  drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
> index 0fbb2aa6dd2c0..4e8905ef362f2 100644
> --- a/drivers/media/platform/omap3isp/ispccdc.c
> +++ b/drivers/media/platform/omap3isp/ispccdc.c
> @@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc_device *ccdc)
>  			     ISPCCDC_LSC_BUSY;
>  }
>  
> -/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
> +/*
> + * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
>   * @ccdc: Pointer to ISP CCDC device
>   * @req: New configuration request
> - *
> - * context: in_interrupt()
>   */
>  static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
>  				struct ispccdc_lsc_config_req *req)

Sebastian Sewior Nov. 25, 2020, 9:01 p.m. UTC | #2

On 2020-11-16 11:23:54 [+0200], Laurent Pinchart wrote:
> Hi Sebastian,
Hi,

> Thank you for the patch.
> 
> CC'ing Sakari.
> 
> Sakari, could you please pick this one up ?

Sakari, does this work for you?

Sebastian

Sakari Ailus Nov. 25, 2020, 9:30 p.m. UTC | #3

On Wed, Nov 25, 2020 at 10:01:54PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-11-16 11:23:54 [+0200], Laurent Pinchart wrote:
> > Hi Sebastian,
> Hi,
> 
> > Thank you for the patch.
> > 
> > CC'ing Sakari.
> > 
> > Sakari, could you please pick this one up ?
> 
> Sakari, does this work for you?

Oops... this one had slipped through. It's in my tree now.

Patch

diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
index 0fbb2aa6dd2c0..4e8905ef362f2 100644
--- a/drivers/media/platform/omap3isp/ispccdc.c
+++ b/drivers/media/platform/omap3isp/ispccdc.c
@@ -299,11 +299,10 @@  static int ccdc_lsc_busy(struct isp_ccdc_device *ccdc)
 			     ISPCCDC_LSC_BUSY;
 }
 
-/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
+/*
+ * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
  * @ccdc: Pointer to ISP CCDC device
  * @req: New configuration request
- *
- * context: in_interrupt()
  */
 static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
 				struct ispccdc_lsc_config_req *req)