| Message ID | 20201216114548.818985-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: vsp1: Use BIT macro for feature identification | expand |
Hi Kieran, Thank you for the patch. On Wed, Dec 16, 2020 at 11:45:48AM +0000, Kieran Bingham wrote: > These entries can only ever be single bits. Make use of the BIT macro > accordingly. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > A minor trivial patch to convert the features to use BIT. > This is used by a patch I have locally for the upcoming VSPX support > where we introduce a new IIF feature. > > That won't be sent for some time, and this update stands on it's own, so > sending here. > > > drivers/media/platform/vsp1/vsp1.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1.h b/drivers/media/platform/vsp1/vsp1.h > index 56c62122a81a..37cf33c7e6ca 100644 > --- a/drivers/media/platform/vsp1/vsp1.h > +++ b/drivers/media/platform/vsp1/vsp1.h > @@ -44,16 +44,16 @@ struct vsp1_uif; > #define VSP1_MAX_UIF 2 > #define VSP1_MAX_WPF 4 > > -#define VSP1_HAS_LUT (1 << 1) > -#define VSP1_HAS_SRU (1 << 2) > -#define VSP1_HAS_BRU (1 << 3) > -#define VSP1_HAS_CLU (1 << 4) > -#define VSP1_HAS_WPF_VFLIP (1 << 5) > -#define VSP1_HAS_WPF_HFLIP (1 << 6) > -#define VSP1_HAS_HGO (1 << 7) > -#define VSP1_HAS_HGT (1 << 8) > -#define VSP1_HAS_BRS (1 << 9) > -#define VSP1_HAS_EXT_DL (1 << 10) > +#define VSP1_HAS_LUT BIT(1) > +#define VSP1_HAS_SRU BIT(2) > +#define VSP1_HAS_BRU BIT(3) > +#define VSP1_HAS_CLU BIT(4) > +#define VSP1_HAS_WPF_VFLIP BIT(5) > +#define VSP1_HAS_WPF_HFLIP BIT(6) > +#define VSP1_HAS_HGO BIT(7) > +#define VSP1_HAS_HGT BIT(8) > +#define VSP1_HAS_BRS BIT(9) > +#define VSP1_HAS_EXT_DL BIT(10) > > struct vsp1_device_info { > u32 version;
diff --git a/drivers/media/platform/vsp1/vsp1.h b/drivers/media/platform/vsp1/vsp1.h index 56c62122a81a..37cf33c7e6ca 100644 --- a/drivers/media/platform/vsp1/vsp1.h +++ b/drivers/media/platform/vsp1/vsp1.h @@ -44,16 +44,16 @@ struct vsp1_uif; #define VSP1_MAX_UIF 2 #define VSP1_MAX_WPF 4 -#define VSP1_HAS_LUT (1 << 1) -#define VSP1_HAS_SRU (1 << 2) -#define VSP1_HAS_BRU (1 << 3) -#define VSP1_HAS_CLU (1 << 4) -#define VSP1_HAS_WPF_VFLIP (1 << 5) -#define VSP1_HAS_WPF_HFLIP (1 << 6) -#define VSP1_HAS_HGO (1 << 7) -#define VSP1_HAS_HGT (1 << 8) -#define VSP1_HAS_BRS (1 << 9) -#define VSP1_HAS_EXT_DL (1 << 10) +#define VSP1_HAS_LUT BIT(1) +#define VSP1_HAS_SRU BIT(2) +#define VSP1_HAS_BRU BIT(3) +#define VSP1_HAS_CLU BIT(4) +#define VSP1_HAS_WPF_VFLIP BIT(5) +#define VSP1_HAS_WPF_HFLIP BIT(6) +#define VSP1_HAS_HGO BIT(7) +#define VSP1_HAS_HGT BIT(8) +#define VSP1_HAS_BRS BIT(9) +#define VSP1_HAS_EXT_DL BIT(10) struct vsp1_device_info { u32 version;
These entries can only ever be single bits. Make use of the BIT macro accordingly. Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- A minor trivial patch to convert the features to use BIT. This is used by a patch I have locally for the upcoming VSPX support where we introduce a new IIF feature. That won't be sent for some time, and this update stands on it's own, so sending here. drivers/media/platform/vsp1/vsp1.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)