[v3,13/16] media: i2c: Re-order runtime pm initialisation

Message ID	20211021214331.1188787-14-djrscally@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-media-owner@kernel.org> From: Daniel Scally <djrscally@gmail.com> To: linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com Cc: Yong Zhi <yong.zhi@intel.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Bingbu Cao <bingbu.cao@intel.com>, Dan Scally <djrscally@gmail.com>, Tianshu Qiu <tian.shu.qiu@intel.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, hdegoede@redhat.com, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com Subject: [PATCH v3 13/16] media: i2c: Re-order runtime pm initialisation Date: Thu, 21 Oct 2021 22:43:28 +0100 Message-Id: <20211021214331.1188787-14-djrscally@gmail.com> In-Reply-To: <20211021214331.1188787-1-djrscally@gmail.com> References: <20211021214331.1188787-1-djrscally@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Extensions to ov8865 driver \| expand [v3,00/16] Extensions to ov8865 driver [v3,01/16] media: i2c: Add ACPI support to ov8865 [v3,02/16] media: i2c: Fix incorrect value in comment [v3,03/16] media: i2c: Defer probe if not endpoint found [v3,04/16] media: i2c: Support 19.2MHz input clock in ov8865 [v3,05/16] media: i2c: Add .get_selection() support to ov8865 [v3,06/16] media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN [v3,07/16] media: i2c: Add vblank control to ov8865 [v3,08/16] media: i2c: Add hblank control to ov8865 [v3,09/16] media: i2c: Update HTS values in ov8865 [v3,10/16] media: i2c: cap exposure at height + vblank in ov8865 [v3,11/16] media: i2c: Add controls from fwnode to ov8865 [v3,12/16] media: i2c: Switch exposure control unit to lines [v3,13/16] media: i2c: Re-order runtime pm initialisation [v3,14/16] media: i2c: Use dev_err_probe() in ov8865 [v3,15/16] media: ipu3-cio2: Add INT347A to cio2-bridge [v3,16/16] media: i2c: ov8865: Fix lockdep error

Message ID

20211021214331.1188787-14-djrscally@gmail.com (mailing list archive)

State

New, archived

Headers

From: Daniel Scally <djrscally@gmail.com>
To: linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com
Cc: Yong Zhi <yong.zhi@intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Dan Scally <djrscally@gmail.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        hdegoede@redhat.com, laurent.pinchart@ideasonboard.com,
        kieran.bingham@ideasonboard.com
Subject: [PATCH v3 13/16] media: i2c: Re-order runtime pm initialisation
Date: Thu, 21 Oct 2021 22:43:28 +0100
Message-Id: <20211021214331.1188787-14-djrscally@gmail.com>
In-Reply-To: <20211021214331.1188787-1-djrscally@gmail.com>
References: <20211021214331.1188787-1-djrscally@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Extensions to ov8865 driver | expand

Commit Message

Daniel Scally Oct. 21, 2021, 9:43 p.m. UTC

The kerneldoc for pm_runtime_set_suspended() says:

"It is not valid to call this function for devices with runtime PM
enabled"

To satisfy that requirement, re-order the calls so that
pm_runtime_enable() is the last one.

Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes in v3:

	- Patch introduced

 drivers/media/i2c/ov8865.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index 0bf3f72892f7..572b9818e950 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -3085,8 +3085,8 @@  static int ov8865_probe(struct i2c_client *client)
 
 	/* Runtime PM */
 
-	pm_runtime_enable(sensor->dev);
 	pm_runtime_set_suspended(sensor->dev);
+	pm_runtime_enable(sensor->dev);
 
 	/* V4L2 subdev register */