| Message ID | 20220424154720.1356873-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: dvbdev: remove redundant initialization of variable ret | expand |
On Sun, Apr 24, 2022 at 04:47:20PM +0100, Colin Ian King wrote: > Variable ret is being ininitialized with a value that is never read. > The ininitializtion is redundant and can be removed. Move the variable > to the scope it is required. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/media/dvb-core/dvbdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c > index 675d877a67b2..d5a142ef9876 100644 > --- a/drivers/media/dvb-core/dvbdev.c > +++ b/drivers/media/dvb-core/dvbdev.c > @@ -243,7 +243,7 @@ static void dvb_media_device_free(struct dvb_device *dvbdev) > static int dvb_create_tsout_entity(struct dvb_device *dvbdev, > const char *name, int npads) > { > - int i, ret = 0; > + int i; It's better when "ret" has function scope. Otherwise in the future when someone adds a "ret" you're going to end up with two "ret" variables. regards, dan carpenter
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index 675d877a67b2..d5a142ef9876 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -243,7 +243,7 @@ static void dvb_media_device_free(struct dvb_device *dvbdev) static int dvb_create_tsout_entity(struct dvb_device *dvbdev, const char *name, int npads) { - int i, ret = 0; + int i; dvbdev->tsout_pads = kcalloc(npads, sizeof(*dvbdev->tsout_pads), GFP_KERNEL); @@ -260,6 +260,7 @@ static int dvb_create_tsout_entity(struct dvb_device *dvbdev, for (i = 0; i < npads; i++) { struct media_pad *pads = &dvbdev->tsout_pads[i]; struct media_entity *entity = &dvbdev->tsout_entity[i]; + int ret; entity->name = kasprintf(GFP_KERNEL, "%s #%d", name, i); if (!entity->name)
Variable ret is being ininitialized with a value that is never read. The ininitializtion is redundant and can be removed. Move the variable to the scope it is required. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/media/dvb-core/dvbdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)