@@ -254,8 +254,10 @@ uvc_function_setup(struct usb_function *f, const struct usb_ctrlrequest *ctrl)
*/
mctrl = &uvc_event->req;
mctrl->wIndex &= ~cpu_to_le16(0xff);
- if (interface == uvc->streaming_intf)
+ if (interface == uvc->streaming_intf) {
+ uvc->streaming_request = ctrl->bRequest;
mctrl->wIndex = cpu_to_le16(UVC_STRING_STREAMING_IDX);
+ }
v4l2_event_queue(&uvc->vdev, &v4l2_event);
@@ -151,6 +151,7 @@ struct uvc_device {
void *control_buf;
unsigned int streaming_intf;
+ unsigned char streaming_request;
/* Events */
unsigned int event_length;
@@ -178,6 +178,67 @@ static struct uvcg_frame *find_closest_frame_by_size(struct uvc_device *uvc,
* Requests handling
*/
+/* validate and fixup streaming ctrl request response data if possible */
+static void
+uvc_validate_streaming_ctrl(struct uvc_device *uvc,
+ struct uvc_streaming_control *ctrl)
+{
+ struct f_uvc_opts *opts = fi_to_f_uvc_opts(uvc->func.fi);
+ unsigned int iformat, iframe;
+ struct uvcg_format *uformat;
+ struct uvcg_frame *uframe;
+ bool ival_found = false;
+ int i;
+
+ iformat = ctrl->bFormatIndex;
+ iframe = ctrl->bFrameIndex;
+
+ /* Restrict the iformat, iframe and dwFrameInterval to valid values.
+ * Negative values for iformat and iframe will result in the maximum
+ * valid value being selected
+ */
+ iformat = clamp((unsigned int)iformat, 1U,
+ (unsigned int)uvc->header->num_fmt);
+ if (iformat != ctrl->bFormatIndex) {
+ uvcg_info(&uvc->func,
+ "Userspace set invalid Format Index - fixup\n");
+ ctrl->bFormatIndex = iformat;
+ }
+ uformat = find_format_by_index(uvc, iformat);
+
+ iframe = clamp((unsigned int)iframe, 1U,
+ (unsigned int)uformat->num_frames);
+ if (iframe != ctrl->bFrameIndex) {
+ uvcg_info(&uvc->func,
+ "Userspace set invalid Frame Index - fixup\n");
+ ctrl->bFrameIndex = iframe;
+ }
+ uframe = find_frame_by_index(uvc, uformat, iframe);
+
+ if (ctrl->dwFrameInterval) {
+ for (i = 0; i < uframe->frame.b_frame_interval_type; i++) {
+ if (ctrl->dwFrameInterval ==
+ uframe->dw_frame_interval[i])
+ ival_found = true;
+ }
+ }
+ if (!ival_found) {
+ uvcg_info(&uvc->func,
+ "Userspace set invalid Frame Inteval - fixup\n");
+ ctrl->dwFrameInterval = uframe->frame.dw_default_frame_interval;
+ }
+
+ if (!ctrl->dwMaxPayloadTransferSize ||
+ ctrl->dwMaxPayloadTransferSize >
+ opts->streaming_maxpacket)
+ ctrl->dwMaxPayloadTransferSize = opts->streaming_maxpacket;
+
+ if (!ctrl->dwMaxVideoFrameSize ||
+ ctrl->dwMaxVideoFrameSize >
+ uframe->frame.dw_max_video_frame_buffer_size)
+ ctrl->dwMaxVideoFrameSize = uvc_get_frame_size(uformat, uframe);
+}
+
static int
uvc_send_response(struct uvc_device *uvc, struct uvc_request_data *data)
{
@@ -192,6 +253,21 @@ uvc_send_response(struct uvc_device *uvc, struct uvc_request_data *data)
memcpy(req->buf, data->data, req->length);
+ /* validate the ctrl content and fixup */
+ if (!uvc->event_setup_out) {
+ struct uvc_streaming_control *ctrl = req->buf;
+
+ switch (uvc->streaming_request) {
+ case UVC_GET_CUR:
+ case UVC_GET_MIN:
+ case UVC_GET_MAX:
+ case UVC_GET_DEF:
+ uvc_validate_streaming_ctrl(uvc, ctrl);
+ default:
+ break;
+ }
+ }
+
return usb_ep_queue(cdev->gadget->ep0, req, GFP_KERNEL);
}
When the userspace gets the setup requests for UVC_GET_CUR UVC_GET_MIN, UVC_GET_MAX, UVC_GET_DEF it will fill out the ctrl response. This data needs to be validated. Since the kernel also knows the limits for valid cases, it can fixup the values in case the userspace is setting invalid data. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- v1 -> v4: - new patch Since the patch: d182bf156c4 (usb: gadget: uvc: default the ctrl request interface offset) is now in the usb-next tree, I resend this patch again, as it is no part of any series anymore. drivers/usb/gadget/function/f_uvc.c | 4 +- drivers/usb/gadget/function/uvc.h | 1 + drivers/usb/gadget/function/uvc_v4l2.c | 76 ++++++++++++++++++++++++++ 3 files changed, 80 insertions(+), 1 deletion(-)