From patchwork Mon Nov 7 20:49:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 13035209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A53C43219 for ; Mon, 7 Nov 2022 20:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233055AbiKGUuZ (ORCPT ); Mon, 7 Nov 2022 15:50:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233040AbiKGUuX (ORCPT ); Mon, 7 Nov 2022 15:50:23 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8352227176 for ; Mon, 7 Nov 2022 12:50:22 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id AAE53FF80B; Mon, 7 Nov 2022 20:50:19 +0000 (UTC) From: Jacopo Mondi To: Sakari Ailus , Laurent Pinchart , Dave Stevenson , Hans Verkuil , Mauro Carvalho Chehab Cc: Jacopo Mondi , Linux Media Mailing List Subject: [PATCH 2/3] documentation: media: camera_sensor: Document blankings handling Date: Mon, 7 Nov 2022 21:49:58 +0100 Message-Id: <20221107204959.37691-3-jacopo@jmondi.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221107204959.37691-1-jacopo@jmondi.org> References: <20221107204959.37691-1-jacopo@jmondi.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org When a new image format is applied on the sensor it is necessary to update the vertical and horizontal blanking limits, to comply with the new visibile sizes. Add that part to the documentation of camera sensor subdevices. Signed-off-by: Jacopo Mondi --- .../driver-api/media/camera-sensor.rst | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/Documentation/driver-api/media/camera-sensor.rst b/Documentation/driver-api/media/camera-sensor.rst index bb7d62db4cd1..31f74f85ebc5 100644 --- a/Documentation/driver-api/media/camera-sensor.rst +++ b/Documentation/driver-api/media/camera-sensor.rst @@ -107,6 +107,35 @@ The first entity in the linear pipeline is the pixel array. The pixel array may be followed by other entities that are there to allow configuring binning, skipping, scaling or digital crop :ref:`v4l2-subdev-selections`. +Blankings initialization and reconfiguration +"""""""""""""""""""""""""""""""""""""""""""" + +The value used to initialize the vertical and horizontal blanking controls +should be selected in order to realize, in association with the driver default +format and default pixel rate, a reasonable frame rate output, usually one of +the standard 15, 30 or 60 frame per second. + +When a new frame size is applied on the subdevice sensor drivers are requested +to update the limits of their blankings controls. + +The V4L2 control framework provides the ``v4l2_ctrl_modify_range()`` function +(and the unlocked ``__v4l2_ctrl_modify_range()`` counterpart) to assist drivers +in re-computing the controls limits. + +The new maximum limit for the controls should be re-calculated using the +newly applied visibile width and height + +.. code-block:: c + + max_vblank = MAX_VTS - sensor->fmt.height; + ret = __v4l2_ctrl_modify_range(sensor->ctrls.vblank, + sensor->ctrls.vblank->minimum, + max_vblank, sensor->ctrls.vblank->step, + sensor->ctrls.vblank->minimum); + +The blankings default value is reset to the control minimum and the V4L2 +control framework automatically clamps the control's value in the new limits. + USB cameras etc. devices ~~~~~~~~~~~~~~~~~~~~~~~~