diff mbox series

[v11,3/7] dt-bindings: arm: nuvoton: Add NPCM GFXI

Message ID 20230207091902.2512905-4-milkfafa@gmail.com (mailing list archive)
State New, archived
Headers show
Series Support Nuvoton NPCM Video Capture/Encode Engine | expand

Commit Message

Marvin Lin Feb. 7, 2023, 9:18 a.m. UTC 
Add dt-bindings document for Graphics Core Information (GFXI) node. It
is used by NPCM video driver to retrieve Graphics core information.

Signed-off-by: Marvin Lin <milkfafa@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/arm/npcm/nuvoton,gfxi.yaml       | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml

Comments

Krzysztof Kozlowski Feb. 7, 2023, 9:25 a.m. UTC | #1 
On 07/02/2023 10:18, Marvin Lin wrote:
> Add dt-bindings document for Graphics Core Information (GFXI) node. It
> is used by NPCM video driver to retrieve Graphics core information.
> 
> Signed-off-by: Marvin Lin <milkfafa@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/arm/npcm/nuvoton,gfxi.yaml       | 39 +++++++++++++++++++

This is still wrong location. arm is only for top-level pieces. You
wanted to put it in soc.

Best regards,
Krzysztof
Marvin Lin Feb. 9, 2023, 12:40 a.m. UTC | #2 
Hi Krzysztof,

Thank you for the review.

> >  .../bindings/arm/npcm/nuvoton,gfxi.yaml       | 39 +++++++++++++++++++
>
> This is still wrong location. arm is only for top-level pieces. You
> wanted to put it in soc.

I'll move it to Documentation/devicetree/bindings/soc/npcm/nuvoton,gfxi.yaml.

Regards,
Marvin
Hans Verkuil June 6, 2023, 10:37 a.m. UTC | #3 
On 09/02/2023 01:40, Kun-Fa Lin wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
>>>  .../bindings/arm/npcm/nuvoton,gfxi.yaml       | 39 +++++++++++++++++++
>>
>> This is still wrong location. arm is only for top-level pieces. You
>> wanted to put it in soc.
> 
> I'll move it to Documentation/devicetree/bindings/soc/npcm/nuvoton,gfxi.yaml.

v12 still has this in the old location, so it appears you forgot this.

Regards,

	Hans

> 
> Regards,
> Marvin
Marvin Lin June 29, 2023, 12:19 p.m. UTC | #4 
Hi Hans,

Sorry for the late response.


> > I'll move it to Documentation/devicetree/bindings/soc/npcm/nuvoton,gfxi.yaml.
>
> v12 still has this in the old location, so it appears you forgot this.

Thanks for the reminder, v13 will correct the path.

Regards,
Marvin
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml
new file mode 100644
index 000000000000..c033128e567a
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml
@@ -0,0 +1,39 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/npcm/nuvoton,gfxi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Graphics Core Information block in Nuvoton SoCs
+
+maintainers:
+  - Joseph Liu <kwliu@nuvoton.com>
+  - Marvin Lin <kflin@nuvoton.com>
+
+description:
+  The Graphics Core Information (GFXI) are a block of registers in Nuvoton SoCs
+  that analyzes Graphics core behavior and provides information in registers.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - nuvoton,npcm750-gfxi
+          - nuvoton,npcm845-gfxi
+      - const: syscon
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    gfxi: gfxi@e000 {
+      compatible = "nuvoton,npcm750-gfxi", "syscon";
+      reg = <0xe000 0x100>;
+    };