diff mbox series

[3/3] media: atomisp: Mark ia_css_isys_240?_init() static

Message ID 20230715170906.3627-3-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show
Series [1/3] media: atomisp: Remove empty isys_public.h | expand

Commit Message

Hans de Goede July 15, 2023, 5:09 p.m. UTC 
ia_css_isys_240?_init() are only used inside the C file where they are
declared, mark them as static fixing:

drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:24:20:
   warning: no previous prototype for 'ia_css_isys_2400_init'
   24 | input_system_err_t ia_css_isys_2400_init(void)
      |                    ^~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:87:20:
   warning: no previous prototype for 'ia_css_isys_2401_init'
   87 | input_system_err_t ia_css_isys_2401_init(void)
      |                    ^~~~~~~~~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307152046.rvhFGrbz-lkp@intel.com/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 .../staging/media/atomisp/pci/runtime/isys/src/isys_init.c    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kate Hsuan July 17, 2023, 3:01 a.m. UTC | #1 
Hi Hans,

On Sun, Jul 16, 2023 at 1:09 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> ia_css_isys_240?_init() are only used inside the C file where they are
> declared, mark them as static fixing:
>
> drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:24:20:
>    warning: no previous prototype for 'ia_css_isys_2400_init'
>    24 | input_system_err_t ia_css_isys_2400_init(void)
>       |                    ^~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:87:20:
>    warning: no previous prototype for 'ia_css_isys_2401_init'
>    87 | input_system_err_t ia_css_isys_2401_init(void)
>       |                    ^~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307152046.rvhFGrbz-lkp@intel.com/
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  .../staging/media/atomisp/pci/runtime/isys/src/isys_init.c    | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
> index 1a7b45bb4544..18bfe1010989 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
> @@ -21,7 +21,7 @@
>  #include "isys_dma_public.h"   /* isys2401_dma_set_max_burst_size() */
>  #include "isys_irq.h"
>
> -input_system_err_t ia_css_isys_2400_init(void)
> +static input_system_err_t ia_css_isys_2400_init(void)
>  {
>         backend_channel_cfg_t backend_ch0;
>         backend_channel_cfg_t backend_ch1;
> @@ -84,7 +84,7 @@ input_system_err_t ia_css_isys_2400_init(void)
>         return error;
>  }
>
> -input_system_err_t ia_css_isys_2401_init(void)
> +static input_system_err_t ia_css_isys_2401_init(void)
>  {
>         ia_css_isys_csi_rx_lut_rmgr_init();
>         ia_css_isys_ibuf_rmgr_init();
> --
> 2.41.0
>

Thank you for working on this.

It looks good to me.

Reviewed-by: Kate Hsuan <hpa@redhat.com>


--
BR,
Kate
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
index 1a7b45bb4544..18bfe1010989 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c
@@ -21,7 +21,7 @@ 
 #include "isys_dma_public.h"	/* isys2401_dma_set_max_burst_size() */
 #include "isys_irq.h"
 
-input_system_err_t ia_css_isys_2400_init(void)
+static input_system_err_t ia_css_isys_2400_init(void)
 {
 	backend_channel_cfg_t backend_ch0;
 	backend_channel_cfg_t backend_ch1;
@@ -84,7 +84,7 @@  input_system_err_t ia_css_isys_2400_init(void)
 	return error;
 }
 
-input_system_err_t ia_css_isys_2401_init(void)
+static input_system_err_t ia_css_isys_2401_init(void)
 {
 	ia_css_isys_csi_rx_lut_rmgr_init();
 	ia_css_isys_ibuf_rmgr_init();