| Message ID | 20230821152623.196541-2-sean@mess.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove ir-rx51 driver | expand |
Please use get_maintainers.pl and send patches to the right place. Like the other DT maintainers and DT list... On Mon, Aug 21, 2023 at 10:26 AM Sean Young <sean@mess.org> wrote: > > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir > can be removed. How long has this been true? You are breaking users if they are on a version of OS where the pwm-ir-tx driver doesn't work (or didn't exist or wasn't enabled). I suspect this is a platform that will care about the ABI. What you should do is make the "nokia,n900-ir" compatible work with the generic driver. Then old driver works still, the generic driver works on new OS versions, and the DTB doesn't change. Rob
On Mon, Aug 21, 2023 at 01:56:56PM -0500, Rob Herring wrote: > Please use get_maintainers.pl and send patches to the right place. > Like the other DT maintainers and DT list... Noted, my bad. > On Mon, Aug 21, 2023 at 10:26 AM Sean Young <sean@mess.org> wrote: > > > > The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir > > can be removed. > > How long has this been true? You are breaking users if they are on a > version of OS where the pwm-ir-tx driver doesn't work (or didn't exist > or wasn't enabled). I suspect this is a platform that will care about > the ABI. > > What you should do is make the "nokia,n900-ir" compatible work with > the generic driver. Then old driver works still, the generic driver > works on new OS versions, and the DTB doesn't change. That makes a lot of sense. I'll re-roll. Thanks for the feedback. Sean
diff --git a/Documentation/devicetree/bindings/media/nokia,n900-ir b/Documentation/devicetree/bindings/media/nokia,n900-ir deleted file mode 100644 index 13a18ce37dd1..000000000000 --- a/Documentation/devicetree/bindings/media/nokia,n900-ir +++ /dev/null @@ -1,20 +0,0 @@ -Device-Tree bindings for LIRC TX driver for Nokia N900(RX51) - -Required properties: - - compatible: should be "nokia,n900-ir". - - pwms: specifies PWM used for IR signal transmission. - -Example node: - - pwm9: dmtimer-pwm@9 { - compatible = "ti,omap-dmtimer-pwm"; - ti,timers = <&timer9>; - ti,clock-source = <0x00>; /* timer_sys_ck */ - #pwm-cells = <3>; - }; - - ir: n900-ir { - compatible = "nokia,n900-ir"; - - pwms = <&pwm9 0 26316 0>; /* 38000 Hz */ - }; diff --git a/arch/arm/boot/dts/ti/omap/omap3-n900.dts b/arch/arm/boot/dts/ti/omap/omap3-n900.dts index d33485341251..83ab2d6faee6 100644 --- a/arch/arm/boot/dts/ti/omap/omap3-n900.dts +++ b/arch/arm/boot/dts/ti/omap/omap3-n900.dts @@ -165,7 +165,7 @@ pwm9: pwm-9 { }; ir: n900-ir { - compatible = "nokia,n900-ir"; + compatible = "pwm-ir-tx"; pwms = <&pwm9 0 26316 0>; /* 38000 Hz */ };
The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir can be removed. Cc: Sicelo <absicsz@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Cc: Pali Rohár <pali.rohar@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Timo Kokkonen <timo.t.kokkonen@iki.fi> Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Sean Young <sean@mess.org> --- .../devicetree/bindings/media/nokia,n900-ir | 20 ------------------- arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 +- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir