diff mbox series

uvc_driver: Error Fix in the file drivers/media/usb/uvc/uvc_driver.c

Message ID 20230903095431.28711-1-fasih0001@gmail.com (mailing list archive)
State New, archived
Headers show
Series uvc_driver: Error Fix in the file drivers/media/usb/uvc/uvc_driver.c | expand

Commit Message

fasih0001@gmail.com Sept. 3, 2023, 9:54 a.m. UTC 
From: Fasih <fasih0001@gmail.com>

Error fix for the line 2429 and 2430, The error message indicated that "Macros with complex values should be enclosed in parentheses".
This typically means that the macro is defined in a way that involves complex expressions or compound literals,
and the preprocessor requires them to be enclosed in parentheses for clarity and proper evaluation.
To address this error and comply with the requirement to enclose complex values in parentheses,
you should wrap the entire expression inside an extra set of parentheses.

Signed-off-by: Syed Muhammad Fasih Ul Hassan <fasih0001@gmail.com>

Comments

Laurent Pinchart Sept. 3, 2023, 8:59 p.m. UTC | #1 
Hello,

On Sun, Sep 03, 2023 at 02:54:31PM +0500, fasih0001@gmail.com wrote:
> From: Fasih <fasih0001@gmail.com>
> 
> Error fix for the line 2429 and 2430, The error message indicated that "Macros with complex values should be enclosed in parentheses".
> This typically means that the macro is defined in a way that involves complex expressions or compound literals,
> and the preprocessor requires them to be enclosed in parentheses for clarity and proper evaluation.
> To address this error and comply with the requirement to enclose complex values in parentheses,
> you should wrap the entire expression inside an extra set of parentheses.

Did you read Documentation/process/submitting-patches.rst ?

> Signed-off-by: Syed Muhammad Fasih Ul Hassan <fasih0001@gmail.com>
> 
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2095,6 +2095,8 @@ static int uvc_probe(struct usb_interface *intf,
>         int function;
>         int ret;
> 
> +       pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> +

Have you read our patch before sending it out ?

>         /* Allocate memory for the device and initialize it. */
>         dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>         if (dev == NULL)
> @@ -2417,9 +2419,9 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
>         .quirks = UVC_QUIRK_FORCE_Y8,
>  };
> 
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> -       {.meta_format = m}
> +#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
> +#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) \
> +       {.meta_format = m})

Why do you think this is a good change ?

> ---
>  drivers/media/usb/uvc/uvc_driver.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 

Your patch seems corrupted.

> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 08fcd2ffa727..42d42b211094 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2095,6 +2095,8 @@ static int uvc_probe(struct usb_interface *intf,
>  	int function;
>  	int ret;
>  
> +	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> +
>  	/* Allocate memory for the device and initialize it. */
>  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>  	if (dev == NULL)
> @@ -2417,9 +2419,16 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
>  	.quirks = UVC_QUIRK_FORCE_Y8,
>  };
>  
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> -	{.meta_format = m}
> +/* For line 2429 and 2430, The error message indicated that "Macros with complex values should be enclosed in parentheses".
> + * This typically means that the macro is defined in a way that involves complex expressions or compound literals,
> + * and the preprocessor requires them to be enclosed in parentheses for clarity and proper evaluation.
> + * To address this error and comply with the requirement to enclose complex values in parentheses,
> + * you should wrap the entire expression inside an extra set of parentheses like that:
> + * #define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
> + */
> +#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
> +#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) \
> +	{.meta_format = m})
>  
>  /*
>   * The Logitech cameras listed below have their interface class set to
diff mbox series

Patch

--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2095,6 +2095,8 @@  static int uvc_probe(struct usb_interface *intf,
        int function;
        int ret;

+       pr_info("I changed uvcvideo driver in the Linux Kernel\n");
+
        /* Allocate memory for the device and initialize it. */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        if (dev == NULL)
@@ -2417,9 +2419,9 @@  static const struct uvc_device_info uvc_quirk_force_y8 = {
        .quirks = UVC_QUIRK_FORCE_Y8,
 };

-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
-       {.meta_format = m}
+#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
+#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) \
+       {.meta_format = m})
---
 drivers/media/usb/uvc/uvc_driver.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 08fcd2ffa727..42d42b211094 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2095,6 +2095,8 @@  static int uvc_probe(struct usb_interface *intf,
 	int function;
 	int ret;
 
+	pr_info("I changed uvcvideo driver in the Linux Kernel\n");
+
 	/* Allocate memory for the device and initialize it. */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (dev == NULL)
@@ -2417,9 +2419,16 @@  static const struct uvc_device_info uvc_quirk_force_y8 = {
 	.quirks = UVC_QUIRK_FORCE_Y8,
 };
 
-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
-	{.meta_format = m}
+/* For line 2429 and 2430, The error message indicated that "Macros with complex values should be enclosed in parentheses".
+ * This typically means that the macro is defined in a way that involves complex expressions or compound literals,
+ * and the preprocessor requires them to be enclosed in parentheses for clarity and proper evaluation.
+ * To address this error and comply with the requirement to enclose complex values in parentheses,
+ * you should wrap the entire expression inside an extra set of parentheses like that:
+ * #define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
+ */
+#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
+#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) \
+	{.meta_format = m})
 
 /*
  * The Logitech cameras listed below have their interface class set to