| Message ID | 20230914181704.4811-4-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: Reduce cargo cult | expand |
Am Donnerstag, dem 14.09.2023 um 21:16 +0300 schrieb Laurent Pinchart: > The subdev .s_stream() operation shall not be called to start > streaming > on an already started subdev, or stop streaming on a stopped subdev. > Remove the check that guards against that condition. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/hi846.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c > index fa0038749a3b..746e1f75f9d0 100644 > --- a/drivers/media/i2c/hi846.c > +++ b/drivers/media/i2c/hi846.c > @@ -1607,9 +1607,6 @@ static int hi846_set_stream(struct v4l2_subdev > *sd, int enable) > struct i2c_client *client = v4l2_get_subdevdata(sd); > int ret = 0; > > - if (hi846->streaming == enable) > - return 0; > - > mutex_lock(&hi846->mutex); > > if (enable) { Tested-by: Martin Kepplinger <martink@posteo.de> thanks Laurent, martin
diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index fa0038749a3b..746e1f75f9d0 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -1607,9 +1607,6 @@ static int hi846_set_stream(struct v4l2_subdev *sd, int enable) struct i2c_client *client = v4l2_get_subdevdata(sd); int ret = 0; - if (hi846->streaming == enable) - return 0; - mutex_lock(&hi846->mutex); if (enable) {
The subdev .s_stream() operation shall not be called to start streaming on an already started subdev, or stop streaming on a stopped subdev. Remove the check that guards against that condition. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/i2c/hi846.c | 3 --- 1 file changed, 3 deletions(-)