| Message ID | 20230914181704.4811-7-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: i2c: Reduce cargo cult | expand |
Hi Laurent On Thu, 14 Sept 2023 at 19:16, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > The subdev .s_stream() operation shall not be called to start streaming > on an already started subdev, or stop streaming on a stopped subdev. > Remove the check that guards against that condition. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/media/i2c/imx219.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index a1136fdfbed2..5715bbbc0820 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -979,9 +979,6 @@ static int imx219_set_stream(struct v4l2_subdev *sd, int enable) > > state = v4l2_subdev_lock_and_get_active_state(sd); > > - if (imx219->streaming == enable) > - goto unlock; > - > if (enable) { > /* > * Apply default & customized values > -- > Regards, > > Laurent Pinchart >
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index a1136fdfbed2..5715bbbc0820 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -979,9 +979,6 @@ static int imx219_set_stream(struct v4l2_subdev *sd, int enable) state = v4l2_subdev_lock_and_get_active_state(sd); - if (imx219->streaming == enable) - goto unlock; - if (enable) { /* * Apply default & customized values
The subdev .s_stream() operation shall not be called to start streaming on an already started subdev, or stop streaming on a stopped subdev. Remove the check that guards against that condition. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/media/i2c/imx219.c | 3 --- 1 file changed, 3 deletions(-)