| Message ID | 20230921063620.22962-2-ming.qian@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder | expand |
On 21/09/2023 08:36, Ming Qian wrote: > There are total 4 slots available in the IP, > and we only need to use one slot in one os, > assign a single slot, > configure interrupt and power domain only for 1 slot, > not for the all 4 slots. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. > > Signed-off-by: Ming Qian <ming.qian@nxp.com> > --- > .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++----------- > 1 file changed, 16 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..5f0e2fc1ea9c 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -32,25 +32,27 @@ properties: > maxItems: 1 > > interrupts: > - description: | > - There are 4 slots available in the IP, which the driver may use > - If a certain slot is used, it should have an associated interrupt > - The interrupt with index i is assumed to be for slot i > - minItems: 1 # At least one slot is needed by the driver > - maxItems: 4 # The IP has 4 slots available for use > + description: > + Interrupt number for slot > + maxItems: 1 > > power-domains: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > - maxItems: 5 # Wrapper and 4 slots > + minItems: 1 # VPUMIX > + maxItems: 2 # Wrapper and 1 slot > + > + slot: > + description: > + Integer number of slot index used. the value range is from 0 to 3 Don't you have here obvious errors reported by testing? Did you test this? Best regards, Krzysztof
>From: Krzysztof Kozlowski <krzk@kernel.org> >Sent: 2023年9月21日 17:55 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; linux- >media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >kernel@lists.infradead.org >Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for >imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 21/09/2023 08:36, Ming Qian wrote: >> There are total 4 slots available in the IP, and we only need to use >> one slot in one os, assign a single slot, configure interrupt and >> power domain only for 1 slot, not for the all 4 slots. > >Please use scripts/get_maintainers.pl to get a list of necessary people and lists >to CC. It might happen, that command when run on an older kernel, gives you >outdated entries. Therefore please be sure you base your patches on recent >Linux kernel. > >You missed at least devicetree list (maybe more), so this won't be tested by >automated tooling. Performing review on untested code might be a waste of >time, thus I will skip this patch entirely till you follow the process allowing the >patch to be tested. > >Please kindly resend and include all necessary To/Cc entries. > >> >> Signed-off-by: Ming Qian <ming.qian@nxp.com> >> --- >> .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++----------- >> 1 file changed, 16 insertions(+), 24 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> index 3d9d1db37040..5f0e2fc1ea9c 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> @@ -32,25 +32,27 @@ properties: >> maxItems: 1 >> >> interrupts: >> - description: | >> - There are 4 slots available in the IP, which the driver may use >> - If a certain slot is used, it should have an associated interrupt >> - The interrupt with index i is assumed to be for slot i >> - minItems: 1 # At least one slot is needed by the driver >> - maxItems: 4 # The IP has 4 slots available for use >> + description: >> + Interrupt number for slot >> + maxItems: 1 >> >> power-domains: >> description: >> List of phandle and PM domain specifier as documented in >> Documentation/devicetree/bindings/power/power_domain.txt >> - minItems: 2 # Wrapper and 1 slot >> - maxItems: 5 # Wrapper and 4 slots >> + minItems: 1 # VPUMIX >> + maxItems: 2 # Wrapper and 1 slot >> + >> + slot: >> + description: >> + Integer number of slot index used. the value range is from 0 to >> + 3 > >Don't you have here obvious errors reported by testing? Did you test this? > >Best regards, >Krzysztof Hi Krzysztof, Can you point out which test error? I run the dt_binding_check and didn't get any error. make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTEX Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dts DTC_CHK Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dtb
On 22/09/2023 03:33, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: 2023年9月21日 17:55 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; linux- >> media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org >> Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for >> imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 21/09/2023 08:36, Ming Qian wrote: >>> There are total 4 slots available in the IP, and we only need to use >>> one slot in one os, assign a single slot, configure interrupt and >>> power domain only for 1 slot, not for the all 4 slots. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people and lists >> to CC. It might happen, that command when run on an older kernel, gives you >> outdated entries. Therefore please be sure you base your patches on recent >> Linux kernel. >> >> You missed at least devicetree list (maybe more), so this won't be tested by >> automated tooling. Performing review on untested code might be a waste of >> time, thus I will skip this patch entirely till you follow the process allowing the >> patch to be tested. >> >> Please kindly resend and include all necessary To/Cc entries. >> >>> >>> Signed-off-by: Ming Qian <ming.qian@nxp.com> >>> --- >>> .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++----------- >>> 1 file changed, 16 insertions(+), 24 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>> index 3d9d1db37040..5f0e2fc1ea9c 100644 >>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >>> @@ -32,25 +32,27 @@ properties: >>> maxItems: 1 >>> >>> interrupts: >>> - description: | >>> - There are 4 slots available in the IP, which the driver may use >>> - If a certain slot is used, it should have an associated interrupt >>> - The interrupt with index i is assumed to be for slot i >>> - minItems: 1 # At least one slot is needed by the driver >>> - maxItems: 4 # The IP has 4 slots available for use >>> + description: >>> + Interrupt number for slot >>> + maxItems: 1 >>> >>> power-domains: >>> description: >>> List of phandle and PM domain specifier as documented in >>> Documentation/devicetree/bindings/power/power_domain.txt >>> - minItems: 2 # Wrapper and 1 slot >>> - maxItems: 5 # Wrapper and 4 slots >>> + minItems: 1 # VPUMIX >>> + maxItems: 2 # Wrapper and 1 slot >>> + >>> + slot: >>> + description: >>> + Integer number of slot index used. the value range is from 0 to >>> + 3 >> >> Don't you have here obvious errors reported by testing? Did you test this? >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > Can you point out which test error? I run the dt_binding_check and didn't get any error. Hm, I guess we need to add some checks for this... You miss type and vendor prefix. This does not look like generic property. Constraints are also missing, but that's minor. The main point is that this does not look suitable for DT at all. Your description says nothing - copies property name. Commit msg also does not explain it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index 3d9d1db37040..5f0e2fc1ea9c 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml @@ -32,25 +32,27 @@ properties: maxItems: 1 interrupts: - description: | - There are 4 slots available in the IP, which the driver may use - If a certain slot is used, it should have an associated interrupt - The interrupt with index i is assumed to be for slot i - minItems: 1 # At least one slot is needed by the driver - maxItems: 4 # The IP has 4 slots available for use + description: + Interrupt number for slot + maxItems: 1 power-domains: description: List of phandle and PM domain specifier as documented in Documentation/devicetree/bindings/power/power_domain.txt - minItems: 2 # Wrapper and 1 slot - maxItems: 5 # Wrapper and 4 slots + minItems: 1 # VPUMIX + maxItems: 2 # Wrapper and 1 slot + + slot: + description: + Integer number of slot index used. the value range is from 0 to 3 required: - compatible - reg - interrupts - power-domains + - slot additionalProperties: false @@ -62,28 +64,18 @@ examples: jpegdec: jpegdec@58400000 { compatible = "nxp,imx8qxp-jpgdec"; reg = <0x58400000 0x00050000 >; - interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>; power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, - <&pd IMX_SC_R_MJPEG_DEC_S0>, - <&pd IMX_SC_R_MJPEG_DEC_S1>, - <&pd IMX_SC_R_MJPEG_DEC_S2>, - <&pd IMX_SC_R_MJPEG_DEC_S3>; + <&pd IMX_SC_R_MJPEG_DEC_S0>; + slot = <0>; }; jpegenc: jpegenc@58450000 { compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; reg = <0x58450000 0x00050000 >; - interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>; power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, - <&pd IMX_SC_R_MJPEG_ENC_S0>, - <&pd IMX_SC_R_MJPEG_ENC_S1>, - <&pd IMX_SC_R_MJPEG_ENC_S2>, - <&pd IMX_SC_R_MJPEG_ENC_S3>; + <&pd IMX_SC_R_MJPEG_ENC_S0>; + slot = <0>; }; ...
There are total 4 slots available in the IP, and we only need to use one slot in one os, assign a single slot, configure interrupt and power domain only for 1 slot, not for the all 4 slots. Signed-off-by: Ming Qian <ming.qian@nxp.com> --- .../bindings/media/nxp,imx8-jpeg.yaml | 40 ++++++++----------- 1 file changed, 16 insertions(+), 24 deletions(-)