| Message ID | 20230925074131.10133-2-ming.qian@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder | expand |
On 25/09/2023 09:41, Ming Qian wrote: > There are total 4 slots available in the IP, > and we only need to use one slot in one os, > assign a single slot, > configure interrupt and power domain only for 1 slot, > not for the all 4 slots. No changelog and I do not see much of improvements. Do not ignore the feedback but respond to it or fix the patch. Really, what happened here? Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Ming Qian <ming.qian@nxp.com> > --- > .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- > 1 file changed, 18 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..df381b21336d 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -32,25 +32,29 @@ properties: > maxItems: 1 > > interrupts: > - description: | > - There are 4 slots available in the IP, which the driver may use > - If a certain slot is used, it should have an associated interrupt > - The interrupt with index i is assumed to be for slot i > - minItems: 1 # At least one slot is needed by the driver > - maxItems: 4 # The IP has 4 slots available for use > + description: > + Interrupt number for slot > + maxItems: 1 > > power-domains: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > - maxItems: 5 # Wrapper and 4 slots > + minItems: 1 # VPUMIX > + maxItems: 2 # Wrapper and 1 slot > + > + nxp,slot: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Integer number of slot index used. > + minimum: 0 > + maximum: 3 Nothing explains what is a slot and nothing explains why do you need this property. > > required: > - compatible > - reg > - interrupts > - power-domains > + - nxp,slot NAK, that's an ABI break. Best regards, Krzysztof
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: 2023年9月25日 16:02 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for >imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 09:41, Ming Qian wrote: >> There are total 4 slots available in the IP, and we only need to use >> one slot in one os, assign a single slot, configure interrupt and >> power domain only for 1 slot, not for the all 4 slots. > >No changelog and I do not see much of improvements. Do not ignore the >feedback but respond to it or fix the patch. Really, what happened here? > Hi Krzysztof, What do you mean wrap commit message? Do you mean line wrapped at 75 columns? - The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch. >Please wrap commit message according to Linux coding style / submission >process (neither too early nor over the limit): >https://elixir.b/ >ootlin.com%2Flinux%2Fv6.4- >rc1%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting- >patches.rst%23L597&data=05%7C01%7Cming.qian%40nxp.com%7C9a78ca292 >a5744790db208dbbd9da8e3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% >7C0%7C638312257061769802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w >LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C% >7C%7C&sdata=gDnMim2nrLIQflmmGu6cahz0prZV9iKslevv208u06U%3D&reser >ved=0 > >> >> Signed-off-by: Ming Qian <ming.qian@nxp.com> >> --- >> .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- >> 1 file changed, 18 insertions(+), 24 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> index 3d9d1db37040..df381b21336d 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> @@ -32,25 +32,29 @@ properties: >> maxItems: 1 >> >> interrupts: >> - description: | >> - There are 4 slots available in the IP, which the driver may use >> - If a certain slot is used, it should have an associated interrupt >> - The interrupt with index i is assumed to be for slot i >> - minItems: 1 # At least one slot is needed by the driver >> - maxItems: 4 # The IP has 4 slots available for use >> + description: >> + Interrupt number for slot >> + maxItems: 1 >> >> power-domains: >> description: >> List of phandle and PM domain specifier as documented in >> Documentation/devicetree/bindings/power/power_domain.txt >> - minItems: 2 # Wrapper and 1 slot >> - maxItems: 5 # Wrapper and 4 slots >> + minItems: 1 # VPUMIX >> + maxItems: 2 # Wrapper and 1 slot >> + >> + nxp,slot: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: Integer number of slot index used. >> + minimum: 0 >> + maximum: 3 > >Nothing explains what is a slot and nothing explains why do you need this >property. > >> >> required: >> - compatible >> - reg >> - interrupts >> - power-domains >> + - nxp,slot > >NAK, that's an ABI break. > >Best regards, >Krzysztof
On 25/09/2023 10:07, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:02 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot for >> imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 09:41, Ming Qian wrote: >>> There are total 4 slots available in the IP, and we only need to use >>> one slot in one os, assign a single slot, configure interrupt and >>> power domain only for 1 slot, not for the all 4 slots. >> >> No changelog and I do not see much of improvements. Do not ignore the >> feedback but respond to it or fix the patch. Really, what happened here? >> > > Hi Krzysztof, > What do you mean wrap commit message? Do you mean line wrapped at 75 columns? > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. I gave you clear link to the doc explaining this. What is unclear there? And you decide to ignore all the rest of the comments here as well? Best regards, Krzysztof
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: 2023年9月25日 16:10 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >for imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 10:07, Ming Qian wrote: >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Sent: 2023年9月25日 16:02 >>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >shawnguo@kernel.org >>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>> Assign slot for imx jpeg encoder/decoder >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 25/09/2023 09:41, Ming Qian wrote: >>>> There are total 4 slots available in the IP, and we only need to use >>>> one slot in one os, assign a single slot, configure interrupt and >>>> power domain only for 1 slot, not for the all 4 slots. >>> >>> No changelog and I do not see much of improvements. Do not ignore the >>> feedback but respond to it or fix the patch. Really, what happened here? >>> >> >> Hi Krzysztof, >> What do you mean wrap commit message? Do you mean line wrapped at >75 columns? >> >> - The body of the explanation, line wrapped at 75 columns, which will >> be copied to the permanent changelog to describe this patch. > >I gave you clear link to the doc explaining this. What is unclear there? > >And you decide to ignore all the rest of the comments here as well? > >Best regards, >Krzysztof The link content is as below: - The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch. I'm sorry that I didn’t get your point.
On 25/09/2023 10:13, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:10 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >> for imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 10:07, Ming Qian wrote: >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: 2023年9月25日 16:02 >>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org >>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>> Assign slot for imx jpeg encoder/decoder >>>> >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>> There are total 4 slots available in the IP, and we only need to use >>>>> one slot in one os, assign a single slot, configure interrupt and >>>>> power domain only for 1 slot, not for the all 4 slots. >>>> >>>> No changelog and I do not see much of improvements. Do not ignore the >>>> feedback but respond to it or fix the patch. Really, what happened here? >>>> >>> >>> Hi Krzysztof, >>> What do you mean wrap commit message? Do you mean line wrapped at >> 75 columns? >>> >>> - The body of the explanation, line wrapped at 75 columns, which will >>> be copied to the permanent changelog to describe this patch. >> >> I gave you clear link to the doc explaining this. What is unclear there? >> >> And you decide to ignore all the rest of the comments here as well? So this is still ignored? Can you respond to all my comments? >> >> Best regards, >> Krzysztof > > The link content is as below: > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. > > I'm sorry that I didn’t get your point. Wrap your commit according to coding style. Best regards, Krzysztof
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: 2023年9月25日 16:14 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >for imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 10:13, Ming Qian wrote: >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Sent: 2023年9月25日 16:10 >>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >shawnguo@kernel.org >>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>> Assign slot for imx jpeg encoder/decoder >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 25/09/2023 10:07, Ming Qian wrote: >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> Sent: 2023年9月25日 16:02 >>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >>> shawnguo@kernel.org >>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; >>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; >>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>>> Assign slot for imx jpeg encoder/decoder >>>>> >>>>> Caution: This is an external email. Please take care when clicking >>>>> links or opening attachments. When in doubt, report the message >>>>> using the 'Report this email' button >>>>> >>>>> >>>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>>> There are total 4 slots available in the IP, and we only need to >>>>>> use one slot in one os, assign a single slot, configure interrupt >>>>>> and power domain only for 1 slot, not for the all 4 slots. >>>>> >>>>> No changelog and I do not see much of improvements. Do not ignore >>>>> the feedback but respond to it or fix the patch. Really, what happened >here? >>>>> >>>> >>>> Hi Krzysztof, >>>> What do you mean wrap commit message? Do you mean line wrapped >at >>> 75 columns? >>>> >>>> - The body of the explanation, line wrapped at 75 columns, which will >>>> be copied to the permanent changelog to describe this patch. >>> >>> I gave you clear link to the doc explaining this. What is unclear there? >>> >>> And you decide to ignore all the rest of the comments here as well? > >So this is still ignored? Can you respond to all my comments? > >>> >>> Best regards, >>> Krzysztof >> >> The link content is as below: >> >> - The body of the explanation, line wrapped at 75 columns, which will >> be copied to the permanent changelog to describe this patch. >> >> I'm sorry that I didn’t get your point. > >Wrap >your >commit >according >to >coding >style. > >Best regards, >Krzysztof Hi Krzysztof, I opened your link about the Linux coding style / submission process, but I only find the following message: - The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch. So I don't know what do you mean the coding style.
On 25/09/2023 10:20, Ming Qian wrote: >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2023年9月25日 16:14 >> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >> for imx jpeg encoder/decoder >> >> Caution: This is an external email. Please take care when clicking links or >> opening attachments. When in doubt, report the message using the 'Report >> this email' button >> >> >> On 25/09/2023 10:13, Ming Qian wrote: >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Sent: 2023年9月25日 16:10 >>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >> shawnguo@kernel.org >>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>> Assign slot for imx jpeg encoder/decoder >>>> >>>> Caution: This is an external email. Please take care when clicking >>>> links or opening attachments. When in doubt, report the message using >>>> the 'Report this email' button >>>> >>>> >>>> On 25/09/2023 10:07, Ming Qian wrote: >>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>> Sent: 2023年9月25日 16:02 >>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >>>> shawnguo@kernel.org >>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; >>>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; >>>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>>>> Assign slot for imx jpeg encoder/decoder >>>>>> >>>>>> Caution: This is an external email. Please take care when clicking >>>>>> links or opening attachments. When in doubt, report the message >>>>>> using the 'Report this email' button >>>>>> >>>>>> >>>>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>>>> There are total 4 slots available in the IP, and we only need to >>>>>>> use one slot in one os, assign a single slot, configure interrupt >>>>>>> and power domain only for 1 slot, not for the all 4 slots. >>>>>> >>>>>> No changelog and I do not see much of improvements. Do not ignore >>>>>> the feedback but respond to it or fix the patch. Really, what happened >> here? >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> What do you mean wrap commit message? Do you mean line wrapped >> at >>>> 75 columns? >>>>> >>>>> - The body of the explanation, line wrapped at 75 columns, which will >>>>> be copied to the permanent changelog to describe this patch. >>>> >>>> I gave you clear link to the doc explaining this. What is unclear there? >>>> >>>> And you decide to ignore all the rest of the comments here as well? >> >> So this is still ignored? Can you respond to all my comments? >> >>>> >>>> Best regards, >>>> Krzysztof >>> >>> The link content is as below: >>> >>> - The body of the explanation, line wrapped at 75 columns, which will >>> be copied to the permanent changelog to describe this patch. >>> >>> I'm sorry that I didn’t get your point. >> >> Wrap >> your >> commit >> according >> to >> coding >> style. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > I opened your link about the Linux coding style / submission process, but I only find the following message: > > - The body of the explanation, line wrapped at 75 columns, which will > be copied to the permanent changelog to describe this patch. > > So I don't know what do you mean the coding style. Linked document explains what is a patch, how it is formatted. Just read entire doc, not one sentence. You keep ignoring my other comments all the time, so I will stop asking you to respond to them. Instead I will be NAK-ing your patches till you decide to respond. Best regards, Krzysztof
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >Sent: 2023年9月25日 16:33 >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot >for imx jpeg encoder/decoder > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >On 25/09/2023 10:20, Ming Qian wrote: >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Sent: 2023年9月25日 16:14 >>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >shawnguo@kernel.org >>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; >>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao >>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang >>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>> Assign slot for imx jpeg encoder/decoder >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 25/09/2023 10:13, Ming Qian wrote: >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> Sent: 2023年9月25日 16:10 >>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >>> shawnguo@kernel.org >>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; >>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; >>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; >>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- >>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>>> Assign slot for imx jpeg encoder/decoder >>>>> >>>>> Caution: This is an external email. Please take care when clicking >>>>> links or opening attachments. When in doubt, report the message >>>>> using the 'Report this email' button >>>>> >>>>> >>>>> On 25/09/2023 10:07, Ming Qian wrote: >>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>>> Sent: 2023年9月25日 16:02 >>>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) >>>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; >>>>> shawnguo@kernel.org >>>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >>>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >>>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; >>>>>>> festevam@gmail.com; X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou >>>>>>> <eagle.zhou@nxp.com>; Tao Jiang <tao.jiang_2@nxp.com>; >>>>>>> dl-linux-imx <linux-imx@nxp.com>; devicetree@vger.kernel.org; >>>>>>> linux-media@vger.kernel.org; linux- kernel@vger.kernel.org; >>>>>>> linux-arm-kernel@lists.infradead.org >>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: >>>>>>> Assign slot for imx jpeg encoder/decoder >>>>>>> >>>>>>> Caution: This is an external email. Please take care when >>>>>>> clicking links or opening attachments. When in doubt, report the >>>>>>> message using the 'Report this email' button >>>>>>> >>>>>>> >>>>>>> On 25/09/2023 09:41, Ming Qian wrote: >>>>>>>> There are total 4 slots available in the IP, and we only need to >>>>>>>> use one slot in one os, assign a single slot, configure >>>>>>>> interrupt and power domain only for 1 slot, not for the all 4 slots. >>>>>>> >>>>>>> No changelog and I do not see much of improvements. Do not ignore >>>>>>> the feedback but respond to it or fix the patch. Really, what >>>>>>> happened >>> here? >>>>>>> >>>>>> >>>>>> Hi Krzysztof, >>>>>> What do you mean wrap commit message? Do you mean line >wrapped >>> at >>>>> 75 columns? >>>>>> >>>>>> - The body of the explanation, line wrapped at 75 columns, which will >>>>>> be copied to the permanent changelog to describe this patch. >>>>> >>>>> I gave you clear link to the doc explaining this. What is unclear there? >>>>> >>>>> And you decide to ignore all the rest of the comments here as well? >>> >>> So this is still ignored? Can you respond to all my comments? >>> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> The link content is as below: >>>> >>>> - The body of the explanation, line wrapped at 75 columns, which will >>>> be copied to the permanent changelog to describe this patch. >>>> >>>> I'm sorry that I didn’t get your point. >>> >>> Wrap >>> your >>> commit >>> according >>> to >>> coding >>> style. >>> >>> Best regards, >>> Krzysztof >> >> Hi Krzysztof, >> I opened your link about the Linux coding style / submission process, but I >only find the following message: >> >> - The body of the explanation, line wrapped at 75 columns, which will >> be copied to the permanent changelog to describe this patch. >> >> So I don't know what do you mean the coding style. > > >Linked document explains what is a patch, how it is formatted. Just read >entire doc, not one sentence. > >You keep ignoring my other comments all the time, so I will stop asking you to >respond to them. Instead I will be NAK-ing your patches till you decide to >respond. > >Best regards, >Krzysztof Hi Krzysztof, I'm sorry that I make you unhappy, as I didn't know how to improve the commit message. And your other comments about the change, I get your point, and prepare to improve in the next version. Sorry again that I didn't response your every comments, I will avoid doing it again. And can you give a example how to improve the commit message. Ming
On 25/09/2023 10:48, Ming Qian wrote: > > Sorry again that I didn't response your every comments, I will avoid doing it again. > > And can you give a example how to improve the commit message. In vim: gq<ENTER>gq<ENTER>gq<ENTER> and so on, till you are happy. Best regards, Krzysztof
On Mon, Sep 25, 2023 at 08:48:01AM +0000, Ming Qian wrote: > >From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >Sent: 2023年9月25日 16:33 > >To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > ><mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; shawnguo@kernel.org > >Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; > >kernel@pengutronix.de; festevam@gmail.com; X.H. Bao > ><xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang > ><tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot > >for imx jpeg encoder/decoder > > > >Caution: This is an external email. Please take care when clicking links or > >opening attachments. When in doubt, report the message using the 'Report > >this email' button > > > > > >On 25/09/2023 10:20, Ming Qian wrote: > >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> Sent: 2023年9月25日 16:14 > >>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >shawnguo@kernel.org > >>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; s.hauer@pengutronix.de; > >>> kernel@pengutronix.de; festevam@gmail.com; X.H. Bao > >>> <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Tao Jiang > >>> <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>> Assign slot for imx jpeg encoder/decoder > >>> > >>> Caution: This is an external email. Please take care when clicking > >>> links or opening attachments. When in doubt, report the message using > >>> the 'Report this email' button > >>> > >>> > >>> On 25/09/2023 10:13, Ming Qian wrote: > >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>>> Sent: 2023年9月25日 16:10 > >>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >>> shawnguo@kernel.org > >>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; > >>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > >>>>> X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; > >>>>> Tao Jiang <tao.jiang_2@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > >>>>> devicetree@vger.kernel.org; linux-media@vger.kernel.org; linux- > >>>>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>> Assign slot for imx jpeg encoder/decoder > >>>>> > >>>>> Caution: This is an external email. Please take care when clicking > >>>>> links or opening attachments. When in doubt, report the message > >>>>> using the 'Report this email' button > >>>>> > >>>>> > >>>>> On 25/09/2023 10:07, Ming Qian wrote: > >>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>>>>>> Sent: 2023年9月25日 16:02 > >>>>>>> To: Ming Qian <ming.qian@nxp.com>; Mirela Rabulea (OSS) > >>>>>>> <mirela.rabulea@oss.nxp.com>; robh+dt@kernel.org; > >>>>> shawnguo@kernel.org > >>>>>>> Cc: krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > >>>>>>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; > >>>>>>> s.hauer@pengutronix.de; kernel@pengutronix.de; > >>>>>>> festevam@gmail.com; X.H. Bao <xiahong.bao@nxp.com>; Eagle Zhou > >>>>>>> <eagle.zhou@nxp.com>; Tao Jiang <tao.jiang_2@nxp.com>; > >>>>>>> dl-linux-imx <linux-imx@nxp.com>; devicetree@vger.kernel.org; > >>>>>>> linux-media@vger.kernel.org; linux- kernel@vger.kernel.org; > >>>>>>> linux-arm-kernel@lists.infradead.org > >>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>>>> Assign slot for imx jpeg encoder/decoder > >>>>>>> > >>>>>>> Caution: This is an external email. Please take care when > >>>>>>> clicking links or opening attachments. When in doubt, report the > >>>>>>> message using the 'Report this email' button > >>>>>>> > >>>>>>> > >>>>>>> On 25/09/2023 09:41, Ming Qian wrote: > >>>>>>>> There are total 4 slots available in the IP, and we only need to > >>>>>>>> use one slot in one os, assign a single slot, configure > >>>>>>>> interrupt and power domain only for 1 slot, not for the all 4 slots. > >>>>>>> > >>>>>>> No changelog and I do not see much of improvements. Do not ignore > >>>>>>> the feedback but respond to it or fix the patch. Really, what > >>>>>>> happened > >>> here? > >>>>>>> > >>>>>> > >>>>>> Hi Krzysztof, > >>>>>> What do you mean wrap commit message? Do you mean line > >wrapped > >>> at > >>>>> 75 columns? > >>>>>> > >>>>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>>>> be copied to the permanent changelog to describe this patch. > >>>>> > >>>>> I gave you clear link to the doc explaining this. What is unclear there? > >>>>> > >>>>> And you decide to ignore all the rest of the comments here as well? > >>> > >>> So this is still ignored? Can you respond to all my comments? > >>> > >>>>> > >>>>> Best regards, > >>>>> Krzysztof > >>>> > >>>> The link content is as below: > >>>> > >>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>> be copied to the permanent changelog to describe this patch. > >>>> > >>>> I'm sorry that I didn’t get your point. > >>> > >>> Wrap > >>> your > >>> commit > >>> according > >>> to > >>> coding > >>> style. > >>> > >>> Best regards, > >>> Krzysztof > >> > >> Hi Krzysztof, > >> I opened your link about the Linux coding style / submission process, but I > >only find the following message: > >> > >> - The body of the explanation, line wrapped at 75 columns, which will > >> be copied to the permanent changelog to describe this patch. > >> > >> So I don't know what do you mean the coding style. > > > > > >Linked document explains what is a patch, how it is formatted. Just read > >entire doc, not one sentence. > > > >You keep ignoring my other comments all the time, so I will stop asking you to > >respond to them. Instead I will be NAK-ing your patches till you decide to > >respond. > > > >Best regards, > >Krzysztof > > Hi Krzysztof, > I'm sorry that I make you unhappy, as I didn't know how to improve the commit message. > And your other comments about the change, I get your point, and prepare to improve in the next version. > > Sorry again that I didn't response your every comments, I will avoid doing it again. > > And can you give a example how to improve the commit message. 'git log' There are 10K+ examples every 2 months. Please talk to your NXP colleagues experienced with upsteam about how to write and submit patches upstream, and explain what Krzysztof has said if it is not clear. Rob
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index 3d9d1db37040..df381b21336d 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml @@ -32,25 +32,29 @@ properties: maxItems: 1 interrupts: - description: | - There are 4 slots available in the IP, which the driver may use - If a certain slot is used, it should have an associated interrupt - The interrupt with index i is assumed to be for slot i - minItems: 1 # At least one slot is needed by the driver - maxItems: 4 # The IP has 4 slots available for use + description: + Interrupt number for slot + maxItems: 1 power-domains: description: List of phandle and PM domain specifier as documented in Documentation/devicetree/bindings/power/power_domain.txt - minItems: 2 # Wrapper and 1 slot - maxItems: 5 # Wrapper and 4 slots + minItems: 1 # VPUMIX + maxItems: 2 # Wrapper and 1 slot + + nxp,slot: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Integer number of slot index used. + minimum: 0 + maximum: 3 required: - compatible - reg - interrupts - power-domains + - nxp,slot additionalProperties: false @@ -62,28 +66,18 @@ examples: jpegdec: jpegdec@58400000 { compatible = "nxp,imx8qxp-jpgdec"; reg = <0x58400000 0x00050000 >; - interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>; power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, - <&pd IMX_SC_R_MJPEG_DEC_S0>, - <&pd IMX_SC_R_MJPEG_DEC_S1>, - <&pd IMX_SC_R_MJPEG_DEC_S2>, - <&pd IMX_SC_R_MJPEG_DEC_S3>; + <&pd IMX_SC_R_MJPEG_DEC_S0>; + nxp,slot = <0>; }; jpegenc: jpegenc@58450000 { compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; reg = <0x58450000 0x00050000 >; - interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>, - <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>; power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, - <&pd IMX_SC_R_MJPEG_ENC_S0>, - <&pd IMX_SC_R_MJPEG_ENC_S1>, - <&pd IMX_SC_R_MJPEG_ENC_S2>, - <&pd IMX_SC_R_MJPEG_ENC_S3>; + <&pd IMX_SC_R_MJPEG_ENC_S0>; + nxp,slot = <0>; }; ...
There are total 4 slots available in the IP, and we only need to use one slot in one os, assign a single slot, configure interrupt and power domain only for 1 slot, not for the all 4 slots. Signed-off-by: Ming Qian <ming.qian@nxp.com> --- .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- 1 file changed, 18 insertions(+), 24 deletions(-)