diff mbox series

media: dt-bindings: hynix,hi846: Document orientation and rotation

Message ID 20230927181600.272904-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series media: dt-bindings: hynix,hi846: Document orientation and rotation | expand

Commit Message

Fabio Estevam Sept. 27, 2023, 6:16 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Document the 'orientation' and 'rotation' properties, which
are valid for the SK Hynix Hi-846 sensor.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Sept. 28, 2023, 6:23 a.m. UTC | #1 
On 27/09/2023 20:16, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Document the 'orientation' and 'rotation' properties, which
> are valid for the SK Hynix Hi-846 sensor.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Martin Kepplinger-Novakovic Sept. 28, 2023, 9:20 a.m. UTC | #2 
Am Mittwoch, dem 27.09.2023 um 15:16 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
> 
> Document the 'orientation' and 'rotation' properties, which
> are valid for the SK Hynix Hi-846 sensor.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4
> ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 1e2df8cf2937..ab0ff6f60fc0 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -48,6 +48,10 @@ properties:
>    vddd-supply:
>      description: Definition of the regulator used for the VDDD power
> supply.
>  
> +  orientation: true
> +
> +  rotation: true
> +
>    port:
>      $ref: /schemas/graph.yaml#/$defs/port-base
>      unevaluatedProperties: false

hi Fabio,

thanks a lot, I like to have this fixed. I always thought we could re-
use media/video-interface-devices.yaml for these properties somehow...

if your change is preferred,

Acked-by: Martin Kepplinger <martink@posteo.de>

                         martin
Fabio Estevam Sept. 28, 2023, 12:13 p.m. UTC | #3 
Hi Martin,

On 28/09/2023 06:20, Martin Kepplinger wrote:
     unevaluatedProperties: false
> 
> hi Fabio,
> 
> thanks a lot, I like to have this fixed. I always thought we could re-
> use media/video-interface-devices.yaml for these properties somehow...
> 
> if your change is preferred,
> 
> Acked-by: Martin Kepplinger <martink@posteo.de>


Good point on video-interface-devices.yaml.

Indeed, we should pass a reference to it.

Otherwise, after this patch, hynix,hi846.yaml will only check for the 
presence of
orientation/rotation properties and not check whether the values are 
valid.

I will submit a v2 that adds the aditional ref to 
video-interface-devices.yaml

Thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 1e2df8cf2937..ab0ff6f60fc0 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -48,6 +48,10 @@  properties:
   vddd-supply:
     description: Definition of the regulator used for the VDDD power supply.
 
+  orientation: true
+
+  rotation: true
+
   port:
     $ref: /schemas/graph.yaml#/$defs/port-base
     unevaluatedProperties: false