| Message ID | 20230930145951.23433-2-jacopo.mondi@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: bindings: Fix handling of video-interface-device | expand |
On Sat, 30 Sep 2023 16:59:45 +0200, Jacopo Mondi wrote: > Allow properties from video-interface-device.yaml for the SK Hynix Hi-846 > sensor. > > All properties specified in video-interface-device.yaml schema are > valid, so make them accepted by changing "additionalProperties: false" > to "unevaluatedProperties: false" at the schema top-level. > > Add two properties from video-interface-device.yaml to the example > to validate the new schema. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > .../devicetree/bindings/media/i2c/hynix,hi846.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Jacopo, On Sat, Sep 30, 2023 at 04:59:45PM +0200, Jacopo Mondi wrote: > Allow properties from video-interface-device.yaml for the SK Hynix Hi-846 > sensor. > > All properties specified in video-interface-device.yaml schema are > valid, so make them accepted by changing "additionalProperties: false" > to "unevaluatedProperties: false" at the schema top-level. The patch seems fine to me, but I wonder if we should change the title of video-interface-devices.yaml (it's plural) to something that refers to camera sensors, and possibly split it. It's currently not relevant for other types of devices.
On Tue, Oct 03, 2023 at 08:27:30AM +0000, Sakari Ailus wrote: > Hi Jacopo, > > On Sat, Sep 30, 2023 at 04:59:45PM +0200, Jacopo Mondi wrote: > > Allow properties from video-interface-device.yaml for the SK Hynix Hi-846 > > sensor. > > > > All properties specified in video-interface-device.yaml schema are > > valid, so make them accepted by changing "additionalProperties: false" > > to "unevaluatedProperties: false" at the schema top-level. > > The patch seems fine to me, but I wonder if we should change the title of > video-interface-devices.yaml (it's plural) to something that refers to > camera sensors, and possibly split it. It's currently not relevant for > other types of devices. I was thinking exactly the same yesterday.
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml index 1e2df8cf2937..60f19e1152b3 100644 --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml @@ -14,6 +14,9 @@ description: |- interface and CCI (I2C compatible) control bus. The output format is raw Bayer. +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + properties: compatible: const: hynix,hi846 @@ -86,7 +89,7 @@ required: - vddd-supply - port -additionalProperties: false +unevaluatedProperties: false examples: - | @@ -109,6 +112,8 @@ examples: vddio-supply = <®_camera_vddio>; reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; shutdown-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>; + orientation = <0>; + rotation = <0>; port { camera_out: endpoint {
Allow properties from video-interface-device.yaml for the SK Hynix Hi-846 sensor. All properties specified in video-interface-device.yaml schema are valid, so make them accepted by changing "additionalProperties: false" to "unevaluatedProperties: false" at the schema top-level. Add two properties from video-interface-device.yaml to the example to validate the new schema. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- .../devicetree/bindings/media/i2c/hynix,hi846.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)