diff mbox series

[v3,7/7] media: dt-bindings: sony,imx415: Fix handling of video-interface-device

Message ID 20230930145951.23433-8-jacopo.mondi@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series media: bindings: Fix handling of video-interface-device | expand

Commit Message

Jacopo Mondi Sept. 30, 2023, 2:59 p.m. UTC
Fix handling of properties from video-interface-device.yaml for
Sony IMX415.

All the properties described by video-interface-device.yaml are
allowed for the image sensor, make them accepted by changing
"additionalProperties: false" to "unevaluatedProperties: false" at the
schema top-level.

Because all properties are now accepted, there is no need to explicitly
allow them in the schema.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 .../devicetree/bindings/media/i2c/sony,imx415.yaml     | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

--
2.42.0

Comments

Rob Herring (Arm) Oct. 2, 2023, 7:07 p.m. UTC | #1
On Sat, Sep 30, 2023 at 04:59:51PM +0200, Jacopo Mondi wrote:
> Fix handling of properties from video-interface-device.yaml for
> Sony IMX415.

It wasn't really broken to be a fix. In any case,

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> All the properties described by video-interface-device.yaml are
> allowed for the image sensor, make them accepted by changing
> "additionalProperties: false" to "unevaluatedProperties: false" at the
> schema top-level.
> 
> Because all properties are now accepted, there is no need to explicitly
> allow them in the schema.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx415.yaml     | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> index ffccf5f3c9e3..8ea3ddd251f6 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> @@ -44,14 +44,6 @@ properties:
>      description: Sensor reset (XCLR) GPIO
>      maxItems: 1
> 
> -  flash-leds: true
> -
> -  lens-focus: true
> -
> -  orientation: true
> -
> -  rotation: true
> -
>    port:
>      $ref: /schemas/graph.yaml#/$defs/port-base
> 
> @@ -88,7 +80,7 @@ required:
>    - ovdd-supply
>    - port
> 
> -additionalProperties: false
> +unevaluatedProperties: false
> 
>  examples:
>    - |
> --
> 2.42.0
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
index ffccf5f3c9e3..8ea3ddd251f6 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
@@ -44,14 +44,6 @@  properties:
     description: Sensor reset (XCLR) GPIO
     maxItems: 1

-  flash-leds: true
-
-  lens-focus: true
-
-  orientation: true
-
-  rotation: true
-
   port:
     $ref: /schemas/graph.yaml#/$defs/port-base

@@ -88,7 +80,7 @@  required:
   - ovdd-supply
   - port

-additionalProperties: false
+unevaluatedProperties: false

 examples:
   - |