| Message ID | 20231208195253.130470-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] media: dt-bindings: ov8856: decouple lanes and link frequency from driver | expand |
On Fri, 08 Dec 2023 20:52:53 +0100, Krzysztof Kozlowski wrote: > The data lanes and link frequency were set to match existing Linux driver > limitations, however bindings should be independent of chosen Linux > driver support. > > Decouple these properties from the driver to match what is actually > supported by the hardware. > > This also fixes DTS example: > > ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short > > Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > Changes in v3: > 1. Drop link-frequencies entirely (Sakari) > 2. Add Conor's ack > > Changes in v2: > 1. Rework approach: decouple bindings from driver instead of fixing > DTS example (Sakari) > --- > .../devicetree/bindings/media/i2c/ov8856.yaml | 24 +++++++++---------- > 1 file changed, 11 insertions(+), 13 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml index 57f5e48fd8e0..816dac9c6f60 100644 --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml @@ -67,19 +67,17 @@ properties: properties: data-lanes: - description: |- - The driver only supports four-lane operation. - items: - - const: 1 - - const: 2 - - const: 3 - - const: 4 - - link-frequencies: - description: Frequencies listed are driver, not h/w limitations. - maxItems: 2 - items: - enum: [ 360000000, 180000000 ] + oneOf: + - items: + - const: 1 + - items: + - const: 1 + - const: 2 + - items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 required: - link-frequencies
The data lanes and link frequency were set to match existing Linux driver limitations, however bindings should be independent of chosen Linux driver support. Decouple these properties from the driver to match what is actually supported by the hardware. This also fixes DTS example: ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas") Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v3: 1. Drop link-frequencies entirely (Sakari) 2. Add Conor's ack Changes in v2: 1. Rework approach: decouple bindings from driver instead of fixing DTS example (Sakari) --- .../devicetree/bindings/media/i2c/ov8856.yaml | 24 +++++++++---------- 1 file changed, 11 insertions(+), 13 deletions(-)