| Message ID | 20240204210642.693958-1-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] media: dt-bindings: Revert changes to video-interfaces.yaml | expand |
On 04/02/2024 22:06, Sakari Ailus wrote: > Commit feb8831be9d4 ("media: ov08x40: Reduce start streaming time") > introduced an unintentional change to > Documentation/devicetree/bindings/media/video-interfaces.yaml. Revert this > change now. > > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Fixes: feb8831be9d4 ("media: ov08x40: Reduce start streaming time") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Even if it is simple, it still should be tested... Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Best regards, Krzysztof
Hi Krzysztof, On Mon, Feb 05, 2024 at 09:35:02AM +0100, Krzysztof Kozlowski wrote: > On 04/02/2024 22:06, Sakari Ailus wrote: > > Commit feb8831be9d4 ("media: ov08x40: Reduce start streaming time") > > introduced an unintentional change to > > Documentation/devicetree/bindings/media/video-interfaces.yaml. Revert this > > change now. > > > > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Fixes: feb8831be9d4 ("media: ov08x40: Reduce start streaming time") > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Even if it is simple, it still should be tested... > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. We decided to revert the original patch in its entirety. Note that merging this (or the full revert of the original patch) reverts the changes that were previously merged unintentionally. Not doing so will break video-interfaces.yaml and omap3-n9.dts. I didn't cc the devicetree list or DT maintainers as I viewed addressing this problem internal to the media tree.
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml index ea511f2fed98..26e3e7d7c67b 100644 --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml @@ -190,7 +190,7 @@ properties: Allow MIPI CSI-2 non-continuous clock mode. link-frequencies: - $ref: /schemas/types.yaml#/definitions/uint32-array + $ref: /schemas/types.yaml#/definitions/uint64-array description: Allowed data bus frequencies. For MIPI CSI-2, for instance, this is the actual frequency of the bus, not bits per clock per lane value. An array
Commit feb8831be9d4 ("media: ov08x40: Reduce start streaming time") introduced an unintentional change to Documentation/devicetree/bindings/media/video-interfaces.yaml. Revert this change now. Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Fixes: feb8831be9d4 ("media: ov08x40: Reduce start streaming time") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- Documentation/devicetree/bindings/media/video-interfaces.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)