From patchwork Mon Apr 29 19:08:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 13647551 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBE0313AD1A for ; Mon, 29 Apr 2024 19:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714417740; cv=none; b=nATwkFDHr9sxN3WpXJIvExI6fnVSG3zfg4O3kS+UVv/CP8ApcJyObiT4u0qVbEI8GGofW+HHg6J7fcvDuI60PMtie7E5cgYdy4z0+C8Aodqne6Btsd08XTqVcg5iObmKyElyaJ3k3JP6O1XsLSWWC1WufD2ryIFqz+pSI1mBJkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714417740; c=relaxed/simple; bh=ZpKRy1M2fNG2ERRyUF8FAQ0dw+Nbc41Phkw+ptejPro=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cB3JGytbdwPOLaCmtjKN3s1rTfLilqfOxFpt9Zq82gtwgNAOcxRu8Sqof7tpYeuOcqk/FzE7km1RupeeySq6riCmIjgCfLjbA7MERVUkGNFIAFm6clyfKhroRZ+YYD9fI5gdeu4qfSHhW598KUOmXH//nww7jLX/kBdlhgwOkFs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nEgProYQ; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nEgProYQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714417739; x=1745953739; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZpKRy1M2fNG2ERRyUF8FAQ0dw+Nbc41Phkw+ptejPro=; b=nEgProYQCiZ4Jqi6kxZ+f1R1DGL5Oo+nP8DTo9UfFgYbGFzaaVT9YADt tgJqgErBfPco5O+5SzxvEDDZ2uqSG9JDhVB/P0eR70t7S0aPwfpKY2f9Z JrmfIHYtaFsbKbkW3Q7LIfh11nxyIDmigf6RI9g7UsCSmhbWAIcUfhDKq to19si5R8hHpniMdB/cuMg3EejRrU5RGp58QqOMeqMe//K9vnLvzGZKLC AMJRU/eq0e8lOjJg9FbPN8SwPkXJBoPNlx6+iVoQEFVA0iARBu7v3XJov gkxN+GjdMKil9Qmgd9AFTWfd/Hyf2sF9+h9DACsrHcemM9YezlRyblbiI A==; X-CSE-ConnectionGUID: doDNfMvnT9erUGHjLtCzdg== X-CSE-MsgGUID: WZC42e2lS8+N0NBKsn+HsQ== X-IronPort-AV: E=McAfee;i="6600,9927,11059"; a="13875326" X-IronPort-AV: E=Sophos;i="6.07,240,1708416000"; d="scan'208";a="13875326" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 12:08:57 -0700 X-CSE-ConnectionGUID: IJyyQ6UeSeWRZzS/LInxzA== X-CSE-MsgGUID: dsaHR94hT1WmFOI/LaawRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,240,1708416000"; d="scan'208";a="30846310" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 12:08:56 -0700 Received: from svinhufvud.ger.corp.intel.com (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 5FBB011FA8A; Mon, 29 Apr 2024 22:08:53 +0300 (EEST) From: Sakari Ailus To: linux-media@vger.kernel.org Cc: hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, Wentong Wu Subject: [PATCH v4 1/4] media: v4l: Support passing sub-device argument to v4l2_get_link_freq() Date: Mon, 29 Apr 2024 22:08:49 +0300 Message-Id: <20240429190852.1008003-2-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240429190852.1008003-1-sakari.ailus@linux.intel.com> References: <20240429190852.1008003-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 v4l2_get_link_freq() accepts a V4L2 control handler for now, but it needs to take struct v4l2_subdev argument in order to obtain the link frequency using get_mbus_config() pad op. Prepare for this by allowing struct v4l2_subdev as well. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-common.c | 19 ++++++++++++++++--- include/media/v4l2-common.h | 14 +++++++++++--- 2 files changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c index 4165c815faef..7f69b5a025fa 100644 --- a/drivers/media/v4l2-core/v4l2-common.c +++ b/drivers/media/v4l2-core/v4l2-common.c @@ -464,8 +464,8 @@ int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat, } EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt); -s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, - unsigned int div) +s64 __v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler, + unsigned int mul, unsigned int div) { struct v4l2_ctrl *ctrl; s64 freq; @@ -500,7 +500,20 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, return freq > 0 ? freq : -EINVAL; } -EXPORT_SYMBOL_GPL(v4l2_get_link_freq); +EXPORT_SYMBOL_GPL(__v4l2_get_link_freq_ctrl); + +s64 __v4l2_get_link_freq_pad(struct media_pad *pad, unsigned int mul, + unsigned int div) +{ + struct v4l2_subdev *sd; + + sd = media_entity_to_v4l2_subdev(pad->entity); + if (!sd) + return -ENODEV; + + return __v4l2_get_link_freq_ctrl(sd->ctrl_handler, mul, div); +} +EXPORT_SYMBOL_GPL(__v4l2_get_link_freq_pad); /* * Simplify a fraction using a simple continued fraction decomposition. The diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h index 63ad36f04f72..d7115cd61a38 100644 --- a/include/media/v4l2-common.h +++ b/include/media/v4l2-common.h @@ -525,7 +525,8 @@ int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat, /** * v4l2_get_link_freq - Get link rate from transmitter * - * @handler: The transmitter's control handler + * @pad: The transmitter's media pad (or control handler for compatibility + * reasons, don't use in new code) * @mul: The multiplier between pixel rate and link frequency. Bits per pixel on * D-PHY, samples per clock on parallel. 0 otherwise. * @div: The divisor between pixel rate and link frequency. Number of data lanes @@ -541,8 +542,15 @@ int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat, * * %-ENOENT: Link frequency or pixel rate control not found * * %-EINVAL: Invalid link frequency value */ -s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul, - unsigned int div); +#define v4l2_get_link_freq(pad, mul, div) \ + _Generic(pad, \ + struct media_pad *: __v4l2_get_link_freq_pad, \ + struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl) \ + (pad, mul, div) +s64 __v4l2_get_link_freq_pad(struct media_pad *pad, unsigned int mul, + unsigned int div); +s64 __v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler, + unsigned int mul, unsigned int div); void v4l2_simplify_fraction(u32 *numerator, u32 *denominator, unsigned int n_terms, unsigned int threshold);