[v10,6/8] media: dt-bindings: Add bindings for Raspberry Pi PiSP Back End

Commit Message

Jacopo Mondi June 26, 2024, 4:01 p.m. UTC

Add bindings for the Raspberry Pi PiSP Back End memory-to-memory image
signal processor.

Datasheet:
https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf

Signed-off-by: Jacopo Mondi <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>
Reviewed-by: Naushir Patuck <[e-mail]>
---
 .../bindings/media/raspberrypi,pispbe.yaml    | 63 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 2 files changed, 64 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml

Comments

Rob Herring (Arm) June 26, 2024, 5:49 p.m. UTC | #1

On Wed, Jun 26, 2024 at 10:02 AM Jacopo Mondi
<[e-mail]> wrote:
>
> Add bindings for the Raspberry Pi PiSP Back End memory-to-memory image
> signal processor.
>
> Datasheet:
> https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf
>
> Signed-off-by: Jacopo Mondi <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>

Sigh. Use get_maintainers.pl and send to the right lists/people so
that automated tests run.

I know I didn't review this without that happening.

Rob

Jacopo Mondi June 26, 2024, 5:56 p.m. UTC | #2

Hi Rob

On Wed, Jun 26, 2024 at 11:49:59AM GMT, Rob Herring wrote:
> On Wed, Jun 26, 2024 at 10:02 AM Jacopo Mondi
> <[e-mail]> wrote:
> >
> > Add bindings for the Raspberry Pi PiSP Back End memory-to-memory image
> > signal processor.
> >
> > Datasheet:
> > https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf
> >
> > Signed-off-by: Jacopo Mondi <[e-mail]>
> > Reviewed-by: Rob Herring <[e-mail]>
>
> Sigh. Use get_maintainers.pl and send to the right lists/people so
> that automated tests run.

Ah ups sorry, I dropped the dt list after this had been reviewed a
long time ago. I'll add it back

>
> I know I didn't review this without that happening.
>
> Rob

Krzysztof Kozlowski June 27, 2024, 6:53 a.m. UTC | #3

On 26/06/2024 19:56, Jacopo Mondi wrote:
> Hi Rob
> 
> On Wed, Jun 26, 2024 at 11:49:59AM GMT, Rob Herring wrote:
>> On Wed, Jun 26, 2024 at 10:02 AM Jacopo Mondi
>> <[e-mail]> wrote:
>>>
>>> Add bindings for the Raspberry Pi PiSP Back End memory-to-memory image
>>> signal processor.
>>>
>>> Datasheet:
>>> https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf
>>>
>>> Signed-off-by: Jacopo Mondi <[e-mail]>
>>> Reviewed-by: Rob Herring <[e-mail]>
>>
>> Sigh. Use get_maintainers.pl and send to the right lists/people so
>> that automated tests run.
> 
> Ah ups sorry, I dropped the dt list after this had been reviewed a
> long time ago. I'll add it back

You already received exactly the same feedback for other patchset.

No, you must CC all lists for automation to work.

Best regards,
Krzysztof

Krzysztof Kozlowski June 27, 2024, 6:54 a.m. UTC | #4

On 26/06/2024 18:01, Jacopo Mondi wrote:
> Add bindings for the Raspberry Pi PiSP Back End memory-to-memory image
> signal processor.
> 
> Datasheet:
> https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf
> 
> Signed-off-by: Jacopo Mondi <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> Reviewed-by: Naushir Patuck <[e-mail]>
> ---

Since there will be a resend (this was not test):

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml b/Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml
new file mode 100644
index 000000000000..1fc62a1d8eda
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml
@@ -0,0 +1,63 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/raspberrypi,pispbe.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Raspberry Pi PiSP Image Signal Processor (ISP) Back End
+
+maintainers:
+  - Raspberry Pi Kernel Maintenance <[e-mail]>
+  - Jacopo Mondi <[e-mail]>
+
+description: |
+  The Raspberry Pi PiSP Image Signal Processor (ISP) Back End is an image
+  processor that fetches images in Bayer or Grayscale format from DRAM memory
+  in tiles and produces images consumable by applications.
+
+  The full ISP documentation is available at
+  https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - brcm,bcm2712-pispbe
+      - const: raspberrypi,pispbe
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  iommus:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        isp@880000  {
+             compatible = "brcm,bcm2712-pispbe", "raspberrypi,pispbe";
+             reg = <0x10 0x00880000 0x0 0x4000>;
+             interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
+             clocks = <&firmware_clocks 7>;
+             iommus = <&iommu2>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 861ee24cc1f7..4f8126990da2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18810,6 +18810,7 @@  M:	Jacopo Mondi <[e-mail]>
 L:	Raspberry Pi Kernel Maintenance <[e-mail]>
 L:	[e-mail]
 S:	Maintained
+F:	Documentation/devicetree/bindings/media/raspberrypi,pispbe.yaml
 F:	include/uapi/linux/media/raspberrypi/
 
 RC-CORE / LIRC FRAMEWORK