| Message ID | 20240920073503.22536-3-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Update streaming related documentation | expand |
Hi Sakari, Thank you for the patch. On Fri, Sep 20, 2024 at 10:35:02AM +0300, Sakari Ailus wrote: > Document the expected {enable,disable}_streams callback behaviour for > drivers that are stream-unaware i.e. don't specify the > V4L2_SUBDEV_CAP_STREAMS sub-device capability flat. In this specific case, s/flat/flag/ > the mask argument can be ignored. > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > include/media/v4l2-subdev.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index 3cc6b4a5935f..ff63fb6046b1 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -834,11 +834,19 @@ struct v4l2_subdev_state { > * v4l2_subdev_init_finalize() at initialization time). Do not call > * directly, use v4l2_subdev_enable_streams() instead. > * > + * Drivers that support only a single stream without setting the > + * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask > + * argument. > + * > * @disable_streams: Disable the streams defined in streams_mask on the given > * source pad. Subdevs that implement this operation must use the active > * state management provided by the subdev core (enabled through a call to > * v4l2_subdev_init_finalize() at initialization time). Do not call > * directly, use v4l2_subdev_disable_streams() instead. > + * > + * Drivers that support only a single stream without setting the > + * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask > + * argument. > */ > struct v4l2_subdev_pad_ops { > int (*enum_mbus_code)(struct v4l2_subdev *sd,
Hi Laurent, On Thu, Sep 26, 2024 at 12:46:54AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Sep 20, 2024 at 10:35:02AM +0300, Sakari Ailus wrote: > > Document the expected {enable,disable}_streams callback behaviour for > > drivers that are stream-unaware i.e. don't specify the > > V4L2_SUBDEV_CAP_STREAMS sub-device capability flat. In this specific case, > > s/flat/flag/ > > > the mask argument can be ignored. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks! I'll fix the commit message while applying the patch.
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index 3cc6b4a5935f..ff63fb6046b1 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -834,11 +834,19 @@ struct v4l2_subdev_state { * v4l2_subdev_init_finalize() at initialization time). Do not call * directly, use v4l2_subdev_enable_streams() instead. * + * Drivers that support only a single stream without setting the + * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask + * argument. + * * @disable_streams: Disable the streams defined in streams_mask on the given * source pad. Subdevs that implement this operation must use the active * state management provided by the subdev core (enabled through a call to * v4l2_subdev_init_finalize() at initialization time). Do not call * directly, use v4l2_subdev_disable_streams() instead. + * + * Drivers that support only a single stream without setting the + * V4L2_SUBDEV_CAP_STREAMS sub-device capability flag can ignore the mask + * argument. */ struct v4l2_subdev_pad_ops { int (*enum_mbus_code)(struct v4l2_subdev *sd,
Document the expected {enable,disable}_streams callback behaviour for drivers that are stream-unaware i.e. don't specify the V4L2_SUBDEV_CAP_STREAMS sub-device capability flat. In this specific case, the mask argument can be ignored. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- include/media/v4l2-subdev.h | 8 ++++++++ 1 file changed, 8 insertions(+)