diff mbox series

[v3,2/3] staging: media: ipu3: Use str_down_up()

Message ID 20240928-cocci-6-12-v3-2-53fc5ed20be0@chromium.org (mailing list archive)
State New
Headers show
Series media: static-analyzers: Fix 6.12-rc1 cocci warnings | expand

Commit Message

Ricardo Ribalda Sept. 28, 2024, 5:23 p.m. UTC 
The str_down_up() helper simplifies the code and fixes the following cocci
warning:

drivers/staging/media/ipu3/ipu3-css.c:229:18-47: opportunity for str_down_up(state & IMGU_STATE_POWER_DOWN)

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/staging/media/ipu3/ipu3-css.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans Verkuil Sept. 30, 2024, 7:16 a.m. UTC | #1 
On 28/09/2024 19:23, Ricardo Ribalda wrote:
> The str_down_up() helper simplifies the code and fixes the following cocci
> warning:
> 
> drivers/staging/media/ipu3/ipu3-css.c:229:18-47: opportunity for str_down_up(state & IMGU_STATE_POWER_DOWN)
> 
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 1b0a59b78949..bb22375481a0 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -226,7 +226,7 @@ int imgu_css_set_powerup(struct device *dev, void __iomem *base,
>  	state = readl(base + IMGU_REG_STATE);
>  
>  	dev_dbg(dev, "CSS pm_ctrl 0x%x state 0x%x (power %s)\n",
> -		pm_ctrl, state, state & IMGU_STATE_POWER_DOWN ? "down" : "up");
> +		pm_ctrl, state, str_down_up(state & IMGU_STATE_POWER_DOWN));
>  
>  	/* Power up CSS using wrapper */
>  	if (state & IMGU_STATE_POWER_DOWN) {
>
diff mbox series

Patch

diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
index 1b0a59b78949..bb22375481a0 100644
--- a/drivers/staging/media/ipu3/ipu3-css.c
+++ b/drivers/staging/media/ipu3/ipu3-css.c
@@ -226,7 +226,7 @@  int imgu_css_set_powerup(struct device *dev, void __iomem *base,
 	state = readl(base + IMGU_REG_STATE);
 
 	dev_dbg(dev, "CSS pm_ctrl 0x%x state 0x%x (power %s)\n",
-		pm_ctrl, state, state & IMGU_STATE_POWER_DOWN ? "down" : "up");
+		pm_ctrl, state, str_down_up(state & IMGU_STATE_POWER_DOWN));
 
 	/* Power up CSS using wrapper */
 	if (state & IMGU_STATE_POWER_DOWN) {