| Message ID | 20241004-ub9xx-fixes-v1-10-e30a4633c786@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: i2c: ds90ub9xx: Misc fixes and improvements | expand |
On Fri, Oct 04, 2024 at 05:46:41PM +0300, Tomi Valkeinen wrote: > We currently sleep for 50 ms at the end of each iteration in > ub960_rxport_wait_locks(). This feels a bit excessive, especially as we > always do at least two loops, so there's always at least one sleep, even > if we already have a stable lock. > > Change the sleep to 10 ms. ... > - msleep(50); > + fsleep(10 * 1000); USEC_PER_MSEC Can also a comment be added on top of this call to explain the choice?
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index d4a3759bc568..ab5330db4162 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -1575,7 +1575,7 @@ static int ub960_rxport_wait_locks(struct ub960_data *priv, if (missing == 0) break; - msleep(50); + fsleep(10 * 1000); } if (lock_mask)
We currently sleep for 50 ms at the end of each iteration in ub960_rxport_wait_locks(). This feels a bit excessive, especially as we always do at least two loops, so there's always at least one sleep, even if we already have a stable lock. Change the sleep to 10 ms. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- drivers/media/i2c/ds90ub960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)