| Message ID | 20241012141403.1558513-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: atomisp: remove redundant re-checking of err | expand |
On Sat, Oct 12, 2024 at 03:14:03PM +0100, Colin Ian King wrote: > The check to see if err is non-zero is always false because err has > been previously checked on whenever err has been assigned in previous > code paths. The check is redundant and can be removed. Reviewed-by: Andy Shevchenko <andy@kernel.org> All patches that end up in 100% minus lines statistics for this driver are so good!
Hi, On 12-Oct-24 4:14 PM, Colin Ian King wrote: > The check to see if err is non-zero is always false because err has > been previously checked on whenever err has been assigned in previous > code paths. The check is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Thank you for your patch(es). I have merged this/these in my media-atomisp branch: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp And this/these will be included in my next pull-request to Mauro (to media subsystem maintainer) Regards, Hans > --- > drivers/staging/media/atomisp/pci/sh_css.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c > index ca97ea082cf4..7cee4dc35427 100644 > --- a/drivers/staging/media/atomisp/pci/sh_css.c > +++ b/drivers/staging/media/atomisp/pci/sh_css.c > @@ -6308,9 +6308,6 @@ load_yuvpp_binaries(struct ia_css_pipe *pipe) > } > } > > - if (err) > - goto ERR; > - > ERR: > if (need_scaler) > ia_css_pipe_destroy_cas_scaler_desc(&cas_scaler_descr);
diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c index ca97ea082cf4..7cee4dc35427 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -6308,9 +6308,6 @@ load_yuvpp_binaries(struct ia_css_pipe *pipe) } } - if (err) - goto ERR; - ERR: if (need_scaler) ia_css_pipe_destroy_cas_scaler_desc(&cas_scaler_descr);
The check to see if err is non-zero is always false because err has been previously checked on whenever err has been assigned in previous code paths. The check is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/staging/media/atomisp/pci/sh_css.c | 3 --- 1 file changed, 3 deletions(-)