| Message ID | 20241024184313.700010-1-bjorn@mork.no (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: mantis: remove orphan mantis_core.h | expand |
Patchwork Integration <patchwork@media-ci.org> writes: > Thanks for your patches! Unfortunately media-ci detected some issues: > > # Test checkpatch:./0001-media-mantis-remove-orphan-mantis_core.h.patch > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b3b961448f70 ("V4L/DVB (13795): [Mantis/Hopper] Code overhaul, add Hopper devices into the PCI ID list")' > #9: > This file has been an orphan ever since commit b3b961448f70 > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #25: > deleted file mode 100644 > > total: 1 errors, 1 warnings, 0 checks, 0 lines checked .. > If you believe that the CI is wrong, The CI is wrong. There is no such ERROR. The commit description style is exactly as suggested. I assume the additional "()" in the original patch subject is messing up the regex. The WARNING is a question with answer "no", but AFAICS there is no way to tell the CI (or checkpatch) about this. Bjørn
diff --git a/drivers/media/pci/mantis/mantis_core.h b/drivers/media/pci/mantis/mantis_core.h deleted file mode 100644 index 93c89a10a2c7..000000000000 --- a/drivers/media/pci/mantis/mantis_core.h +++ /dev/null @@ -1,43 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - Mantis PCI bridge driver - - Copyright (C) Manu Abraham (abraham.manu@gmail.com) - -*/ - -#ifndef __MANTIS_CORE_H -#define __MANTIS_CORE_H - -#include "mantis_common.h" - - -#define FE_TYPE_SAT 0 -#define FE_TYPE_CAB 1 -#define FE_TYPE_TER 2 - -#define FE_TYPE_TS204 0 -#define FE_TYPE_TS188 1 - - -struct vendorname { - u8 *sub_vendor_name; - u32 sub_vendor_id; -}; - -struct devicetype { - u8 *sub_device_name; - u32 sub_device_id; - u8 device_type; - u32 type_flags; -}; - - -extern int mantis_dma_init(struct mantis_pci *mantis); -extern int mantis_dma_exit(struct mantis_pci *mantis); -extern void mantis_dma_start(struct mantis_pci *mantis); -extern void mantis_dma_stop(struct mantis_pci *mantis); -extern int mantis_i2c_init(struct mantis_pci *mantis); -extern int mantis_i2c_exit(struct mantis_pci *mantis); - -#endif /* __MANTIS_CORE_H */
This file has been an orphan ever since commit b3b961448f70 ("V4L/DVB (13795): [Mantis/Hopper] Code overhaul, add Hopper devices into the PCI ID list"), having no references except for the orphan removed by commit 519648bed470 ("media: mantis: remove orphan mantis_core.c") Fixes: b3b961448f70 ("V4L/DVB (13795): [Mantis/Hopper] Code overhaul, add Hopper devices into the PCI ID list") Link: https://patchwork.linuxtv.org/project/linux-media/patch/1277054487-14384-1-git-send-email-bjorn@mork.no/ Signed-off-by: Bjørn Mork <bjorn@mork.no> --- Yes, I did try to clean up this mess in 2010 already. Not sure why I bother, really. drivers/media/pci/mantis/mantis_core.h | 43 -------------------------- 1 file changed, 43 deletions(-) delete mode 100644 drivers/media/pci/mantis/mantis_core.h