@@ -1648,8 +1648,8 @@ static int npcm_video_setup_video(struct npcm_video *video)
static int npcm_video_ece_init(struct npcm_video *video)
{
+ struct device_node *ece_node __free(device_node) = NULL;
struct device *dev = video->dev;
- struct device_node *ece_node;
struct platform_device *ece_pdev;
void __iomem *regs;
@@ -1665,7 +1665,6 @@ static int npcm_video_ece_init(struct npcm_video *video)
dev_info(dev, "Support HEXTILE pixel format\n");
ece_pdev = of_find_device_by_node(ece_node);
- of_node_put(ece_node);
if (!ece_pdev) {
dev_err(dev, "Failed to find ECE device\n");
return -ENODEV;
@@ -1692,8 +1691,6 @@ static int npcm_video_ece_init(struct npcm_video *video)
dev_err(dev, "Failed to get ECE reset control in DTS\n");
return PTR_ERR(video->ece.reset);
}
- } else {
- of_node_put(ece_node);
}
return 0;
Instead of manually calling of_node_put, use the __free macros/helpers. Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/media/platform/nuvoton/npcm-video.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)