From patchwork Sun Feb 23 18:58:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13987203 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EF6320C47C for ; Sun, 23 Feb 2025 18:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740337171; cv=none; b=Zm3P8dRNFHr8ivJJ6uZk0BLYfrhTKoKiRStxqdkk+GMCnj9tvYnZY5dz4ewTM3ZQbCa/S+ugvB7d4ewEEDDbJwH+WCExiIEusu43hcOaRkylIDS+81hIQvceMHAO5kMGq/UJJ+xq1H88rabJZ/u2bQ98f1TZ/6n2tR37EDssJPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740337171; c=relaxed/simple; bh=xHh1GodNV49mVOXTDlr/kmEEgfRtOkAHCbSYPASBaZQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IPYafXAoLwTZ2kPZnUn7qPxPUu7Bm837zQXADHH86NE3ZUoVIUjiq6cwVZGsxNj88CXva8jBgpfAlz7PqcoUjb0vt5TXFKhNVmAKC6wVgbk3khklFEjhsYP3m8ZbSYvA0nmGkZOC2A1N0N7P5reUnytFUkM4XfegOn58bAQtA7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Me+M/EUD; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Me+M/EUD" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7c0b0ca6742so419288385a.0 for ; Sun, 23 Feb 2025 10:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740337169; x=1740941969; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uRb6n6dm7lw2Z9XBFIWilv+DzQlMIIsiVy3tu994jwM=; b=Me+M/EUDOEG1Slj5OTfOzycsg8s37tnkh2Z5MeN+oTTtcq9LpUHOrL5Pxk1JOMaHbw WDb2ABmVZ2vDaynXy5humC9f40EbigNNIh86yJK+yCjpzYInbrZGaakjQAy3zXY90XkM w/wlk3E83eoAM8j0mLtW7WPfvtdwIP6ItMuoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740337169; x=1740941969; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uRb6n6dm7lw2Z9XBFIWilv+DzQlMIIsiVy3tu994jwM=; b=Ui8thLa5PYER+GwMydvik4PE4VcW3pinlECYtQkSOdYIJjlk0DlEI+GJY38peNr0NE FXu3QucvaKV3ARYOKhUzrVUmweeDHNpwh+koDzFi677HDPOjAe7YbREHiRJLbbqoDt1B U0pufCxrL5qxotnL27MhLfoLbc1zpDjNs1pYF0fGfxgZrP8DMc0Y9hExlZj15WIZH8PD VTID25y/vL5Sk9JxbEeCpXwJQlYBCTAM1dbPW3aot+JUlEvNPZhwQ5yVN6cOpAU7yktO IVPmFXS79os3kJVcyYi0wAP50b3ippaxRlgXj3/PQGkDiz5fPY3SnTfCijTkiHrF8KwJ VHAg== X-Gm-Message-State: AOJu0Yy/qa7Afmyw4xYbmeBAl8O4sVV0JJ76e6fWKePTYTy/iTVR6Sh1 Ov77fqrsjIBS8h9GawBBVAT8icdQeH45iJ1LsK0a4BRJ24f7NA8tmeRSPeWqFw== X-Gm-Gg: ASbGncsV+08asMsxi8hqV2JX63mBM4HgV/5quSl9rcmuEVeXvaOTKu+UBhzl8OCgj/j cDtPSpdATtsTNxgjf7iYNMlPBjsvUg07npgukEs6ws7kWRpvXjdM6XGt83UCOdiMfoyRBdhehtI BCwMvmAgDXfxq0jITYtl9vLXQgGk/f4LN861LHnkpG/VZJgR4zcL51zKLkg+mFUvT3uQ6hbcGad ryuRrr7Uflv+T9bJb6AiK/rTPJsZ5DTiwmqO3zLVer1VSZI9egNC+ye/ycyOLZZbeAeuF7Z9y9C E7o+EXsXxeEdtuO+Y96auTkcoMM4dE+Q5ovUFkAmq30/vsZXEQhhcLQXN1IheRVMUAMARVWgnsa O+44= X-Google-Smtp-Source: AGHT+IFIm1syTpeE2i1EYWI3iEtSyliT4ATG6d2xnrdk5fvsT0z7+hE4dqtz3meToG77GzeKzuMC5Q== X-Received: by 2002:a05:620a:444c:b0:7c0:7a0b:3727 with SMTP id af79cd13be357-7c0ceefd391mr1224831785a.16.1740337169084; Sun, 23 Feb 2025 10:59:29 -0800 (PST) Received: from denia.c.googlers.com (15.237.245.35.bc.googleusercontent.com. [35.245.237.15]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c09bf81253sm894052885a.47.2025.02.23.10.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 10:59:27 -0800 (PST) From: Ricardo Ribalda Date: Sun, 23 Feb 2025 18:58:07 +0000 Subject: [PATCH v3 04/12] media: uvcvideo: Remove vidioc_queryctrl Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250223-queryctrl-v3-4-4292911cab6b@chromium.org> References: <20250223-queryctrl-v3-0-4292911cab6b@chromium.org> In-Reply-To: <20250223-queryctrl-v3-0-4292911cab6b@chromium.org> To: Mauro Carvalho Chehab , Mike Isely , Laurent Pinchart , Hans de Goede , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.13.0 It can be implemented by the v4l2 ioctl framework using vidioc_query_ext_ctrl. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c index 93c6cdb23881..89052455ed50 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -963,15 +963,6 @@ static int uvc_ioctl_s_input(struct file *file, void *fh, unsigned int input) return ret; } -static int uvc_ioctl_queryctrl(struct file *file, void *fh, - struct v4l2_queryctrl *qc) -{ - struct uvc_fh *handle = fh; - struct uvc_video_chain *chain = handle->chain; - - return uvc_query_v4l2_ctrl(chain, qc); -} - static int uvc_ioctl_query_ext_ctrl(struct file *file, void *fh, struct v4l2_query_ext_ctrl *qec) { @@ -1491,7 +1482,6 @@ const struct v4l2_ioctl_ops uvc_ioctl_ops = { .vidioc_enum_input = uvc_ioctl_enum_input, .vidioc_g_input = uvc_ioctl_g_input, .vidioc_s_input = uvc_ioctl_s_input, - .vidioc_queryctrl = uvc_ioctl_queryctrl, .vidioc_query_ext_ctrl = uvc_ioctl_query_ext_ctrl, .vidioc_g_ext_ctrls = uvc_ioctl_g_ext_ctrls, .vidioc_s_ext_ctrls = uvc_ioctl_s_ext_ctrls,