diff mbox series

[02/18] media: coda: Use get_array to work use multiple reset

Message ID 20250314152939.2759573-3-serghox@gmail.com (mailing list archive)
State New
Headers show
Series coda988 video codec support | expand

Commit Message

Sergey Khimich March 14, 2025, 3:29 p.m. UTC 
From: Vladimir Yakovlev <vovchkir@gmail.com>

Some Coda's IP blocks may require more than one reset signal.
Than we must use get_array or bulk functions. For compatibility with old
code it's better to use devm_reset_control_array_get_optional_exclusive().

Co-developed-by: Sergey Khimich <serghox@gmail.com>
Signed-off-by: Sergey Khimich <serghox@gmail.com>
Signed-off-by: Vladimir Yakovlev <vovchkir@gmail.com>
---
 drivers/media/platform/chips-media/coda/coda-common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Krzysztof Kozlowski March 16, 2025, 11:44 a.m. UTC | #1 
On 14/03/2025 16:29, Sergey Khimich wrote:
> From: Vladimir Yakovlev <vovchkir@gmail.com>
> 
> Some Coda's IP blocks may require more than one reset signal.
> Than we must use get_array or bulk functions. For compatibility with old
> code it's better to use devm_reset_control_array_get_optional_exclusive().
> 
> Co-developed-by: Sergey Khimich <serghox@gmail.com>
> Signed-off-by: Sergey Khimich <serghox@gmail.com>
> Signed-off-by: Vladimir Yakovlev <vovchkir@gmail.com>
Your chain is supposed to be reverse or fixed other way. Your SoB cannot
be before the author. Look at submitting patches - it is explained there
pretty precise, exactly your case.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-common.c
index 84b9b75b382e..c39ba4fba547 100644
--- a/drivers/media/platform/chips-media/coda/coda-common.c
+++ b/drivers/media/platform/chips-media/coda/coda-common.c
@@ -3203,8 +3203,7 @@  static int coda_probe(struct platform_device *pdev)
 		}
 	}
 
-	dev->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev,
-							      NULL);
+	dev->rstc = devm_reset_control_array_get_optional_exclusive(&pdev->dev);
 	if (IS_ERR(dev->rstc)) {
 		ret = PTR_ERR(dev->rstc);
 		dev_err(&pdev->dev, "failed get reset control: %d\n", ret);