| Message ID | 20250314152939.2759573-4-serghox@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | coda988 video codec support | expand |
On 14/03/2025 16:29, Sergey Khimich wrote: > From: Vladimir Yakovlev <vovchkir@gmail.com> > > Change resets count because now we use get array function and reset > signas may be more than 1. > > Co-developed-by: Sergey Khimich <serghox@gmail.com> > Signed-off-by: Sergey Khimich <serghox@gmail.com> > Signed-off-by: Vladimir Yakovlev <vovchkir@gmail.com> <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > --- > Documentation/devicetree/bindings/media/coda.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml > index c9d5adbc8c4a..3cb0e9afc100 100644 > --- a/Documentation/devicetree/bindings/media/coda.yaml > +++ b/Documentation/devicetree/bindings/media/coda.yaml > @@ -60,7 +60,7 @@ properties: > maxItems: 1 > > resets: > - maxItems: 1 > + minItems: 1 No, this must be specific. Best regards, Krzysztof
On 24/03/2025 14:46, Sergey Khimich wrote: >>> diff --git a/Documentation/devicetree/bindings/media/coda.yaml >> b/Documentation/devicetree/bindings/media/coda.yaml >>> index c9d5adbc8c4a..3cb0e9afc100 100644 >>> --- a/Documentation/devicetree/bindings/media/coda.yaml >>> +++ b/Documentation/devicetree/bindings/media/coda.yaml >>> @@ -60,7 +60,7 @@ properties: >>> maxItems: 1 >>> >>> resets: >>> - maxItems: 1 >>> + minItems: 1 >> >> No, this must be specific. >> > Here I can suggest the following patch with adding standalone (without a > SoC-specific fallback) definition of coda980 codec: How can it be used outside of soc? > > @@ -30,6 +30,8 @@ properties: > - fsl,imx6dl-vpu > - fsl,imx6q-vpu > - const: cnm,coda960 > + - items: > + - const: cnm,coda980 > > reg: > maxItems: 1 > @@ -60,7 +62,15 @@ properties: > maxItems: 1 > > resets: > - maxItems: 1 > + if: There is no such syntax - see other files or example-schema. > + properties: > + compatible: > + contains: > + const: cnm,coda980 > + then: > + maxItems: 2 # CODA980 supports 2 resets Still not specific - you need to list the items. See other files. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml index c9d5adbc8c4a..3cb0e9afc100 100644 --- a/Documentation/devicetree/bindings/media/coda.yaml +++ b/Documentation/devicetree/bindings/media/coda.yaml @@ -60,7 +60,7 @@ properties: maxItems: 1 resets: - maxItems: 1 + minItems: 1 iram: $ref: /schemas/types.yaml#/definitions/phandle