diff mbox series

[6.1] media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning

Message ID 20250315102903.3634639-1-sdl@nppct.ru (mailing list archive)
State New
Headers show
Series [6.1] media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning | expand

Commit Message

Alexey Nepomnyashih March 15, 2025, 10:29 a.m. UTC
From: Yunfei Dong <yunfei.dong@mediatek.com>

commit b113bc7c0e83b32f4dd2d291a2b6c4803e0a2c44 upstream.

Fix a smatch static checker warning on vdec_vp8_req_if.c.
Which leads to a kernel crash when fb is NULL.

Fixes: 7a7ae26fd458 ("media: mediatek: vcodec: support stateless VP8 decoding")
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[ Alexey Nepomnyashih: changed mtk_vdec_err() to mtk_vcodec_err. ]
Signed-off-by: Alexey Nepomnyashih <sdl@nppct.ru>
---
 .../platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Alexey Nepomnyashih March 17, 2025, 5:54 p.m. UTC | #1
Hello, , I don't understand my mistake, the patch is correct

15.03.2025 14:49, Patchwork Integration пишет:
> Dear Alexey Nepomnyashih:
>
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
>
> # Test doc:htmldocs
>
> Configuration error:
> There is a programmable error in your configuration file:
>
> Traceback (most recent call last):
>    File "/usr/lib/python3/dist-packages/sphinx/config.py", line 529, in eval_config_file
>      exec(code, namespace)  # NoQA: S102
>      ~~~~^^^^^^^^^^^^^^^^^
>    File "/builds/linux-media/users/patchwork/Documentation/conf.py", line 27, in <module>
>      from load_config import loadConfig
>    File "/builds/linux-media/users/patchwork/Documentation/sphinx/load_config.py", line 6, in <module>
>      from sphinx.util.pycompat import execfile_
> ModuleNotFoundError: No module named 'sphinx.util.pycompat'
>
> make[1]: *** [Documentation/Makefile:96: htmldocs] Error 2
> make: *** [Makefile:1686: htmldocs] Error 2
>
> # Test doc:pdfdocs
>
> Configuration error:
> There is a programmable error in your configuration file:
>
> Traceback (most recent call last):
>    File "/usr/lib/python3/dist-packages/sphinx/config.py", line 529, in eval_config_file
>      exec(code, namespace)  # NoQA: S102
>      ~~~~^^^^^^^^^^^^^^^^^
>    File "/builds/linux-media/users/patchwork/Documentation/conf.py", line 27, in <module>
>      from load_config import loadConfig
>    File "/builds/linux-media/users/patchwork/Documentation/sphinx/load_config.py", line 6, in <module>
>      from sphinx.util.pycompat import execfile_
> ModuleNotFoundError: No module named 'sphinx.util.pycompat'
>
> make[1]: *** [Documentation/Makefile:103: latexdocs] Error 2
> make: *** [Makefile:1686: pdfdocs] Error 2
>
> # Test build:allmodconfig x86_64
>
> drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
>    176 |         u8 value_116, value_117;
>        |            ^~~~~~~~~
> In function ‘stk_camera_write_reg’,
>      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
>    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    137 |                         0x01,
>        |                         ~~~~~
>    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
>        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    139 |                         value,
>        |                         ~~~~~~
>    140 |                         index,
>        |                         ~~~~~~
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
>    176 |         u8 value_116, value_117;
>        |                       ^~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
>    174 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    217 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
>    217 |         u8 value;
>        |            ^~~~~
> drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>   6673 |         *ucblocks = (u32) err;
>        |                     ^~~~~~~~~
> drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
>   6663 |         u16 err;
>        |             ^~~
> drivers/media/platform/qcom/camss/qcom-camss.o: warning: objtool: csiphy_lanes_enable() falls through to next function csiphy_link_setup()
> scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/platform/qcom/camss/qcom-camss.o: warning: objtool: csiphy_lanes_enable() falls through to next function csiphy_link_setup()
>
> # Test build:ACPI x86_64
>
>    139 |                         value,
>        |                         ~~~~~~
>    140 |                         index,
>        |                         ~~~~~~
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
>    176 |         u8 value_116, value_117;
>        |                       ^~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
>    174 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    217 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
>    217 |         u8 value;
>        |            ^~~~~
> drivers/media/tuners/mxl5005s.c: In function ‘MXL_ControlWrite_Group.isra’:
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
>   3429 |                                                 state->Init_Ctrl[i].val[j] = (u8)((value >> j) & 0x01);
>        |                                                 ~~~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/media/tuners/mxl5005s.c:238:13: note: while referencing ‘val’
>    238 |         u16 val[25];    /* Binary representation of Value */
>        |             ^~~
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
>   3448 |                                                 state->CH_Ctrl[i].val[j] = (u8)((value >> j) & 0x01);
>        |                                                 ~~~~~~~~~~~~~~~~~~~~~^~~
> drivers/media/tuners/mxl5005s.c:238:13: note: while referencing ‘val’
>    238 |         u16 val[25];    /* Binary representation of Value */
>        |             ^~~
> drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>   6673 |         *ucblocks = (u32) err;
>        |                     ^~~~~~~~~
> drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
>   6663 |         u16 err;
>        |             ^~~
> scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>
> # Test build:DEBUG_FS x86_64
> Unable to undef DEBUG_FS
>
> # Test build:OF x86_64
>
> drivers/media/platform/allegro-dvt/allegro-core.c:3995:34: warning: ‘allegro_dt_ids’ defined but not used [-Wunused-const-variable=]
> drivers/media/cec/i2c/ch7322.c:585:34: warning: ‘ch7322_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/cec/platform/meson/ao-cec.c:711:34: warning: ‘meson_ao_cec_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/cec/platform/tegra/tegra_cec.c:457:34: warning: ‘tegra_cec_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/platform/intel/pxa_camera.c:2449:34: warning: ‘pxa_camera_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/platform/mediatek/mdp/mtk_mdp_core.c:31:34: warning: ‘mtk_mdp_comp_dt_ids’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/marvell/mmp-driver.c:364:34: warning: ‘mmpcam_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/staging/media/hantro/hantro_drv.c:620:34: warning: ‘of_hantro_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/i2c/imx290.c:1141:34: warning: ‘imx290_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/i2c/mt9m111.c:1372:34: warning: ‘mt9m111_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1166:34: warning: ‘c8sectpfe_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/i2c/ov2640.c:1293:34: warning: ‘ov2640_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: warning: ‘samsung_jpeg_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/i2c/ov2680.c:1149:34: warning: ‘ov2680_dt_ids’ defined but not used [-Wunused-const-variable=]
> drivers/media/rc/gpio-ir-recv.c:184:34: warning: ‘gpio_ir_recv_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/rc/gpio-ir-tx.c:24:34: warning: ‘gpio_ir_tx_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/dvb-frontends/mn88443x.c:784:34: warning: ‘mn88443x_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:911:34: warning: ‘sun6i_csi_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:796:34: warning: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:730:34: warning: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/i2c/ov7740.c:1204:34: warning: ‘ov7740_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: warning: ‘vpfe_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/rc/pwm-ir-tx.c:24:34: warning: ‘pwm_ir_of_match’ defined but not used [-Wunused-const-variable=]
> drivers/media/rc/ir-rx51.c:274:34: warning: ‘ir_rx51_match’ defined but not used [-Wunused-const-variable=]
>
> # Test build:PM x86_64
>
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
>    176 |         u8 value_116, value_117;
>        |            ^~~~~~~~~
> In function ‘stk_camera_write_reg’,
>      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
>    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    137 |                         0x01,
>        |                         ~~~~~
>    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
>        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    139 |                         value,
>        |                         ~~~~~~
>    140 |                         index,
>        |                         ~~~~~~
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
>    176 |         u8 value_116, value_117;
>        |                       ^~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
>    174 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    217 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
>    217 |         u8 value;
>        |            ^~~~~
> drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>   6673 |         *ucblocks = (u32) err;
>        |                     ^~~~~~~~~
> drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
>   6663 |         u16 err;
>        |             ^~~
> scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>
> # Test build:PM_SLEEP x86_64
>
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
>    176 |         u8 value_116, value_117;
>        |            ^~~~~~~~~
> In function ‘stk_camera_write_reg’,
>      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
>    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    137 |                         0x01,
>        |                         ~~~~~
>    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
>        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    139 |                         value,
>        |                         ~~~~~~
>    140 |                         index,
>        |                         ~~~~~~
>    141 |                         NULL,
>        |                         ~~~~~
>    142 |                         0,
>        |                         ~~
>    143 |                         500);
>        |                         ~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
>    176 |         u8 value_116, value_117;
>        |                       ^~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
>        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
>    174 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
>    217 |         u8 value;
>        |            ^~~~~
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
>    217 |         u8 value;
>        |            ^~~~~
> drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>   6673 |         *ucblocks = (u32) err;
>        |                     ^~~~~~~~~
> drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
>   6663 |         u16 err;
>        |             ^~~
> scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
>
> # Test static-upstream:test-compile-all
> Unable to build VIDEO_TEGRA
>
> # Test static-upstream:test-smatch
>
> drivers/media/usb/dvb-usb-v2/af9015.c:1168 af9015_rc_query() warn: missing error code? 'ret'
> drivers/media/usb/dvb-usb-v2/af9015.c:1177 af9015_rc_query() warn: missing error code? 'ret'
> drivers/staging/media/meson/vdec/vdec_1.c:239 vdec_1_start() warn: 'core->vdec_1_clk' from clk_prepare_enable() not released on lines: 239.
> drivers/staging/media/meson/vdec/vdec_hevc.c:223 vdec_hevc_start() warn: 'core->vdec_hevc_clk' from clk_prepare_enable() not released on lines: 223.
> drivers/staging/media/meson/vdec/vdec_hevc.c:223 vdec_hevc_start() warn: 'core->vdec_hevcf_clk' from clk_prepare_enable() not released on lines: 171,223.
> drivers/media/platform/marvell/mmp-driver.c:257 mmpcam_probe() warn: missing unwind goto?
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2222 mxc_jpeg_probe() warn: missing unwind goto?
> drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'
> drivers/media/platform/mediatek/vpu/mtk_vpu.c:1033 mtk_vpu_resume() warn: 'vpu->clk' from clk_prepare() not released on lines: 1022.
> drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
> drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c:467 h264_encode_frame() warn: missing error code? 'ret'
> drivers/media/usb/as102/as102_usb_drv.c:306 as102_usb_release() warn: can 'as102_dev' even be NULL?
> drivers/media/i2c/ov7670.c:1844 ov7670_parse_dt() warn: missing error code? 'ret'
> drivers/staging/media/ipu3/ipu3-dmamap.c:42 imgu_dmamap_alloc_buffer() warn: use 'gfp' here instead of GFP_KERNEL?
> drivers/media/dvb-frontends/mb86a16.c:1514 mb86a16_send_diseqc_msg() warn: missing unwind goto?
> drivers/media/platform/renesas/vsp1/vsp1_histo.c:153 histo_stop_streaming() warn: mixing irqsave and irq
> drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
> drivers/media/platform/renesas/renesas-ceu.c:705 ceu_start_streaming() warn: can 'buf' even be NULL?
> drivers/media/platform/rockchip/rga/rga.c:734 rga_enable_clocks() warn: 'rga->sclk' from clk_prepare_enable() not released on lines: 734.
> drivers/media/pci/cx18/cx18-mailbox.c:833 cx18_vapi() error: we previously assumed 'cx' could be null (see line 832)
> drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
> drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1163 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1142,1149.
> drivers/media/platform/st/sti/hva/hva-hw.c:412 hva_hw_probe() warn: 'hva->clk' from clk_prepare() not released on lines: 412.
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:677 sun6i_subdev_notify_complete() warn: can 'sd' even be NULL?
> drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
> drivers/media/platform/ti/davinci/vpbe.c:741 vpbe_initialize() warn: 'vpbe_dev->dac_clk' from clk_prepare_enable() not released on lines: 741.
> drivers/media/platform/ti/davinci/vpbe_display.c:1152 vpbe_display_open() warn: missing error code? 'err'
> drivers/media/pci/solo6x10/solo6x10-core.c:630 solo_pci_probe() warn: 'pdev->irq' from request_irq() not released on lines: 630.
> drivers/media/pci/solo6x10/solo6x10-core.c:630 solo_pci_probe() warn: 'pdev' from pci_request_regions() not released on lines: 630.
> drivers/media/pci/saa7134/saa7134-alsa.c:1186 alsa_card_saa7134_create() warn: 'dev->pci->irq' from request_irq() not released on lines: 1186.
> drivers/media/pci/tw686x/tw686x-audio.c:62 tw686x_audio_irq() warn: can 'next' even be NULL?
>
> # Test static-upstream:test-sparse
> scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
> drivers/input/touchscreen/sur40.c:424:55: warning: incorrect type in argument 2 (different base types)
> drivers/input/touchscreen/sur40.c:424:55:    expected int key
> drivers/input/touchscreen/sur40.c:424:55:    got restricted __le16 [usertype] blob_id
> drivers/staging/media/meson/vdec/codec_vp9.c: In function ‘adapt_coef_probs.constprop’:
> drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
>   1689 |                         coef_node_start = coef_node_start + 1;
>        |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/meson/vdec/codec_vp9.c:1551:19: note: ‘coef_node_start’ was declared here
>   1551 |         int node, coef_node_start, coef_count_node_start;
>        |                   ^~~~~~~~~~~~~~~
> drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
>
> # Test static-upstream:test-coccinelle
> drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:516:11-29: WARNING: dma_alloc_coherent used in cfg_stm already zeroes out memory, so memset is not needed
> drivers/media/usb/uvc/uvc_ctrl.c:1703:44-50: ERROR: invalid reference to the index variable of the iterator on line 1692
> drivers/media/usb/uvc/uvc_ctrl.c:2035:17-23: ERROR: invalid reference to the index variable of the iterator on line 2019
> drivers/media/v4l2-core/v4l2-async.c:300:23-30: ERROR: PTR_ERR applied after initialization to constant on line 288
> drivers/media/dvb-frontends/tda18271c2dd.c:355:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> drivers/media/dvb-frontends/tda18271c2dd.c:331:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
>
> # Test abi:pahole x86
> /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
>     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
>        |                               ^~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
>     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
>        |                                       ^~~~~~~~~~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
>     53 | struct v4l2_ctrl_av1_frame av1_frame;
>        |                            ^~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
>     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
>        |                                 ^~~~~~~~~~~~~~
>
> # Test abi:pahole arm
> /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
>     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
>        |                               ^~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
>     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
>        |                                       ^~~~~~~~~~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
>     53 | struct v4l2_ctrl_av1_frame av1_frame;
>        |                            ^~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
>     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
>        |                                 ^~~~~~~~~~~~~~
>
> # Test abi:pahole powerpc
> /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
>     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
>        |                               ^~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
>     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
>        |                                       ^~~~~~~~~~~~~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
>     53 | struct v4l2_ctrl_av1_frame av1_frame;
>        |                            ^~~~~~~~~
> /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
>     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
>        |                                 ^~~~~~~~~~~~~~
>
> # Test abi:abidump arm
> WARNING: module version is not specified (-lver NUM)
>
> # Test abi:abidump powerpc64
> WARNING: module version is not specified (-lver NUM)
>
> # Test media-patchstyle:test-valid-ancestor
> ERROR: This code is not based on any of the branches: next fixes
>         from git://linuxtv.org/media.git or https://gitlab.freedesktop.org/linux-media/media-committers.git.
>         The output of media-ci will not be reliable, and the code will not
>         land upstream as-is. Please rebase your code.
>
> # Test checkpatch:./0001-media-mediatek-vcodec-Fix-VP8-stateless-decoder-smat.patch checkpatch
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b113bc7c0e83 ("media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning")'
> #7:
> commit b113bc7c0e83b32f4dd2d291a2b6c4803e0a2c44 upstream.
>
> total: 1 errors, 0 warnings, 0 checks, 21 lines checked
>
>
>
> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
>
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72987470/artifacts/report.htm .
>
>
>
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
>
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
>
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.
>
>
Nicolas Dufresne April 1, 2025, 9:05 p.m. UTC | #2
Hi,

Le lundi 17 mars 2025 à 20:54 +0300, SDL a écrit :
> Hello, , I don't understand my mistake, the patch is correct

Please consider using ./scripts/checkpatch.pl before submitting. DOS
line endings was none expected. Also, as this is a hand written
backport, its your duty to CC stable.

The report you should have had:

WARNING: A patch subject line should describe the change not the tool that found it
#105: 
Subject: [PATCH 6.1] media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning

ERROR: DOS line endings
#144: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:339:
+^Iif (!fb) {^M$

ERROR: DOS line endings
#145: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:340:
+^I^Imtk_vcodec_err(inst, "fb buffer is NULL");^M$

ERROR: DOS line endings
#146: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:341:
+^I^Ireturn -ENOMEM;^M$

ERROR: DOS line endings
#147: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:342:
+^I}^M$

ERROR: DOS line endings
#150: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:344:
+^Idst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);^M$

ERROR: DOS line endings
#151: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:345:
+^Iy_fb_dma = fb->base_y.dma_addr;^M$

ERROR: DOS line endings
#157: FILE: drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c:350:
+^I^Ic_fb_dma = fb->base_c.dma_addr;^M$

total: 7 errors, 1 warnings, 0 checks, 21 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/home/nicolas/Téléchargements/[PATCH 6.1] media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning.mbox has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

regards,
Nicolas

> 
> 15.03.2025 14:49, Patchwork Integration пишет:
> > Dear Alexey Nepomnyashih:
> > 
> > Thanks for your patches! Unfortunately the Media CI robot detected some
> > issues:
> > 
> > # Test doc:htmldocs
> > 
> > Configuration error:
> > There is a programmable error in your configuration file:
> > 
> > Traceback (most recent call last):
> >    File "/usr/lib/python3/dist-packages/sphinx/config.py", line 529, in eval_config_file
> >      exec(code, namespace)  # NoQA: S102
> >      ~~~~^^^^^^^^^^^^^^^^^
> >    File "/builds/linux-media/users/patchwork/Documentation/conf.py", line 27, in <module>
> >      from load_config import loadConfig
> >    File "/builds/linux-media/users/patchwork/Documentation/sphinx/load_config.py", line 6, in <module>
> >      from sphinx.util.pycompat import execfile_
> > ModuleNotFoundError: No module named 'sphinx.util.pycompat'
> > 
> > make[1]: *** [Documentation/Makefile:96: htmldocs] Error 2
> > make: *** [Makefile:1686: htmldocs] Error 2
> > 
> > # Test doc:pdfdocs
> > 
> > Configuration error:
> > There is a programmable error in your configuration file:
> > 
> > Traceback (most recent call last):
> >    File "/usr/lib/python3/dist-packages/sphinx/config.py", line 529, in eval_config_file
> >      exec(code, namespace)  # NoQA: S102
> >      ~~~~^^^^^^^^^^^^^^^^^
> >    File "/builds/linux-media/users/patchwork/Documentation/conf.py", line 27, in <module>
> >      from load_config import loadConfig
> >    File "/builds/linux-media/users/patchwork/Documentation/sphinx/load_config.py", line 6, in <module>
> >      from sphinx.util.pycompat import execfile_
> > ModuleNotFoundError: No module named 'sphinx.util.pycompat'
> > 
> > make[1]: *** [Documentation/Makefile:103: latexdocs] Error 2
> > make: *** [Makefile:1686: pdfdocs] Error 2
> > 
> > # Test build:allmodconfig x86_64
> > 
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |            ^~~~~~~~~
> > In function ‘stk_camera_write_reg’,
> >      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> >    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> >        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    137 |                         0x01,
> >        |                         ~~~~~
> >    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> >        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    139 |                         value,
> >        |                         ~~~~~~
> >    140 |                         index,
> >        |                         ~~~~~~
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |                       ^~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
> >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
> >    174 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> >   6673 |         *ucblocks = (u32) err;
> >        |                     ^~~~~~~~~
> > drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
> >   6663 |         u16 err;
> >        |             ^~~
> > drivers/media/platform/qcom/camss/qcom-camss.o: warning: objtool: csiphy_lanes_enable() falls through to next function csiphy_link_setup()
> > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/platform/qcom/camss/qcom-camss.o: warning: objtool: csiphy_lanes_enable() falls through to next function csiphy_link_setup()
> > 
> > # Test build:ACPI x86_64
> > 
> >    139 |                         value,
> >        |                         ~~~~~~
> >    140 |                         index,
> >        |                         ~~~~~~
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |                       ^~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
> >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
> >    174 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/media/tuners/mxl5005s.c: In function ‘MXL_ControlWrite_Group.isra’:
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> >   3429 |                                                 state->Init_Ctrl[i].val[j] = (u8)((value >> j) & 0x01);
> >        |                                                 ~~~~~~~~~~~~~~~~~~~~~~~^~~
> > drivers/media/tuners/mxl5005s.c:238:13: note: while referencing ‘val’
> >    238 |         u16 val[25];    /* Binary representation of Value */
> >        |             ^~~
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> >   3448 |                                                 state->CH_Ctrl[i].val[j] = (u8)((value >> j) & 0x01);
> >        |                                                 ~~~~~~~~~~~~~~~~~~~~~^~~
> > drivers/media/tuners/mxl5005s.c:238:13: note: while referencing ‘val’
> >    238 |         u16 val[25];    /* Binary representation of Value */
> >        |             ^~~
> > drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> >   6673 |         *ucblocks = (u32) err;
> >        |                     ^~~~~~~~~
> > drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
> >   6663 |         u16 err;
> >        |             ^~~
> > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> > 
> > # Test build:DEBUG_FS x86_64
> > Unable to undef DEBUG_FS
> > 
> > # Test build:OF x86_64
> > 
> > drivers/media/platform/allegro-dvt/allegro-core.c:3995:34: warning: ‘allegro_dt_ids’ defined but not used [-Wunused-const-variable=]
> > drivers/media/cec/i2c/ch7322.c:585:34: warning: ‘ch7322_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/cec/platform/meson/ao-cec.c:711:34: warning: ‘meson_ao_cec_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/cec/platform/tegra/tegra_cec.c:457:34: warning: ‘tegra_cec_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/platform/intel/pxa_camera.c:2449:34: warning: ‘pxa_camera_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/platform/mediatek/mdp/mtk_mdp_core.c:31:34: warning: ‘mtk_mdp_comp_dt_ids’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/marvell/mmp-driver.c:364:34: warning: ‘mmpcam_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/staging/media/hantro/hantro_drv.c:620:34: warning: ‘of_hantro_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/i2c/imx290.c:1141:34: warning: ‘imx290_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/i2c/mt9m111.c:1372:34: warning: ‘mt9m111_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1166:34: warning: ‘c8sectpfe_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/i2c/ov2640.c:1293:34: warning: ‘ov2640_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: warning: ‘samsung_jpeg_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/i2c/ov2680.c:1149:34: warning: ‘ov2680_dt_ids’ defined but not used [-Wunused-const-variable=]
> > drivers/media/rc/gpio-ir-recv.c:184:34: warning: ‘gpio_ir_recv_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/rc/gpio-ir-tx.c:24:34: warning: ‘gpio_ir_tx_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/dvb-frontends/mn88443x.c:784:34: warning: ‘mn88443x_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:911:34: warning: ‘sun6i_csi_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:796:34: warning: ‘sun8i_a83t_mipi_csi2_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:730:34: warning: ‘sun6i_mipi_csi2_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/i2c/ov7740.c:1204:34: warning: ‘ov7740_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/platform/ti/am437x/am437x-vpfe.c:2620:34: warning: ‘vpfe_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/rc/pwm-ir-tx.c:24:34: warning: ‘pwm_ir_of_match’ defined but not used [-Wunused-const-variable=]
> > drivers/media/rc/ir-rx51.c:274:34: warning: ‘ir_rx51_match’ defined but not used [-Wunused-const-variable=]
> > 
> > # Test build:PM x86_64
> > 
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |            ^~~~~~~~~
> > In function ‘stk_camera_write_reg’,
> >      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> >    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> >        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    137 |                         0x01,
> >        |                         ~~~~~
> >    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> >        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    139 |                         value,
> >        |                         ~~~~~~
> >    140 |                         index,
> >        |                         ~~~~~~
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |                       ^~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
> >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
> >    174 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> >   6673 |         *ucblocks = (u32) err;
> >        |                     ^~~~~~~~~
> > drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
> >   6663 |         u16 err;
> >        |             ^~~
> > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> > 
> > # Test build:PM_SLEEP x86_64
> > 
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:12: note: ‘value_116’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |            ^~~~~~~~~
> > In function ‘stk_camera_write_reg’,
> >      inlined from ‘stk_start_stream’ at drivers/staging/media/stkwebcam/stk-webcam.c:202:2:
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> >    136 |         ret =  usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> >        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    137 |                         0x01,
> >        |                         ~~~~~
> >    138 |                         USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> >        |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >    139 |                         value,
> >        |                         ~~~~~~
> >    140 |                         index,
> >        |                         ~~~~~~
> >    141 |                         NULL,
> >        |                         ~~~~~
> >    142 |                         0,
> >        |                         ~~
> >    143 |                         500);
> >        |                         ~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_start_stream’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:176:23: note: ‘value_117’ was declared here
> >    176 |         u8 value_116, value_117;
> >        |                       ^~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    199 |         stk_camera_write_reg(dev, 0x0100, value | 0x80);
> >        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:174:12: note: ‘value’ was declared here
> >    174 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c: In function ‘stk_stop_stream.isra’:
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: note: ‘value’ was declared here
> >    217 |         u8 value;
> >        |            ^~~~~
> > drivers/media/dvb-frontends/drxk_hard.c: In function ‘drxk_read_ucblocks’:
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> >   6673 |         *ucblocks = (u32) err;
> >        |                     ^~~~~~~~~
> > drivers/media/dvb-frontends/drxk_hard.c:6663:13: note: ‘err’ was declared here
> >   6663 |         u16 err;
> >        |             ^~~
> > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/tuners/mxl5005s.c:3429:72: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/media/tuners/mxl5005s.c:3448:70: warning: array subscript 32 is above array bounds of ‘u16[25]’ {aka ‘short unsigned int[25]’} [-Warray-bounds=]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_116’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:136:16: warning: ‘value_117’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:199:9: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/staging/media/stkwebcam/stk-webcam.c:217:12: warning: ‘value’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/dvb-frontends/drxk_hard.c:6673:21: warning: ‘err’ may be used uninitialized [-Wmaybe-uninitialized]
> > 
> > # Test static-upstream:test-compile-all
> > Unable to build VIDEO_TEGRA
> > 
> > # Test static-upstream:test-smatch
> > 
> > drivers/media/usb/dvb-usb-v2/af9015.c:1168 af9015_rc_query() warn: missing error code? 'ret'
> > drivers/media/usb/dvb-usb-v2/af9015.c:1177 af9015_rc_query() warn: missing error code? 'ret'
> > drivers/staging/media/meson/vdec/vdec_1.c:239 vdec_1_start() warn: 'core->vdec_1_clk' from clk_prepare_enable() not released on lines: 239.
> > drivers/staging/media/meson/vdec/vdec_hevc.c:223 vdec_hevc_start() warn: 'core->vdec_hevc_clk' from clk_prepare_enable() not released on lines: 223.
> > drivers/staging/media/meson/vdec/vdec_hevc.c:223 vdec_hevc_start() warn: 'core->vdec_hevcf_clk' from clk_prepare_enable() not released on lines: 171,223.
> > drivers/media/platform/marvell/mmp-driver.c:257 mmpcam_probe() warn: missing unwind goto?
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> > drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2222 mxc_jpeg_probe() warn: missing unwind goto?
> > drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'
> > drivers/media/platform/mediatek/vpu/mtk_vpu.c:1033 mtk_vpu_resume() warn: 'vpu->clk' from clk_prepare() not released on lines: 1022.
> > drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
> > drivers/media/platform/mediatek/vcodec/venc/venc_h264_if.c:467 h264_encode_frame() warn: missing error code? 'ret'
> > drivers/media/usb/as102/as102_usb_drv.c:306 as102_usb_release() warn: can 'as102_dev' even be NULL?
> > drivers/media/i2c/ov7670.c:1844 ov7670_parse_dt() warn: missing error code? 'ret'
> > drivers/staging/media/ipu3/ipu3-dmamap.c:42 imgu_dmamap_alloc_buffer() warn: use 'gfp' here instead of GFP_KERNEL?
> > drivers/media/dvb-frontends/mb86a16.c:1514 mb86a16_send_diseqc_msg() warn: missing unwind goto?
> > drivers/media/platform/renesas/vsp1/vsp1_histo.c:153 histo_stop_streaming() warn: mixing irqsave and irq
> > drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'
> > drivers/media/platform/renesas/renesas-ceu.c:705 ceu_start_streaming() warn: can 'buf' even be NULL?
> > drivers/media/platform/rockchip/rga/rga.c:734 rga_enable_clocks() warn: 'rga->sclk' from clk_prepare_enable() not released on lines: 734.
> > drivers/media/pci/cx18/cx18-mailbox.c:833 cx18_vapi() error: we previously assumed 'cx' could be null (see line 832)
> > drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
> > drivers/media/dvb-frontends/sp887x.c:178 sp887x_initial_setup() error: __memcpy() '&buf[2]' too small (30 vs 16384)
> > drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1163 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1142,1149.
> > drivers/media/platform/st/sti/hva/hva-hw.c:412 hva_hw_probe() warn: 'hva->clk' from clk_prepare() not released on lines: 412.
> > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c:677 sun6i_subdev_notify_complete() warn: can 'sd' even be NULL?
> > drivers/media/platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c:193 sun6i_mipi_csi2_s_stream() warn: missing error code 'ret'
> > drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c:225 sun8i_a83t_mipi_csi2_s_stream() warn: missing error code 'ret'
> > drivers/media/platform/ti/davinci/vpbe.c:741 vpbe_initialize() warn: 'vpbe_dev->dac_clk' from clk_prepare_enable() not released on lines: 741.
> > drivers/media/platform/ti/davinci/vpbe_display.c:1152 vpbe_display_open() warn: missing error code? 'err'
> > drivers/media/pci/solo6x10/solo6x10-core.c:630 solo_pci_probe() warn: 'pdev->irq' from request_irq() not released on lines: 630.
> > drivers/media/pci/solo6x10/solo6x10-core.c:630 solo_pci_probe() warn: 'pdev' from pci_request_regions() not released on lines: 630.
> > drivers/media/pci/saa7134/saa7134-alsa.c:1186 alsa_card_saa7134_create() warn: 'dev->pci->irq' from request_irq() not released on lines: 1186.
> > drivers/media/pci/tw686x/tw686x-audio.c:62 tw686x_audio_irq() warn: can 'next' even be NULL?
> > 
> > # Test static-upstream:test-sparse
> > scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> > scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> > scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
> > drivers/input/touchscreen/sur40.c:424:55: warning: incorrect type in argument 2 (different base types)
> > drivers/input/touchscreen/sur40.c:424:55:    expected int key
> > drivers/input/touchscreen/sur40.c:424:55:    got restricted __le16 [usertype] blob_id
> > drivers/staging/media/meson/vdec/codec_vp9.c: In function ‘adapt_coef_probs.constprop’:
> > drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: ‘coef_node_start’ may be used uninitialized [-Wmaybe-uninitialized]
> >   1689 |                         coef_node_start = coef_node_start + 1;
> >        |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
> > drivers/staging/media/meson/vdec/codec_vp9.c:1551:19: note: ‘coef_node_start’ was declared here
> >   1551 |         int node, coef_node_start, coef_count_node_start;
> >        |                   ^~~~~~~~~~~~~~~
> > drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structures
> > 
> > # Test static-upstream:test-coccinelle
> > drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:516:11-29: WARNING: dma_alloc_coherent used in cfg_stm already zeroes out memory, so memset is not needed
> > drivers/media/usb/uvc/uvc_ctrl.c:1703:44-50: ERROR: invalid reference to the index variable of the iterator on line 1692
> > drivers/media/usb/uvc/uvc_ctrl.c:2035:17-23: ERROR: invalid reference to the index variable of the iterator on line 2019
> > drivers/media/v4l2-core/v4l2-async.c:300:23-30: ERROR: PTR_ERR applied after initialization to constant on line 288
> > drivers/media/dvb-frontends/tda18271c2dd.c:355:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> > drivers/media/dvb-frontends/tda18271c2dd.c:331:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
> > drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
> > 
> > # Test abi:pahole x86
> > /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
> >     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
> >        |                               ^~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
> >     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
> >        |                                       ^~~~~~~~~~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
> >     53 | struct v4l2_ctrl_av1_frame av1_frame;
> >        |                            ^~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
> >     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
> >        |                                 ^~~~~~~~~~~~~~
> > 
> > # Test abi:pahole arm
> > /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
> >     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
> >        |                               ^~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
> >     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
> >        |                                       ^~~~~~~~~~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
> >     53 | struct v4l2_ctrl_av1_frame av1_frame;
> >        |                            ^~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
> >     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
> >        |                                 ^~~~~~~~~~~~~~
> > 
> > # Test abi:pahole powerpc
> > /media-ci/testdata/pahole/pahole.c:51:31: error: storage size of ‘av1_sequence’ isn’t known
> >     51 | struct v4l2_ctrl_av1_sequence av1_sequence;
> >        |                               ^~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:52:39: error: storage size of ‘av1_tile_group_entry’ isn’t known
> >     52 | struct v4l2_ctrl_av1_tile_group_entry av1_tile_group_entry;
> >        |                                       ^~~~~~~~~~~~~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:53:28: error: storage size of ‘av1_frame’ isn’t known
> >     53 | struct v4l2_ctrl_av1_frame av1_frame;
> >        |                            ^~~~~~~~~
> > /media-ci/testdata/pahole/pahole.c:54:33: error: storage size of ‘av1_film_grain’ isn’t known
> >     54 | struct v4l2_ctrl_av1_film_grain av1_film_grain;
> >        |                                 ^~~~~~~~~~~~~~
> > 
> > # Test abi:abidump arm
> > WARNING: module version is not specified (-lver NUM)
> > 
> > # Test abi:abidump powerpc64
> > WARNING: module version is not specified (-lver NUM)
> > 
> > # Test media-patchstyle:test-valid-ancestor
> > ERROR: This code is not based on any of the branches: next fixes
> >         from git://linuxtv.org/media.git or https://gitlab.freedesktop.org/linux-media/media-committers.git.
> >         The output of media-ci will not be reliable, and the code will not
> >         land upstream as-is. Please rebase your code.
> > 
> > # Test checkpatch:./0001-media-mediatek-vcodec-Fix-VP8-stateless-decoder-smat.patch checkpatch
> > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b113bc7c0e83 ("media: mediatek: vcodec: Fix VP8 stateless decoder smatch warning")'
> > #7:
> > commit b113bc7c0e83b32f4dd2d291a2b6c4803e0a2c44 upstream.
> > 
> > total: 1 errors, 0 warnings, 0 checks, 21 lines checked
> > 
> > 
> > 
> > Please fix your series, and upload a new version. If you have a patchwork
> > account, do not forget to mark the current series as Superseded.
> > 
> > For more details, check the full report at:
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72987470/artifacts/report.htm .
> > 
> > 
> > 
> > Best regards, and Happy Hacking!
> > Media CI robot on behalf of the linux-media community.
> > 
> > ---
> > Check the latest rules for contributing your patches at:
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> > 
> > If you believe that the CI is wrong, kindly open an issue at
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > to this message.
> > 
> >
diff mbox series

Patch

diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c
index e1fe2603e92e..22d8f178b04d 100644
--- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c
+++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp8_req_if.c
@@ -336,14 +336,18 @@  static int vdec_vp8_slice_decode(void *h_vdec, struct mtk_vcodec_mem *bs,
 	src_buf_info = container_of(bs, struct mtk_video_dec_buf, bs_buffer);
 
 	fb = inst->ctx->dev->vdec_pdata->get_cap_buffer(inst->ctx);
-	dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);
+	if (!fb) {
+		mtk_vcodec_err(inst, "fb buffer is NULL");
+		return -ENOMEM;
+	}
 
-	y_fb_dma = fb ? (u64)fb->base_y.dma_addr : 0;
+	dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);
+	y_fb_dma = fb->base_y.dma_addr;
 	if (inst->ctx->q_data[MTK_Q_DATA_DST].fmt->num_planes == 1)
 		c_fb_dma = y_fb_dma +
 			inst->ctx->picinfo.buf_w * inst->ctx->picinfo.buf_h;
 	else
-		c_fb_dma = fb ? (u64)fb->base_c.dma_addr : 0;
+		c_fb_dma = fb->base_c.dma_addr;
 
 	inst->vsi->dec.bs_dma = (u64)bs->dma_addr;
 	inst->vsi->dec.bs_sz = bs->size;