| Message ID | 20250327103918.1.I704cb6f738208386a0d431d355169c6fdf0f51bc@changeid (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | UPSTREAM: media: platform: cros-ec: Add Moxie to the match table | expand |
On 27/03/2025 03:39, Ken Lin wrote: > The Google Moxie device uses the same approach as the Google Brask > which enables the HDMI CEC via the cros-ec-cec driver. > > Hans Verkuil <hverkuil-cisco@xs4all.nl>, > Mauro Carvalho Chehab <mchehab@kernel.org>, > Reka Norman <rekanorman@chromium.org>, > Stefan Adolfsson <sadolfsson@chromium.org>, No clue what's that... and I don't get why you call it upstream. Follow standard upstreaming processes and guides. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters If this is for your own projects, then obviously NAK. Best regards, Krzysztof
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c index 12b73ea0f31d..1de5799a0579 100644 --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c @@ -329,6 +329,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = { { "Google", "Dexi", "0000:00:02.0", port_db_conns }, /* Google Dita */ { "Google", "Dita", "0000:00:02.0", port_db_conns }, + /* Google Moxie */ + { "Google", "Moxie", "0000:00:02.0", port_b_conns }, }; static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
The Google Moxie device uses the same approach as the Google Brask which enables the HDMI CEC via the cros-ec-cec driver. Hans Verkuil <hverkuil-cisco@xs4all.nl>, Mauro Carvalho Chehab <mchehab@kernel.org>, Reka Norman <rekanorman@chromium.org>, Stefan Adolfsson <sadolfsson@chromium.org>, Signed-off-by: Ken Lin <kenlin5@quanta.corp-partner.google.com> --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++ 1 file changed, 2 insertions(+)