| Message ID | 20250418071823.8756-2-hardevsinh.palaniya@siliconsignals.io (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] media: atomisp: Remove compat ioctl32 header file | expand |
On Fri, Apr 18, 2025 at 10:19 AM Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> wrote: > > Since its definition was deleted in a previous patch[1] This is odd. Previous patch from you? The Link is to Arnd's one, which is quite too old to be "previous patch". > and there are no remaining users of this function in > the codebase. > Link[1]:https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/ > > Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> Same comment as per previous patch. > --- Overall I don't know why it's a separate patch and can't be squashed with the first one. Whatever, it's staging and it's fine that we get rid of dead code.
diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.h b/drivers/staging/media/atomisp/pci/atomisp_ioctl.h index 4feaa0338cb4..57f608f9db56 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.h +++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.h @@ -33,8 +33,4 @@ void atomisp_stop_streaming(struct vb2_queue *vq); extern const struct v4l2_ioctl_ops atomisp_ioctl_ops; -/* compat_ioctl for 32bit userland app and 64bit kernel */ -long atomisp_compat_ioctl32(struct file *file, - unsigned int cmd, unsigned long arg); - #endif /* __ATOMISP_IOCTL_H__ */
Since its definition was deleted in a previous patch[1] and there are no remaining users of this function in the codebase. Link[1]:https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/ Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io> --- drivers/staging/media/atomisp/pci/atomisp_ioctl.h | 4 ---- 1 file changed, 4 deletions(-)