From patchwork Thu Dec 10 14:29:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7819361 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D1B65BEEE1 for ; Thu, 10 Dec 2015 14:30:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E75B1205B4 for ; Thu, 10 Dec 2015 14:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B99772058E for ; Thu, 10 Dec 2015 14:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbLJOa0 (ORCPT ); Thu, 10 Dec 2015 09:30:26 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:51797 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbbLJOaZ (ORCPT ); Thu, 10 Dec 2015 09:30:25 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0Lla0h-1ahTAt3R4x-00bM95; Thu, 10 Dec 2015 15:29:44 +0100 From: Arnd Bergmann To: mchehab@osg.samsung.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Sekhar Nori , Kevin Hilman Subject: [PATCH] [media] staging/davinci_vfpe: allow modular build Date: Thu, 10 Dec 2015 15:29:38 +0100 Message-ID: <2029571.PWO4DcqdUl@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:e3z32UbtdWO0ZihUn2iVH35thWPYMU5T/HwVdKOm854ueu/lDFg 4OO7VYMptL7XOqjj/Ygr78aZjXC5dJ5WTOfnr3eJ9EKP03S/y6tva1dn8Be3Or+lOSc0Y2B s2PlOb269alHOCQA8JRtu9GaqvCua99G0X+dHJiAKIeToRyBYqLVMfwm1Il9q29tlLzllL9 PWygTkfaPYpciZTzK/1ZQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:DF5lCBhMNdY=:jEUjlKEyhxuZaek+Q3qPPL grTG6cANwvkRGxqYF+F9JD5OwQlk/Xxmw+yZEB8WgEGX1CNNX4ZkOcEg96c1JmdeENp3lgZpY mE7o8/UV6PYepkAmHHHJf5aThNsu3TEX8UW3oPc+nS6QnF8fwTjLHlF8fsAFY6gfWvhpnHvm8 6PhmZRcThBjvRqBni6udfyV4F5OyhoUCYe32PnQqj4hQZwnKKIvKGg01vz0AUoGVqLBcUvleV Op8q0DUQqQO4ujiV0h8eqYbag1BIfL2FEUvnYktV6M1N380qr85xuUAFHg0AIj6mojbwSD32s k3/4cEsWS6w/w4+7Ukl2666Iby3cmjIAConEZHx1H2SsZI5p7LDR1fVBMFfMvHLA0bGxVcwhu 8MSQCDQvrFI3rHtefDJMqv+aezNN0M3BOovc+MHtXR0T7p+YEdmAId1QKKYUL93l4Eq534dvk CyMnhdC5L5OLRqoRlgJxoz/u1jdalma41lMek8GU0w52DPi5kv8cZZxU2JQIZSy+bdOJv3s30 DiUAQF4i8sywFAWe1IzWxYCukvEw0Up2IQBXbopn4F8mIUjhO/vjkBImnh6oecctiY+Z3Fk/+ dSWEAd7NoroWaqu1fUqsiWqoJzyZOMDlkeGwrAvfNt29JA3FNZ0MazAVuqVlNSYr7acRrX0hw o4sYQ28zbuLzq6R87XXenv788AsD5LyLyPg2xuD6pM38FRssk96pPaQHsoHaY1Vy4GwPU3/jT cnVT/LJvomrOKCbQ Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It has never been possible to actually build this driver as a loadable module, only built-in because the Makefile attempts to build each file into its own module and fails: ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined! ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined! ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined! ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined! It took a long time to catch this bug with randconfig builds because at least 14 other Kconfig symbols have to be enabled in order to configure this one. The solution is really easy: this patch changes the Makefile to link all files into one module. Signed-off-by: Arnd Bergmann --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile index c64515c644cd..3019c9ecd548 100644 --- a/drivers/staging/media/davinci_vpfe/Makefile +++ b/drivers/staging/media/davinci_vpfe/Makefile @@ -1,3 +1,5 @@ -obj-$(CONFIG_VIDEO_DM365_VPFE) += \ +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o + +davinci-vfpe-objs := \ dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \ dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o