diff mbox

[RFCv2,API,14/28] DocBook: clarify that sequence is also set for output devices.

Message ID 218a8f843734b9b2572842bc817ed36970931c24.1347023744.git.hans.verkuil@cisco.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hans Verkuil Sept. 7, 2012, 1:29 p.m. UTC
From: Hans Verkuil <hans.verkuil@cisco.com>

It was not entirely obvious that the sequence count should also
be set for output devices. Also made it more explicit that this
sequence counter counts frames, not fields.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
 Documentation/DocBook/media/v4l/io.xml |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sylwester Nawrocki Sept. 7, 2012, 8:18 p.m. UTC | #1
On 09/07/2012 03:29 PM, Hans Verkuil wrote:
> From: Hans Verkuil<hans.verkuil@cisco.com>
>
> It was not entirely obvious that the sequence count should also
> be set for output devices. Also made it more explicit that this
> sequence counter counts frames, not fields.
>
> Signed-off-by: Hans Verkuil<hans.verkuil@cisco.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Sept. 13, 2012, 2:28 a.m. UTC | #2
Hi Hans,

Thanks for the patch.

On Friday 07 September 2012 15:29:14 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> It was not entirely obvious that the sequence count should also
> be set for output devices. Also made it more explicit that this
> sequence counter counts frames, not fields.
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
>  Documentation/DocBook/media/v4l/io.xml |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/io.xml
> b/Documentation/DocBook/media/v4l/io.xml index b680d66..d1c2369 100644
> --- a/Documentation/DocBook/media/v4l/io.xml
> +++ b/Documentation/DocBook/media/v4l/io.xml
> @@ -617,8 +617,8 @@ field is independent of the
> <structfield>timestamp</structfield> and <entry>__u32</entry>
>  	    <entry><structfield>sequence</structfield></entry>
>  	    <entry></entry>
> -	    <entry>Set by the driver, counting the frames in the
> -sequence.</entry>
> +	    <entry>Set by the driver, counting the frames (not fields!) in the
> +sequence. This field is set for both input and output devices.</entry>

Nitpicking, s/in the sequence/in sequence/ ?

>  	  </row>
>  	  <row>
>  	    <entry spanname="hspan"><para>In <link
Hans Verkuil Sept. 13, 2012, 10:48 a.m. UTC | #3
On Thu 13 September 2012 04:28:41 Laurent Pinchart wrote:
> Hi Hans,
> 
> Thanks for the patch.
> 
> On Friday 07 September 2012 15:29:14 Hans Verkuil wrote:
> > From: Hans Verkuil <hans.verkuil@cisco.com>
> > 
> > It was not entirely obvious that the sequence count should also
> > be set for output devices. Also made it more explicit that this
> > sequence counter counts frames, not fields.
> > 
> > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> > ---
> >  Documentation/DocBook/media/v4l/io.xml |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/DocBook/media/v4l/io.xml
> > b/Documentation/DocBook/media/v4l/io.xml index b680d66..d1c2369 100644
> > --- a/Documentation/DocBook/media/v4l/io.xml
> > +++ b/Documentation/DocBook/media/v4l/io.xml
> > @@ -617,8 +617,8 @@ field is independent of the
> > <structfield>timestamp</structfield> and <entry>__u32</entry>
> >  	    <entry><structfield>sequence</structfield></entry>
> >  	    <entry></entry>
> > -	    <entry>Set by the driver, counting the frames in the
> > -sequence.</entry>
> > +	    <entry>Set by the driver, counting the frames (not fields!) in the
> > +sequence. This field is set for both input and output devices.</entry>
> 
> Nitpicking, s/in the sequence/in sequence/ ?

Will fix.

Regards,

	Hans

> 
> >  	  </row>
> >  	  <row>
> >  	    <entry spanname="hspan"><para>In <link
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/DocBook/media/v4l/io.xml b/Documentation/DocBook/media/v4l/io.xml
index b680d66..d1c2369 100644
--- a/Documentation/DocBook/media/v4l/io.xml
+++ b/Documentation/DocBook/media/v4l/io.xml
@@ -617,8 +617,8 @@  field is independent of the <structfield>timestamp</structfield> and
 	    <entry>__u32</entry>
 	    <entry><structfield>sequence</structfield></entry>
 	    <entry></entry>
-	    <entry>Set by the driver, counting the frames in the
-sequence.</entry>
+	    <entry>Set by the driver, counting the frames (not fields!) in the
+sequence. This field is set for both input and output devices.</entry>
 	  </row>
 	  <row>
 	    <entry spanname="hspan"><para>In <link