diff mbox

[1/4] media: radio: allow building ISA drivers with COMPILE_TEST

Message ID 333f43d5373f6f821c424ccabce3b9b1fa180921.1524227382.git.mchehab@s-opensource.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab April 20, 2018, 12:32 p.m. UTC 
Several radio devices only build on i386, because they depend
on ISA. Allow them to build on other archs by adding a
COMPILE_TEST check.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/media/radio/Kconfig | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)

Comments

kernel test robot April 22, 2018, 3:41 p.m. UTC | #1 
Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-radio-allow-building-ISA-drivers-with-COMPILE_TEST/20180422-180508
base:   git://linuxtv.org/media_tree.git master
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void)
--
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using sizeof(void)
--
>> drivers/media/radio/radio-sf16fmr2.c:169:25: sparse: expression using sizeof(void)
   drivers/media/radio/radio-sf16fmr2.c:171:24: sparse: expression using sizeof(void)
--
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)
>> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using sizeof(void)

vim +108 drivers/media/radio/radio-isa.c

137c579c Hans Verkuil 2012-02-03   98  
137c579c Hans Verkuil 2012-02-03   99  static int radio_isa_s_frequency(struct file *file, void *priv,
b530a447 Hans Verkuil 2013-03-19  100  				const struct v4l2_frequency *f)
137c579c Hans Verkuil 2012-02-03  101  {
137c579c Hans Verkuil 2012-02-03  102  	struct radio_isa_card *isa = video_drvdata(file);
b530a447 Hans Verkuil 2013-03-19  103  	u32 freq = f->frequency;
137c579c Hans Verkuil 2012-02-03  104  	int res;
137c579c Hans Verkuil 2012-02-03  105  
137c579c Hans Verkuil 2012-02-03  106  	if (f->tuner != 0 || f->type != V4L2_TUNER_RADIO)
137c579c Hans Verkuil 2012-02-03  107  		return -EINVAL;
b530a447 Hans Verkuil 2013-03-19 @108  	freq = clamp(freq, FREQ_LOW, FREQ_HIGH);
b530a447 Hans Verkuil 2013-03-19  109  	res = isa->drv->ops->s_frequency(isa, freq);
137c579c Hans Verkuil 2012-02-03  110  	if (res == 0)
b530a447 Hans Verkuil 2013-03-19  111  		isa->freq = freq;
137c579c Hans Verkuil 2012-02-03  112  	return res;
137c579c Hans Verkuil 2012-02-03  113  }
137c579c Hans Verkuil 2012-02-03  114  

:::::: The code at line 108 was first introduced by commit
:::::: b530a447bb588fdf43fdf4eb909e4ee1921d47ac [media] v4l2: add const to argument of write-only s_frequency ioctl

:::::: TO: Hans Verkuil <hans.verkuil@cisco.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 2ed539f9eb87..d363726e9eb1 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -231,7 +231,7 @@  source "drivers/media/radio/wl128x/Kconfig"
 
 menuconfig V4L_RADIO_ISA_DRIVERS
 	bool "ISA radio devices"
-	depends on ISA
+	depends on ISA || COMPILE_TEST
 	default n
 	---help---
 	  Say Y here to enable support for these ISA drivers.
@@ -239,12 +239,13 @@  menuconfig V4L_RADIO_ISA_DRIVERS
 if V4L_RADIO_ISA_DRIVERS
 
 config RADIO_ISA
-	depends on ISA
+	depends on ISA || COMPILE_TEST
 	tristate
 
 config RADIO_CADET
 	tristate "ADS Cadet AM/FM Tuner"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	---help---
 	  Choose Y here if you have one of these AM/FM radio cards, and then
 	  fill in the port address below.
@@ -254,8 +255,8 @@  config RADIO_CADET
 
 config RADIO_RTRACK
 	tristate "AIMSlab RadioTrack (aka RadioReveal) support"
-	depends on ISA && VIDEO_V4L2
-	select RADIO_ISA
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	---help---
 	  Choose Y here if you have one of these FM radio cards, and then fill
 	  in the port address below.
@@ -285,7 +286,8 @@  config RADIO_RTRACK_PORT
 
 config RADIO_RTRACK2
 	tristate "AIMSlab RadioTrack II support"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have this FM radio card, and then fill in the
@@ -308,7 +310,8 @@  config RADIO_RTRACK2_PORT
 
 config RADIO_AZTECH
 	tristate "Aztech/Packard Bell Radio"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have one of these FM radio cards, and then fill
@@ -328,7 +331,8 @@  config RADIO_AZTECH_PORT
 
 config RADIO_GEMTEK
 	tristate "GemTek Radio card (or compatible) support"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have this FM radio card, and then fill in the
@@ -382,7 +386,8 @@  config RADIO_MIROPCM20
 
 config RADIO_SF16FMI
 	tristate "SF16-FMI/SF16-FMP/SF16-FMD Radio"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	---help---
 	  Choose Y here if you have one of these FM radio cards.
 
@@ -391,7 +396,8 @@  config RADIO_SF16FMI
 
 config RADIO_SF16FMR2
 	tristate "SF16-FMR2/SF16-FMD2 Radio"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_TEA575X
 	---help---
 	  Choose Y here if you have one of these FM radio cards.
@@ -401,7 +407,8 @@  config RADIO_SF16FMR2
 
 config RADIO_TERRATEC
 	tristate "TerraTec ActiveRadio ISA Standalone"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have this FM radio card.
@@ -415,7 +422,8 @@  config RADIO_TERRATEC
 
 config RADIO_TRUST
 	tristate "Trust FM radio card"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	help
 	  This is a driver for the Trust FM radio cards. Say Y if you have
@@ -438,7 +446,8 @@  config RADIO_TRUST_PORT
 
 config RADIO_TYPHOON
 	tristate "Typhoon Radio (a.k.a. EcoRadio)"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have one of these FM radio cards, and then fill
@@ -472,7 +481,8 @@  config RADIO_TYPHOON_MUTEFREQ
 
 config RADIO_ZOLTRIX
 	tristate "Zoltrix Radio"
-	depends on ISA && VIDEO_V4L2
+	depends on ISA || COMPILE_TEST
+	depends on VIDEO_V4L2
 	select RADIO_ISA
 	---help---
 	  Choose Y here if you have one of these FM radio cards, and then fill