From patchwork Thu Dec 23 19:40:22 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sri Deevi X-Patchwork-Id: 430681 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBNJw5IO027188 for ; Thu, 23 Dec 2010 19:58:06 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902Ab0LWT5u (ORCPT ); Thu, 23 Dec 2010 14:57:50 -0500 Received: from cnxtsmtp2.conexant.com ([198.62.9.253]:39501 "EHLO cnxtsmtp2.conexant.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738Ab0LWT5t convert rfc822-to-8bit (ORCPT ); Thu, 23 Dec 2010 14:57:49 -0500 X-WSS-ID: 0LDWBZC-03-29N-03 X-M-MSG: Received: from nbwsmx1.bbnet.ad (nbwsmx1.bbnet.ad [157.152.183.211]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by cnxtsmtp2.conexant.com (Tumbleweed MailGate 3.7.1) with ESMTP id 2581D2508FB for ; Thu, 23 Dec 2010 11:40:23 -0800 (PST) Received: from NBWSMX1.bbnet.ad ([127.0.0.1]) by nbwsmx1.bbnet.ad with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Dec 2010 11:40:24 -0800 Received: from cnxthub1.bbnet.ad ([157.152.180.131]) by NBWSMX1.bbnet.ad over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 23 Dec 2010 11:40:24 -0800 Received: from NBMBX01.bbnet.ad ([fe80:0000:0000:0000:3d51:55f9:109.11.247.214]) by cnxthub1.bbnet.ad ([157.152.180.131]) with mapi; Thu, 23 Dec 2010 11:40:23 -0800 From: "Sri Deevi" To: "'Dan Carpenter'" cc: "'Andy Walls'" , "linux-media@vger.kernel.org" , "mchehab@infradead.org" Date: Thu, 23 Dec 2010 11:40:22 -0800 Subject: RE: [patch] [media] cx231xxx: fix typo in saddr_len check Thread-Topic: [patch] [media] cx231xxx: fix typo in saddr_len check Thread-Index: Acui2Q+mkQ0IGQrQStmhCp48R8mCugAAB/2A Message-ID: <34B38BE41EDBA046A4AFBB591FA31132024A7F38D1@NBMBX01.bbnet.ad> References: <20101223164347.GA16612@bicker> <1293129292.24752.9.camel@morgan.silverblock.net> <34B38BE41EDBA046A4AFBB591FA311320249B057C6@NBMBX01.bbnet.ad> <20101223193853.GN1936@bicker> In-Reply-To: <20101223193853.GN1936@bicker> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginalArrivalTime: 23 Dec 2010 19:40:24.0541 (UTC) FILETIME=[3E3450D0:01CBA2D9] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Thu, 23 Dec 2010 19:58:06 +0000 (UTC) diff --git a/drivers/media/video/cx231xx/cx231xx-core.c b/drivers/media/video/cx231xx/cx231xx-core.c index 44d124c..7d62d58 100644 --- a/drivers/media/video/cx231xx/cx231xx-core.c +++ b/drivers/media/video/cx231xx/cx231xx-core.c @@ -1515,7 +1515,7 @@ int cx231xx_read_i2c_master(struct cx231xx *dev, u8 dev_addr, u16 saddr, if (saddr_len == 0) saddr = 0; - else if (saddr_len == 0) + else if (saddr_len == 1) saddr &= 0xff; /* prepare xfer_data struct */ @@ -1566,7 +1566,7 @@ int cx231xx_write_i2c_master(struct cx231xx *dev, u8 dev_addr, u16 saddr, if (saddr_len == 0) saddr = 0; - else if (saddr_len == 0) + else if (saddr_len == 1) saddr &= 0xff; /* prepare xfer_data struct */ @@ -1600,7 +1600,7 @@ int cx231xx_read_i2c_data(struct cx231xx *dev, u8 dev_addr, u16 saddr, if (saddr_len == 0) saddr = 0; - else if (saddr_len == 0) + else if (saddr_len == 1) saddr &= 0xff; /* prepare xfer_data struct */ @@ -1641,7 +1641,7 @@ int cx231xx_write_i2c_data(struct cx231xx *dev, u8 dev_addr, u16 saddr, if (saddr_len == 0) saddr = 0; - else if (saddr_len == 0) + else if (saddr_len == 1) saddr &= 0xff; /* prepare xfer_data struct */