From patchwork Tue Jan 25 21:38:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sri Deevi X-Patchwork-Id: 507091 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p0PLtsp2008124 for ; Tue, 25 Jan 2011 21:55:54 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753720Ab1AYVzh (ORCPT ); Tue, 25 Jan 2011 16:55:37 -0500 Received: from cnxtsmtp1.conexant.com ([198.62.9.252]:35759 "EHLO Cnxtsmtp1.conexant.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753685Ab1AYVze convert rfc822-to-8bit (ORCPT ); Tue, 25 Jan 2011 16:55:34 -0500 X-WSS-ID: 0LFLLG4-04-3W3-03 X-M-MSG: Received: from nbwsmx2.bbnet.ad (nbwsmx2.bbnet.ad [157.152.183.212]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by Cnxtsmtp1.conexant.com (Tumbleweed MailGate 3.7.1) with ESMTP id 226E712E600; Tue, 25 Jan 2011 13:38:27 -0800 (PST) Received: from NBWSMX2.bbnet.ad ([127.0.0.1]) by nbwsmx2.bbnet.ad with Microsoft SMTPSVC(6.0.3790.4675); Tue, 25 Jan 2011 13:38:28 -0800 Received: from cnxthub2.bbnet.ad ([157.152.180.132]) by NBWSMX2.bbnet.ad over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 25 Jan 2011 13:38:28 -0800 Received: from NBMBX01.bbnet.ad ([fe80:0000:0000:0000:49cc:d6ea:184.37.222.21]) by cnxthub2.bbnet.ad ([157.152.180.132]) with mapi; Tue, 25 Jan 2011 13:38:28 -0800 From: "Sri Deevi" To: "'Peter Huewe'" , "Mauro Carvalho Chehab" cc: "Devin Heitmueller" , "Stephen Rothwell" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Date: Tue, 25 Jan 2011 13:38:27 -0800 Subject: RE: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer Thread-Topic: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer Thread-Index: Acu8z+iHnR5nVR8VR5msh+but7OQ3AACCE0A Message-ID: <34B38BE41EDBA046A4AFBB591FA31132024B3638FC@NBMBX01.bbnet.ad> References: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> In-Reply-To: <1295987932-19785-1-git-send-email-peterhuewe@gmx.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginalArrivalTime: 25 Jan 2011 21:38:28.0940 (UTC) FILETIME=[347790C0:01CBBCD8] Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 25 Jan 2011 21:56:06 +0000 (UTC) diff --git a/drivers/media/video/cx231xx/cx231xx-417.c b/drivers/media/video/cx231xx/cx231xx-417.c index fc9526a..f8f0e59 100644 --- a/drivers/media/video/cx231xx/cx231xx-417.c +++ b/drivers/media/video/cx231xx/cx231xx-417.c @@ -942,13 +942,13 @@ static int cx231xx_load_firmware(struct cx231xx *dev) p_current_fw = vmalloc(1884180 * 4); p_fw = p_current_fw; - if (p_current_fw == 0) { + if (p_current_fw == NULL) { dprintk(2, "FAIL!!!\n"); return -1; } p_buffer = vmalloc(4096); - if (p_buffer == 0) { + if (p_buffer == NULL) { dprintk(2, "FAIL!!!\n"); return -1; } diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c b/drivers/media/video/cx231xx/cx231xx-cards.c index 588f3e8..5b9b5f4 100644 --- a/drivers/media/video/cx231xx/cx231xx-cards.c +++ b/drivers/media/video/cx231xx/cx231xx-cards.c @@ -357,19 +357,19 @@ struct cx231xx_board cx231xx_boards[] = { .type = CX231XX_VMUX_TELEVISION, .vmux = CX231XX_VIN_3_1, .amux = CX231XX_AMUX_VIDEO, - .gpio = 0, + .gpio = NULL, }, { .type = CX231XX_VMUX_COMPOSITE1, .vmux = CX231XX_VIN_2_1, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, }, { .type = CX231XX_VMUX_SVIDEO, .vmux = CX231XX_VIN_1_1 | (CX231XX_VIN_1_2 << 8) | CX25840_SVIDEO_ON, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, } }, }, [CX231XX_BOARD_HAUPPAUGE_USBLIVE2] = { @@ -386,14 +386,14 @@ struct cx231xx_board cx231xx_boards[] = { .type = CX231XX_VMUX_COMPOSITE1, .vmux = CX231XX_VIN_2_1, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, }, { .type = CX231XX_VMUX_SVIDEO, .vmux = CX231XX_VIN_1_1 | (CX231XX_VIN_1_2 << 8) | CX25840_SVIDEO_ON, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, } }, }, [CX231XX_BOARD_PV_PLAYTV_USB_HYBRID] = { @@ -420,19 +420,19 @@ struct cx231xx_board cx231xx_boards[] = { .type = CX231XX_VMUX_TELEVISION, .vmux = CX231XX_VIN_3_1, .amux = CX231XX_AMUX_VIDEO, - .gpio = 0, + .gpio = NULL, }, { .type = CX231XX_VMUX_COMPOSITE1, .vmux = CX231XX_VIN_2_1, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, }, { .type = CX231XX_VMUX_SVIDEO, .vmux = CX231XX_VIN_1_1 | (CX231XX_VIN_1_2 << 8) | CX25840_SVIDEO_ON, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, } }, }, };