From patchwork Tue Nov 17 16:17:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7638911 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DCC4F9F1D3 for ; Tue, 17 Nov 2015 16:18:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 17C4320148 for ; Tue, 17 Nov 2015 16:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 275DB2051C for ; Tue, 17 Nov 2015 16:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbbKQQS2 (ORCPT ); Tue, 17 Nov 2015 11:18:28 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:54546 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587AbbKQQS0 (ORCPT ); Tue, 17 Nov 2015 11:18:26 -0500 X-Greylist: delayed 18887 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Nov 2015 11:18:25 EST Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0MNvNj-1a05T33x19-007WzD; Tue, 17 Nov 2015 17:17:43 +0100 From: Arnd Bergmann To: linux-media@vger.kernel.org, Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Antti Palosaari Subject: [PATCH] [MEDIA] dvb: usb: fix dib3000mc dependencies Date: Tue, 17 Nov 2015 17:17:39 +0100 Message-ID: <3984729.n55BH9Zr8c@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:HVoin34luXsQtGxNav+wboZVoXzNVtmhxKSrijy6THDmhE8P6/e XsG9rApzgoAvsy+nlYvYnpkxX+BD5vMYkQyF22X+neLy1gvbYPapUvmj4oCipkNtsXn5b+N OdLWwZpgTUmHVb4BSVennBnthiX0lz/+6nobdbhyT0jOXsSi97aUUAEjlUxjayP/Qv8zn5N jwQXv8VjSxLYY6cEHVCnw== X-UI-Out-Filterresults: notjunk:1; V01:K0:YG6Uq0K5vtM=:Zbn3+fuzJfiK2w/mB7M4rl jRAyRv1aOcjjQxnP+qDsQCjGzqVkIcTmifMuVMwZkbqMJvXOAK66auqNG+oAlJqUZ6JRENAWw Vmt8S/kWara76nKaxaxCxgMGSqoDa40hqLbjrTwmfNm08AQDEcWUkQ41gU/LVz+bPG2EgUhnp Im4FZbAe2FAgy3AKBl8FQNEz67qH+8oaGQ5pGsgaTvdnX0bgkCeS4UqXFsxI4CUSkM/NHnlYd ujTPGOsovcRGV5Z3nyatWkGmYITy0uK/3xGWTuPvGo1vtB1vVmYq/DfxoK4/ctQ20ZdJAXCb9 hqZQ+RkIBrIl9asGRfESw6s9siTckylPEUAh2W6xdN+xNfGIYl5YmEnpiSiPASVEa/JoY54Ik T5G85B+CdW5sDURO9cH8ZpRDoL0Ixarljn2l1hefA6LxcQGjWpQXXklreeLCXvFveLMWMsyH9 JvNiZRzx/dqrGWRb30WAKXRB1FekSn75p/ClJCLYJGkqvw+7pEbz+RpmYOVEU9rJUaD32PoHe jyrgC9ndlVSzDIvNcrvoEjBPm5V+Q7FywRHp0IICHsLlz++Ys67qbiUzsb1xK1CPn9cGi7gsB 5S+Je6G+5CQi8Wwtrof26j9wVZWlASdKusRVUA36aCY4n5FQFgKF6ipC7xn1oQuSNRcjmBH2Y luCQjFCe/lxEZVR4yjQjMBfBIMc8iiK9S7fDoXUWLkDiT6gszeft8FXnj6EnixyNjufZS9man BDUX/VIWkEnJ6OQV Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The dibusb_read_eeprom_byte function is defined in dibusb-common.c, but that file is not compiled for CONFIG_DVB_USB_DIBUSB_MB as it is for the other driver using the common functions, so we can get a link error: drivers/built-in.o: In function `dibusb_dib3000mc_tuner_attach': (.text+0x2c5124): undefined reference to `dibusb_read_eeprom_byte' (.text+0x2c5134): undefined reference to `dibusb_read_eeprom_byte' This changes the Makefile to treat the file like all the others in this directory, and enforce building dvb-usb-dibusb-common.o as a dependency. Signed-off-by: Arnd Bergmann --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/usb/dvb-usb/Makefile b/drivers/media/usb/dvb-usb/Makefile index 8da26352f73b..048ab0b6c36d 100644 --- a/drivers/media/usb/dvb-usb/Makefile +++ b/drivers/media/usb/dvb-usb/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_DVB_USB_DTT200U) += dvb-usb-dtt200u.o dvb-usb-dibusb-common-objs := dibusb-common.o dvb-usb-dibusb-mc-common-objs := dibusb-mc-common.o -obj-$(CONFIG_DVB_USB_DIB3000MC) += dvb-usb-dibusb-mc-common.o +obj-$(CONFIG_DVB_USB_DIB3000MC) += dvb-usb-dibusb-common.o dvb-usb-dibusb-mc-common.o dvb-usb-a800-objs := a800.o obj-$(CONFIG_DVB_USB_A800) += dvb-usb-dibusb-common.o dvb-usb-a800.o