| Message ID | 4293d53b747388a65ea06382e2041ae6322ecd89.1637573097.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Address some clang W=1 warnings | expand |
Hi Mauro, Thank you for the patch. On Mon, Nov 22, 2021 at 09:26:11AM +0000, Mauro Carvalho Chehab wrote: > This function is only used for debugging purposes. When DEBUG > is disabled, it becomes unused, causing a clang warning with W=1. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/10] at: https://lore.kernel.org/all/cover.1637573097.git.mchehab+huawei@kernel.org/ > > drivers/media/platform/omap3isp/isp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index 6de377ce281d..4c937f3f323e 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -476,7 +476,8 @@ void omap3isp_hist_dma_done(struct isp_device *isp) > } > } > > -static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus) > +static inline void __maybe_unused isp_isr_dbg(struct isp_device *isp, > + u32 irqstatus) > { > static const char *name[] = { > "CSIA_IRQ",
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 6de377ce281d..4c937f3f323e 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -476,7 +476,8 @@ void omap3isp_hist_dma_done(struct isp_device *isp) } } -static inline void isp_isr_dbg(struct isp_device *isp, u32 irqstatus) +static inline void __maybe_unused isp_isr_dbg(struct isp_device *isp, + u32 irqstatus) { static const char *name[] = { "CSIA_IRQ",
This function is only used for debugging purposes. When DEBUG is disabled, it becomes unused, causing a clang warning with W=1. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/10] at: https://lore.kernel.org/all/cover.1637573097.git.mchehab+huawei@kernel.org/ drivers/media/platform/omap3isp/isp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)