| Message ID | 497342D3.7050903@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Sun, 18 Jan 2009 15:55:15 +0100 Roel Kluin <roel.kluin@gmail.com> wrote: > Is this correct? No, it isn't. There's no sense on a negative value for a card. > --------------->8----------8<---------------- > make card signed > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c > index ef9bf00..7c7a96c 100644 > --- a/drivers/media/video/em28xx/em28xx-cards.c > +++ b/drivers/media/video/em28xx/em28xx-cards.c > @@ -47,7 +47,7 @@ static unsigned int disable_ir; > module_param(disable_ir, int, 0444); > MODULE_PARM_DESC(disable_ir, "disable infrared remote support"); > > -static unsigned int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET }; > +static int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET }; > module_param_array(card, int, NULL, 0444); > MODULE_PARM_DESC(card, "card type"); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c index ef9bf00..7c7a96c 100644 --- a/drivers/media/video/em28xx/em28xx-cards.c +++ b/drivers/media/video/em28xx/em28xx-cards.c @@ -47,7 +47,7 @@ static unsigned int disable_ir; module_param(disable_ir, int, 0444); MODULE_PARM_DESC(disable_ir, "disable infrared remote support"); -static unsigned int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET }; +static int card[] = {[0 ... (EM28XX_MAXBOARDS - 1)] = UNSET }; module_param_array(card, int, NULL, 0444); MODULE_PARM_DESC(card, "card type");
Is this correct? --------------->8----------8<---------------- make card signed Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html