From patchwork Thu Jul 28 19:38:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 1017572 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6SJd8kF009300 for ; Thu, 28 Jul 2011 19:39:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678Ab1G1TjH (ORCPT ); Thu, 28 Jul 2011 15:39:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55634 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740Ab1G1TjE (ORCPT ); Thu, 28 Jul 2011 15:39:04 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6SJcw0N019575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 28 Jul 2011 15:38:58 -0400 Received: from [10.11.8.21] (vpn-8-21.rdu.redhat.com [10.11.8.21]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6SJctVO008665; Thu, 28 Jul 2011 15:38:56 -0400 Message-ID: <4E31BACE.2060809@redhat.com> Date: Thu, 28 Jul 2011 16:38:54 -0300 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: Alina Friedrichsen CC: linux-media@vger.kernel.org, rglowery@exemail.com.au Subject: Re: [PATCH v3] tuner_xc2028: Allow selection of the frequency adjustment code for XC3028 References: <20110722183552.169950@gmx.net> In-Reply-To: <20110722183552.169950@gmx.net> X-Enigmail-Version: 1.2 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 28 Jul 2011 19:39:10 +0000 (UTC) Alina, Em 22-07-2011 15:35, Alina Friedrichsen escreveu: > Since many, many kernel releases my Hauppauge WinTV HVR-1400 doesn't work > anymore, and nobody feels responsible to fix it. Could you please check if the enclosed patch fixes the tuner issue? Use it instead of the patch you've made. If it doesn't work, please send us the dmesg logs with tuner-xc2028 debug enabled. Thanks! Mauro - cx23885-dvb: Fix demod IF This device is not using the proper demod IF. Instead of using the IF macro, it is specifying a IF frequency. This doesn't work, as xc3028 needs to load an specific SCODE for the tuner. In this case, there's no IF table for 5 MHz. Signed-off-by: Mauro Carvalho Chehab --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index ad2fd13..168142e 100644 --- a/drivers/media/video/cx23885/cx23885-dvb.c +++ b/drivers/media/video/cx23885/cx23885-dvb.c @@ -844,7 +844,7 @@ static int dvb_register(struct cx23885_tsport *port) static struct xc2028_ctrl ctl = { .fname = XC3028L_DEFAULT_FIRMWARE, .max_len = 64, - .demod = 5000, + .demod = XC3028_FE_DIBCOM52, /* This is true for all demods with v36 firmware? */ .type = XC2028_D2633,