From patchwork Sun Sep 23 11:36:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 1495261 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DAD08400EC for ; Sun, 23 Sep 2012 11:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512Ab2IWLg7 (ORCPT ); Sun, 23 Sep 2012 07:36:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5534 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485Ab2IWLg6 (ORCPT ); Sun, 23 Sep 2012 07:36:58 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8NBavDd009072 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 23 Sep 2012 07:36:57 -0400 Received: from [10.97.7.49] (vpn1-7-49.gru2.redhat.com [10.97.7.49]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8NBataO002363 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 23 Sep 2012 07:36:56 -0400 Message-ID: <505EF455.9080604@redhat.com> Date: Sun, 23 Sep 2012 08:36:53 -0300 From: Mauro Carvalho Chehab User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Anders Eriksson CC: "linux-media@vger.kernel.org" Subject: Re: tda8290 regression fix References: <503F4E19.1050700@gmail.com> <20120915133417.27cb82a1@redhat.com> <5054BD53.7060109@gmail.com> <20120915145834.0b763f73@redhat.com> <5054C521.1090200@gmail.com> <20120915192530.74aedaa6@redhat.com> <50559241.6070408@gmail.com> <505844A0.30001@redhat.com> <5059C242.3010902@gmail.com> <5059F68F.4050009@redhat.com> <505A1C16.40507@gmail.com> <505C7E64.4040507@redhat.com> <8ed8c988-fa8c-41fc-9f33-cccdceb1b232@email.android.com> In-Reply-To: <8ed8c988-fa8c-41fc-9f33-cccdceb1b232@email.android.com> X-Enigmail-Version: 1.4.4 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em 22-09-2012 11:32, Anders Eriksson escreveu: > Not to my knowledge. It's a standard antenna cable to my cabletv box. I watch tv over hdmi to get HD. I only use analogue (and this htpc card) to record stuff. (please, don't top-post - it makes harder to preserve the history of the discussions) Then, maybe that's the reason why you're having troubles with this board. The tda8290-based devices have two components: 1) a tda8275 tuner, at address 0x61 at the 7-bit I2C address notation (or 0xc2, at the 8-bit notation); 2) a tda8290 analog demod at address 0x4b (7-bit notation). Some devices provide a way to send power to a low noise amplifier located at the antenna or at the device itself (called LNA). The way to activate the LNA is board-dependent. On some devices the tda8290 can also be used to enable/disable a linear amplifier (LNA). Enabling/disabling the LNA and its gain affects the quality of the signal. In the case of tda8275/tda8290 based devices, the LNA setup type is stored at priv->cfg->config, where: 0 - means no LNA control at all - device won't use it; 1, 2 - LNA is via a pin at tda8290 (GPIO 0): When config is 1, LNA high gain happens writing a 0; When config is 2, LNA high gain happens writing a 1; 3 - The LNA gain control is via a pin at saa713x. For modes 1 and 2, the switch_addr should be equal to 0x4b, as the commands sent to the device are for the tda8290 chip; sending them to tda8275 will likely produce no results or would affect something else there. I suspect that, in the case of your board, the LNA is at the antenna bundled together with the device. If I'm right, by enabling LNA, your board is sending some voltage through the cabling (you could easily check it with a voltmeter). What I think that your patch is actually doing is to disable LNA. As such, it should be equivalent to: Please test if the above patch fixes the issue you're suffering[1]. If so, then we'll need to add a modprobe parameter to allow disabling LNA for saa7134 devices with LNA. [1] Note: the above is not the fix, as some users of this board may be using the original antenna, and changing tuner_config will break things for them; the right fix is likely to allow controlling the LNA via userspace. Regards, Mauro --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/pci/saa7134/saa7134-cards.c b/drivers/media/pci/saa7134/saa7134-cards.c index bc08f1d..98b482e 100644 --- a/drivers/media/pci/saa7134/saa7134-cards.c +++ b/drivers/media/pci/saa7134/saa7134-cards.c @@ -3288,13 +3288,13 @@ struct saa7134_board saa7134_boards[] = { .name = "Pinnacle PCTV 310i", .audio_clock = 0x00187de7, .tuner_type = TUNER_PHILIPS_TDA8290, .radio_type = UNSET, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, - .tuner_config = 1, + .tuner_config = 0, .mpeg = SAA7134_MPEG_DVB, .gpiomask = 0x000200000, .inputs = {{ .name = name_tv, .vmux = 4, .amux = TV,