From patchwork Fri Jun 21 10:32:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Barinov X-Patchwork-Id: 2761381 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4555C9F39E for ; Fri, 21 Jun 2013 10:32:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 50C92201E4 for ; Fri, 21 Jun 2013 10:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48C08201D7 for ; Fri, 21 Jun 2013 10:32:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030247Ab3FUKca (ORCPT ); Fri, 21 Jun 2013 06:32:30 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:49463 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030216Ab3FUKc3 (ORCPT ); Fri, 21 Jun 2013 06:32:29 -0400 Received: by mail-la0-f45.google.com with SMTP id fr10so6997715lab.18 for ; Fri, 21 Jun 2013 03:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:x-gm-message-state; bh=8WPaYOIja/sZl7QH5RZTEpGT2BGmF7/6mAbeUiyQ3uo=; b=l/iaDNmVRatKSfmefYmeRc4pZhcJPlxheCRk+agizxHOhIzjcY+IRM+g0Y8MyR5pUu GvYrRY6Rvk3w6TE8LFkBqCGOviVfQfoaXT55qEEeU9sM3gPNEcp4seDTUKfhHBQMLFnm 91R4ZBNwF7YJFLwlfWWqrBNamt0XljcuMa1mMXrPFWNOGpPYyz9rCHTMnh/cJwryivrQ O7S7KPaIXIGkWkyb5niwGH00GARPkc2G0mYLsmv4xXiDGpLeSIzRbmMKfhLCKda2YlxW aYbBqu+6LvO19zr03YUY9Laffhb8GKBkrxdbk2CwWnabLfF+nDaFzbedZB1zJatlQdEF Mclw== X-Received: by 10.112.11.84 with SMTP id o20mr7238120lbb.86.1371810748148; Fri, 21 Jun 2013 03:32:28 -0700 (PDT) Received: from [192.168.10.101] ([46.32.73.80]) by mx.google.com with ESMTPSA id t15sm1727102lbh.16.2013.06.21.03.32.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Jun 2013 03:32:27 -0700 (PDT) Message-ID: <51C42BA5.9050105@cogentembedded.com> Date: Fri, 21 Jun 2013 14:32:05 +0400 From: Vladimir Barinov User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Katsuya MATSUBARA CC: sergei.shtylyov@cogentembedded.com, g.liakhovetski@gmx.de, mchehab@redhat.com, linux-media@vger.kernel.org, magnus.damm@gmail.com, linux-sh@vger.kernel.org, phil.edworthy@renesas.com Subject: Re: [PATCH v6] V4L2: soc_camera: Renesas R-Car VIN driver References: <51C40974.600@cogentembedded.com> <20130621.180932.452518378.matsu@igel.co.jp> <51C41F66.1060300@cogentembedded.com> <20130621.190157.27985389.matsu@igel.co.jp> In-Reply-To: <20130621.190157.27985389.matsu@igel.co.jp> X-Gm-Message-State: ALoCoQl9K7/LF++Tz/6CoP5M7zSvL5Qcd2Ca4IjQtjzEjaq/fsCWHCPhd0JyMxO7pfxMJEU1E3Wi Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Katsuya MATSUBARA wrote: > Hi Vladimir, > > From: Vladimir Barinov > Date: Fri, 21 Jun 2013 13:39:50 +0400 > > (snip) > >>> I have not seen such i2c errors during capturing and booting. >>> But I have seen that querystd() in the ml86v7667 driver often >>> returns V4L2_STD_UNKNOWN, although the corresponding function >>> >>> >> could you try Hans's fix: >> https://patchwork.kernel.org/patch/2640701/ >> > > The fix has been already applied in my environment. > I've found that after some iteration of submission we disabled the input signal in autodetection in ml86v7667_init(). per recommendations. That could be the case why the input signal is not locked. On adv7180 it still has optional autodetection but Hans recommended to get rid from runtime autodetection. So I've added input signal detection only during boot time. Could you please try the attached patch? Regards, Vladimir From: Vladimir Barinov Subject: V4L2: decoder: ml86v7667: fix querystd Input signal autodetection is disabled, hence the cached V4L2_STD must be used Signed-off-by: Vladimir Barinov --- drivers/media/i2c/ml86v7667.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) Index: build/drivers/media/i2c/ml86v7667.c =================================================================== --- build.orig/drivers/media/i2c/ml86v7667.c 2013-06-21 13:24:13.000000000 +0300 +++ build/drivers/media/i2c/ml86v7667.c 2013-06-21 13:26:07.308872980 +0300 @@ -162,17 +162,9 @@ static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std) { - struct i2c_client *client = v4l2_get_subdevdata(sd); - int status; + struct ml86v7667_priv *priv = to_ml86v7667(sd); - status = i2c_smbus_read_byte_data(client, STATUS_REG); - if (status < 0) - return status; - - if (status & STATUS_HLOCK_DETECT) - *std &= status & STATUS_NTSCPAL ? V4L2_STD_625_50 : V4L2_STD_525_60; - else - *std = V4L2_STD_UNKNOWN; + *std = priv->std; return 0; }